| commit | 11c07921c15e2fb7692375327b53f26a583b77ca | [log] [tgz] |
|---|---|---|
| author | tison <wander4096@gmail.com> | Thu Oct 10 14:37:45 2019 +0200 |
| committer | Andor Molnar <andor@apache.org> | Thu Oct 10 14:37:45 2019 +0200 |
| tree | 9e569a792cf94d6121c9f9b1eb6f7e2d7f089ee7 | |
| parent | 92fb05092aef6eb580e4259efc332f6f7cbdd994 [diff] |
ZOOKEEPER-3509: Revisit log format
1. Always wrap `.trace` with `isTraceEnabled`. It is because that some of trace calls are a bit complex.
2. Never wrap other levels with `isXXXEnabled`. Logger already checks log level and we don't make side effect or expensive operation in log statement.
3. Always use `{}` instead of string concatenation or `String.format`. Just for unification and it is what is recommended.
4. Always log throwable in warn or error level or debug if omit
5. Always log throwable as the last arg and never log `throwable.getMessage` since Logger already log stack trace.
Author: tison <wander4096@gmail.com>
Reviewers: enixon@apache.org, andor@apache.org
Closes #1100 from TisonKun/ZOOKEEPER-3509 and squashes the following commits:
0c3a4ded8 [tison] Address comment
dcb68eb61 [tison] ZOOKEEPER-3509: Revisit log format
For the latest information about Apache ZooKeeper, please visit our website at:
and our wiki, at:
https://cwiki.apache.org/confluence/display/ZOOKEEPER
Packaging/release artifacts
Either downloaded from https://zookeeper.apache.org/releases.html or found in zookeeper-assembly/target directory after building the project with maven.
apache-zookeeper-[version].tar.gz
Contains all the source files which can be built by running:
mvn clean install
To generate an aggregated apidocs for zookeeper-server and zookeeper-jute:
mvn javadoc:aggregate
(generated files will be at target/site/apidocs)
apache-zookeeper-[version]-bin.tar.gz
Contains all the jar files required to run ZooKeeper
Full documentation can also be found in the docs folder
As of version 3.5.5, the parent, zookeeper and zookeeper-jute artifacts are deployed to the central repository after the release is voted on and approved by the Apache ZooKeeper PMC:
https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/
We always welcome new contributors to the project! See How to Contribute for details on how to submit patch through pull request and our contribution workflow.