commit 062da914d93c4f0f2ee75a3523000d91c0240e30
author Josh Tynjala <joshtynjala@apache.org> Wed Oct 14 11:10:48 2020 -0700
committer Josh Tynjala <joshtynjala@apache.org> Wed Oct 14 11:10:48 2020 -0700
tree 107118c167ba0e12cf9652d64db4c9f4547bafec
parent 7acb9fefcccc9862337d04fd848e7019f34b776d

AccessorDefinition: fix null exception in hasConflictingLanguageNSDefinition() when accessor is created by [Bindable] variable

The code assumed that getFunctionNode() would be non-null, but bindable variables won't have a function node. Switched to getNode() instead.

compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java

diff --git a/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java b/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
index e47d4e8..f842087 100644
--- a/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
+++ b/compiler/src/main/java/org/apache/royale/compiler/internal/definitions/AccessorDefinition.java
@@ -239,7 +239,7 @@
                     ((AccessorDefinition) check).problematic = true;
                     //checking occurs twice, don't add multiple duplicate problems for the same check
                     problematic = true;
-                    project.getProblems().add(new DuplicateFunctionDefinitionProblem(getFunctionNode().getNameExpressionNode(), this.getBaseName()));
+                    project.getProblems().add(new DuplicateFunctionDefinitionProblem(getNode().getNameExpressionNode(), this.getBaseName()));
                 }
                 return true;
             }