Minor Improvements: (#242)
* remove redundant initialization
diff --git a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/io/FrameOutputStream.java b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/io/FrameOutputStream.java
index 960bd88..fa79ba6 100644
--- a/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/io/FrameOutputStream.java
+++ b/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/io/FrameOutputStream.java
@@ -41,7 +41,7 @@
private final OutputStream outputStream;
private final byte[] cache;
- private int cachePosition = 0;
+ private int cachePosition;
public FrameOutputStream(final int minChunkSize, final OutputStream outputStream) {
super();
diff --git a/httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveDataConsumer.java b/httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveDataConsumer.java
index 1818c69..85604e0 100644
--- a/httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveDataConsumer.java
+++ b/httpcore5-reactive/src/main/java/org/apache/hc/core5/reactive/ReactiveDataConsumer.java
@@ -60,8 +60,8 @@
private final AtomicBoolean flushInProgress = new AtomicBoolean(false);
private final Object flushLock = new Object();
private final AtomicInteger windowScalingIncrement = new AtomicInteger(0);
- private volatile boolean cancelled = false;
- private volatile boolean completed = false;
+ private volatile boolean cancelled;
+ private volatile boolean completed;
private volatile Exception exception;
private volatile CapacityChannel capacityChannel;
private volatile Subscriber<? super ByteBuffer> subscriber;
diff --git a/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/reactive/ReactiveTestUtils.java b/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/reactive/ReactiveTestUtils.java
index 541d7b1..66c0dc8 100644
--- a/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/reactive/ReactiveTestUtils.java
+++ b/httpcore5-testing/src/main/java/org/apache/hc/core5/testing/reactive/ReactiveTestUtils.java
@@ -87,7 +87,7 @@
) {
return Flowable.generate(new Consumer<Emitter<ByteBuffer>>() {
final Random random = new Random(length); // Use the length as the random seed for easy reproducibility
- long bytesEmitted = 0;
+ long bytesEmitted;
final MessageDigest md = newMessageDigest();
@Override
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java
index 12527ef..81ad0ee 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedInputStream.java
@@ -81,10 +81,10 @@
private long pos;
/** True if we've reached the end of stream */
- private boolean eof = false;
+ private boolean eof;
/** True if this stream is closed */
- private boolean closed = false;
+ private boolean closed;
private Header[] footers = EMPTY_FOOTERS;
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
index dcb88c6..b7d9faf 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
@@ -58,9 +58,9 @@
private final OutputStream outputStream;
private final byte[] cache;
- private int cachePosition = 0;
- private boolean wroteLastChunk = false;
- private boolean closed = false;
+ private int cachePosition;
+ private boolean wroteLastChunk;
+ private boolean closed;
private final CharArrayBuffer lineBuffer;
private final Supplier<List<? extends Header>> trailerSupplier;
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java
index ff3613c..56d405f 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ContentLengthInputStream.java
@@ -65,10 +65,10 @@
private final long contentLength;
/** The current position */
- private long pos = 0;
+ private long pos;
/** True if the stream is closed. */
- private boolean closed = false;
+ private boolean closed;
/**
* Default constructor.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
index bf6cbe6..9f11a76 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
@@ -204,7 +204,7 @@
final OutputStream socketOutputStream = socketHolder.getOutputStream();
final InputStream socketInputStream = socketHolder.getInputStream();
- long totalBytes = 0;
+ long totalBytes;
void checkForEarlyResponse(final long totalBytesSent, final int nextWriteSize) throws IOException {
if (responseOutOfOrderStrategy.isEarlyResponseDetected(
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityInputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityInputStream.java
index ea8d97a..acc294f 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityInputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityInputStream.java
@@ -51,7 +51,7 @@
private final SessionInputBuffer buffer;
private final InputStream inputStream;
- private boolean closed = false;
+ private boolean closed;
/**
* Default constructor.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityOutputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityOutputStream.java
index 44c9e9e..98ce718 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityOutputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/IdentityOutputStream.java
@@ -52,7 +52,7 @@
private final OutputStream outputStream;
/** True if the stream is closed. */
- private boolean closed = false;
+ private boolean closed;
/**
* Default constructor.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/message/AbstractHeaderElementIterator.java b/httpcore5/src/main/java/org/apache/hc/core5/http/message/AbstractHeaderElementIterator.java
index ed4e4b1..21ee047 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/message/AbstractHeaderElementIterator.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/message/AbstractHeaderElementIterator.java
@@ -43,9 +43,9 @@
private final Iterator<Header> headerIt;
- private T currentElement = null;
- private CharSequence buffer = null;
- private ParserCursor cursor = null;
+ private T currentElement;
+ private CharSequence buffer;
+ private ParserCursor cursor;
/**
* Creates a new instance of BasicHeaderElementIterator
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpDateGenerator.java b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpDateGenerator.java
index c60875a..9d2eea1 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpDateGenerator.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpDateGenerator.java
@@ -56,8 +56,8 @@
public static final HttpDateGenerator INSTANCE = new HttpDateGenerator(PATTERN_RFC1123, Locale.US, GMT);
private final DateFormat dateformat;
- private long dateAsMillis = 0L;
- private String dateAsText = null;
+ private long dateAsMillis;
+ private String dateAsText;
HttpDateGenerator() {
super();
