commit ad607a1d76b445f0d7e84c6b8add1a7d53217208
author Viraj Jasani <virajjasani007@gmail.com> Mon Dec 02 11:12:27 2019 +0530
committer Michael Stack <saintstack@users.noreply.github.com> Sun Dec 01 21:42:27 2019 -0800
tree a0ba91a44f1a9eaa1a8528cd147b79b68768fd6a
parent f7839f5eb66df34323ff1877f78227301b6eb29c

HBASE-23335 : Improving cost functions array copy in StochasticLoadBalancer (#874)

hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
index 5ad32f6..911f8fe 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
@@ -417,9 +417,7 @@
 
     double currentCost = computeCost(cluster, Double.MAX_VALUE);
     curOverallCost = currentCost;
-    for (int i = 0; i < this.curFunctionCosts.length; i++) {
-      curFunctionCosts[i] = tempFunctionCosts[i];
-    }
+    System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, curFunctionCosts.length);
     double initCost = currentCost;
     double newCost = currentCost;
 
@@ -463,9 +461,7 @@
 
         // save for JMX
         curOverallCost = currentCost;
-        for (int i = 0; i < this.curFunctionCosts.length; i++) {
-          curFunctionCosts[i] = tempFunctionCosts[i];
-        }
+        System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, curFunctionCosts.length);
       } else {
         // Put things back the way they were before.
         // TODO: undo by remembering old values