commit 5d7ef04c6895c67235052fb85781fcf87102c84d
author Eugene <liujin@apache.org> Mon Oct 01 23:02:13 2018 +0800
committer William Guo <guoyp@apache.org> Mon Oct 01 23:02:13 2018 +0800
tree 8ca9c8af5ea41e5818c0ae853a3dda67f3e925e4
parent 3dda6b3459d2b3d9f091545e49e156ca5f230e2d

Fix code bug.

1.add java method description
2.reformat import statements violating Griffin's code rule https://github.com/apache/incubator-griffin/blob/master/griffin-doc/dev/code-style.md

Author: Eugene <liujin@apache.org>

Closes #426 from toyboxman/src/service.

service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java

diff --git a/service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java b/service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java
index 71308ab..ba0a2e0 100644
--- a/service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java
+++ b/service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java
@@ -19,6 +19,8 @@
 
 package org.apache.griffin.core.util;
 
+import static org.apache.griffin.core.job.entity.LivySessionStates.State.DEAD;
+
 import com.google.gson.JsonObject;
 import com.google.gson.JsonParser;
 import org.apache.commons.lang.StringUtils;
@@ -30,13 +32,17 @@
 import org.springframework.web.client.HttpClientErrorException;
 import org.springframework.web.client.RestTemplate;
 
-import static org.apache.griffin.core.job.entity.LivySessionStates.State.DEAD;
-
 public class YarnNetUtil {
     private static final Logger LOGGER = LoggerFactory
             .getLogger(YarnNetUtil.class);
     private static RestTemplate restTemplate = new RestTemplate();
 
+    /**
+     * delete app task scheduling by yarn.
+     *
+     * @param url prefix part of whole url
+     * @param appId application id
+     */
     public static void delete(String url, String appId) {
         try {
             if (appId != null) {
@@ -53,6 +59,13 @@
         }
     }
 
+    /**
+     * update app task scheduling by yarn.
+     *
+     * @param url prefix part of whole url
+     * @param instance job instance
+     * @return
+     */
     public static boolean update(String url, JobInstanceBean instance) {
         try {
             url += "/ws/v1/cluster/apps/" + instance.getAppId();
@@ -76,6 +89,12 @@
         return false;
     }
 
+    /**
+     * parse json string and get app json object.
+     *
+     * @param json json string
+     * @return
+     */
     public static JsonObject parse(String json) {
         if (StringUtils.isEmpty(json)) {
             LOGGER.warn("Input string is empty.");