| commit | b1fbe92222dde3472427b1308d5d20e9ab465620 | [log] [tgz] |
|---|---|---|
| author | nzomkxia <z82507200@gmail.com> | Wed Dec 05 10:15:00 2018 +0800 |
| committer | nzomkxia <z82507200@gmail.com> | Wed Dec 05 10:15:00 2018 +0800 |
| tree | 184de375798df346fde1eafb976a2a00dd60f4ef | |
| parent | d5c14c21217346cb886eeac87bd0a7a66aeb32a4 [diff] |
throw resource not found exception
diff --git a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/controller/ConditionRoutesController.java b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/controller/ConditionRoutesController.java index ee0f9dc..1dd9650 100644 --- a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/controller/ConditionRoutesController.java +++ b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/controller/ConditionRoutesController.java
@@ -56,7 +56,7 @@ public boolean updateRule(@PathVariable String id, @RequestBody ConditionRouteDTO newConditionRoute, @PathVariable String env) { ConditionRouteDTO oldConditionRoute = routeService.findConditionRoute(id); if (oldConditionRoute == null) { - //throw exception + throw new ResourceNotFoundException("can not find route rule for: " + id); } routeService.updateConditionRoute(oldConditionRoute, newConditionRoute); return true;
diff --git a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/service/impl/RouteServiceImpl.java b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/service/impl/RouteServiceImpl.java index 778101c..d3e89cb 100644 --- a/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/service/impl/RouteServiceImpl.java +++ b/dubbo-admin-backend/src/main/java/org/apache/dubbo/admin/service/impl/RouteServiceImpl.java
@@ -152,6 +152,7 @@ tagRoute = convertTagRouteDTOtoStore(tagRoute); String path = getPath(tagRoute.getKey(), Constants.TAG_ROUTE); if (dynamicConfiguration.getConfig(path) == null) { + throw new ResourceNotFoundException("can not find tagroute: " + tagRoute.getKey()); //throw exception } dynamicConfiguration.setConfig(path, YamlParser.dumpObject(tagRoute));