commit f2166b3e8ac4ceb49e8c55628b4057c237c21365
author AlexanderSaydakov <AlexanderSaydakov@users.noreply.github.com> Tue Apr 25 12:29:47 2023 -0700
committer AlexanderSaydakov <AlexanderSaydakov@users.noreply.github.com> Tue Apr 25 12:29:47 2023 -0700
tree c18005ffe39b826c2c36a6a24fb25bf7faca026d
parent dbe45995e46670ca6aecf4be2047e34533765cb7

better treatment of sampling probability

src/aod_sketch_pg_functions.c

diff --git a/src/aod_sketch_pg_functions.c b/src/aod_sketch_pg_functions.c
index 018be64..bab1c0d 100644
--- a/src/aod_sketch_pg_functions.c
+++ b/src/aod_sketch_pg_functions.c
@@ -129,7 +129,7 @@
     stateptr->type = MUTABLE_SKETCH;
     stateptr->lg_k = PG_NARGS() > 3 ? PG_GETARG_INT32(3) : 0;
     stateptr->num_values = arr_len;
-    p = PG_NARGS() > 4 ? PG_GETARG_FLOAT4(4) : 1;
+    p = PG_NARGS() > 4 ? PG_GETARG_FLOAT4(4) : 0;
     if (stateptr->lg_k) {
       stateptr->ptr = p ? aod_sketch_new_lgk_p(arr_len, stateptr->lg_k, p) : aod_sketch_new_lgk(arr_len, stateptr->lg_k);
     } else {

src/theta_sketch_pg_functions.c

diff --git a/src/theta_sketch_pg_functions.c b/src/theta_sketch_pg_functions.c
index e72bb80..d10a1ed 100644
--- a/src/theta_sketch_pg_functions.c
+++ b/src/theta_sketch_pg_functions.c
@@ -90,7 +90,7 @@
     stateptr = palloc(sizeof(struct agg_state));
     stateptr->type = MUTABLE_SKETCH;
     stateptr->lg_k = PG_NARGS() > 2 ? PG_GETARG_INT32(2) : 0;
-    p = PG_NARGS() > 3 ? PG_GETARG_FLOAT4(3) : 1;
+    p = PG_NARGS() > 3 ? PG_GETARG_FLOAT4(3) : 0;
     if (stateptr->lg_k) {
       stateptr->ptr = p ? theta_sketch_new_lgk_p(stateptr->lg_k, p) : theta_sketch_new_lgk(stateptr->lg_k);
     } else {