commit db16042e7db44fe5edb422fe00e34af8390b306c
author Alexander Saydakov <13126686+AlexanderSaydakov@users.noreply.github.com> Mon Nov 07 15:23:46 2022 -0800
committer GitHub <noreply@github.com> Mon Nov 07 15:23:46 2022 -0800
tree b0ffe91092ff36bd5f4162d4ad97932934cc4e24
parent a892f37281f65b8b5e047aa08693bbfd277aa955
parent 62d457b672c34879f4682ffa7f7d3e38d2ef6275

Merge pull request #56 from apache/standard_c

use standard C

src/quantiles_double_sketch_pg_functions.c

diff --git a/src/quantiles_double_sketch_pg_functions.c b/src/quantiles_double_sketch_pg_functions.c
index dbc2b79..713e54e 100644
--- a/src/quantiles_double_sketch_pg_functions.c
+++ b/src/quantiles_double_sketch_pg_functions.c
@@ -345,6 +345,11 @@
   void* sketchptr;
   int num_bins;
 
+  double* split_points;
+  double min_value;
+  double max_value;
+  double delta;
+
   // output array of bins
   Datum* result;
   ArrayType* arr_out;
@@ -363,10 +368,10 @@
     elog(ERROR, "at least two bins expected");
   }
 
-  double* split_points = palloc(sizeof(double) * (num_bins - 1));
-  const double min_value = quantiles_double_sketch_get_quantile(sketchptr, 0);
-  const double max_value = quantiles_double_sketch_get_quantile(sketchptr, 1);
-  const double delta = (max_value - min_value) / num_bins;
+  split_points = palloc(sizeof(double) * (num_bins - 1));
+  min_value = quantiles_double_sketch_get_quantile(sketchptr, 0);
+  max_value = quantiles_double_sketch_get_quantile(sketchptr, 1);
+  delta = (max_value - min_value) / num_bins;
   for (i = 0; i < num_bins - 1; i++) {
     split_points[i] = min_value + delta * (i + 1);
   }

src/req_float_sketch_pg_functions.c

diff --git a/src/req_float_sketch_pg_functions.c b/src/req_float_sketch_pg_functions.c
index a42de15..f2696bc 100644
--- a/src/req_float_sketch_pg_functions.c
+++ b/src/req_float_sketch_pg_functions.c
@@ -366,6 +366,11 @@
   int num_bins;
   bool inclusive;
 
+  float* split_points;
+  float min_value;
+  float max_value;
+  float delta;
+
   // output array of bins
   Datum* result;
   ArrayType* arr_out;
@@ -386,10 +391,10 @@
 
   inclusive = PG_NARGS() > 2 ? PG_GETARG_BOOL(2) : false;
 
-  float* split_points = palloc(sizeof(float) * (num_bins - 1));
-  const float min_value = req_float_sketch_get_quantile(sketchptr, 0, inclusive);
-  const float max_value = req_float_sketch_get_quantile(sketchptr, 1, inclusive);
-  const float delta = (max_value - min_value) / num_bins;
+  split_points = palloc(sizeof(float) * (num_bins - 1));
+  min_value = req_float_sketch_get_quantile(sketchptr, 0, inclusive);
+  max_value = req_float_sketch_get_quantile(sketchptr, 1, inclusive);
+  delta = (max_value - min_value) / num_bins;
   for (i = 0; i < num_bins - 1; i++) {
     split_points[i] = min_value + delta * (i + 1);
   }