Merge branch 'master' into fix_issue_178
diff --git a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/Memory.java b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/Memory.java
index ea12620..eed7a4e 100644
--- a/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/Memory.java
+++ b/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/Memory.java
@@ -195,7 +195,7 @@
negativeCheck(offsetBytes, "offsetBytes");
negativeCheck(lengthBytes, "lengthBytes");
ResourceImpl.checkBounds(offsetBytes, lengthBytes, array.length);
- return BaseWritableMemoryImpl.wrapHeapArray(array, 0, lengthBytes, true, ByteOrder.nativeOrder(), null);
+ return BaseWritableMemoryImpl.wrapHeapArray(array, offsetBytes, lengthBytes, true, ByteOrder.nativeOrder(), null);
}
/**
diff --git a/datasketches-memory-java8/src/test/java/org/apache/datasketches/memory/internal/MemoryTest.java b/datasketches-memory-java8/src/test/java/org/apache/datasketches/memory/internal/MemoryTest.java
index 5b328d2..a211db6 100644
--- a/datasketches-memory-java8/src/test/java/org/apache/datasketches/memory/internal/MemoryTest.java
+++ b/datasketches-memory-java8/src/test/java/org/apache/datasketches/memory/internal/MemoryTest.java
@@ -399,6 +399,18 @@
}
@Test
+ public void checkIssue178() {
+ int n = 8;
+ byte[] bArr = new byte[n];
+ for (int i = 0; i < n; i++) { bArr[i] = (byte)i; }
+ Memory mem = Memory.wrap(bArr, n / 2, n / 2, ByteOrder.nativeOrder());
+ for (int i = 0; i < n / 2; i++) {
+ println(mem.getByte(i));
+ assertEquals(mem.getByte(i), n / 2 + i);
+ }
+ }
+
+ @Test
public void printlnTest() {
println("PRINTING: " + this.getClass().getName());
}
