CB-10636 Add JSHint for plugins
diff --git a/.gitignore b/.gitignore
index 52b558e..6964ea0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -12,7 +12,7 @@
*.swp
*.user
-
+node_modules
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..e042a96
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,17 @@
+{
+ "browser": true
+ , "devel": true
+ , "bitwise": true
+ , "undef": true
+ , "trailing": true
+ , "quotmark": false
+ , "indent": 4
+ , "unused": "vars"
+ , "latedef": "nofunc"
+ , "globals": {
+ "module": false,
+ "exports": false,
+ "require": false,
+ "console": true
+ }
+}
diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 0000000..b9af4c5
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,4 @@
+language: node_js
+sudo: false
+node_js:
+ - "4.2"
diff --git a/README.md b/README.md
index c835575..8c47c6b 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,8 @@
# under the License.
-->
+[![Build Status](https://travis-ci.org/apache/cordova-plugin-console.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-console)
+
# cordova-plugin-console
diff --git a/package.json b/package.json
index bf16201..8f72168 100644
--- a/package.json
+++ b/package.json
@@ -28,6 +28,13 @@
"cordova-windows8",
"cordova-windows"
],
+ "scripts": {
+ "test": "npm run jshint",
+ "jshint": "node node_modules/jshint/bin/jshint www && node node_modules/jshint/bin/jshint src && node node_modules/jshint/bin/jshint tests"
+ },
"author": "Apache Software Foundation",
- "license": "Apache-2.0"
+ "license": "Apache-2.0",
+ "devDependencies": {
+ "jshint": "^2.6.0"
+ }
}
diff --git a/tests/tests.js b/tests/tests.js
index 6479e41..74765d9 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -19,24 +19,24 @@
*
*/
+/* jshint jasmine: true */
+
exports.defineAutoTests = function () {
describe("Console", function () {
it("console.spec.1 should exist", function() {
expect(window.console).toBeDefined();
});
-
+
it("console.spec.2 has required methods log|warn|error", function(){
expect(window.console.log).toBeDefined();
expect(typeof window.console.log).toBe('function');
-
+
expect(window.console.warn).toBeDefined();
expect(typeof window.console.warn).toBe('function');
-
+
expect(window.console.error).toBeDefined();
- expect(typeof window.console.error).toBe('function');
-
+ expect(typeof window.console.error).toBe('function');
});
-
});
};
diff --git a/www/console-via-logger.js b/www/console-via-logger.js
index 4095eb3..ffee326 100644
--- a/www/console-via-logger.js
+++ b/www/console-via-logger.js
@@ -22,7 +22,6 @@
//------------------------------------------------------------------------------
var logger = require("./logger");
-var utils = require("cordova/utils");
//------------------------------------------------------------------------------
// object that we're exporting
diff --git a/www/logger.js b/www/logger.js
index cbf81b9..430d887 100644
--- a/www/logger.js
+++ b/www/logger.js
@@ -43,7 +43,6 @@
var logger = exports;
var exec = require('cordova/exec');
-var utils = require('cordova/utils');
var UseConsole = false;
var UseLogger = true;