commit c9f29c64d85c10a824798797c090d3321335ac8e
author Raphael von der Grün <raphinesse@gmail.com> Wed Sep 05 11:26:34 2018 +0200
committer GitHub <noreply@github.com> Wed Sep 05 11:26:34 2018 +0200
tree fbda50d91a114379be2956a9b1b41f025e8fa702
parent 7abc2b83cb7d44a047f4c0eac3962576a7b7facc

Remove callback parameter of main CLI function (#316)

Resolves #314

src/cli.js

diff --git a/src/cli.js b/src/cli.js
index 9158665..ff8e0c5 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -96,12 +96,7 @@
 
 var shouldCollectTelemetry = false;
 
-module.exports = function (inputArgs, cb) {
-    /**
-     * mainly used for testing.
-     */
-    cb = cb || function () {};
-
+module.exports = function (inputArgs) {
     // If no inputArgs given, use process.argv.
     inputArgs = inputArgs || process.argv;
     var cmd = inputArgs[2]; // e.g: inputArgs= 'node cordova run ios'
@@ -205,14 +200,10 @@
         if (shouldCollectTelemetry && !isTelemetryCmd) {
             telemetry.track(cmd, subcommand, 'successful');
         }
-        // call cb with error as arg if something failed
-        cb(null);
     }).catch(function (err) {
         if (shouldCollectTelemetry && !isTelemetryCmd) {
             telemetry.track(cmd, subcommand, 'unsuccessful');
         }
-        // call cb with error as arg if something failed
-        cb(err);
         throw err;
     });
 };