Remove flaky test/assertion in PendingTaskProcessorTest
I realized I added a flaky assertion in `PendingTaskProcessorTest` in
https://reviews.apache.org/r/66536/
I got extremely unlucky and every time I ran the tests it passed until after
I merged :( The stat `preemptor_slot_search_[success|failed]_for_[name]` will
not appear unless the job slot search actually succeeds or fails (i.e. it
cannot be 0 since it is dynamically generated). We were getting lucky where the
test would search for JOB_A slots first and create the stat. However, when
JOB_B gets searched first, the JOB_A stat is never created because there are no
slaves to search through anymore.
I removed the assertion because there is a sufficient assertion directly above,
and the stat is tested in multiple other tests.
The assertion would result in a `NullPointerException`.
Reviewed at https://reviews.apache.org/r/66570/
diff --git a/src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java b/src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
index 0bd8d21..82b7aee 100644
--- a/src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
+++ b/src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
@@ -224,8 +224,6 @@
// evaluated first.
assertTrue(ImmutableSet.of(0L, 2L).contains(
statsProvider.getLongValue(slotSearchStatName(false, true))));
- assertTrue(ImmutableSet.of(0L, 2L).contains(
- statsProvider.getLongValue(slotSearchByJobStatName(false, JOB_A))));
assertEquals(1L, statsProvider.getLongValue(UNMATCHED_TASKS));
assertEquals(2L, statsProvider.getLongValue(CACHE_SIZE_STAT_NAME));
}
