ATLAS-3590: fix HiveHook to avoid incorrect alter-table-property notifications
Signed-off-by: Madhan Neethiraj <madhan@apache.org>
diff --git a/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java b/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
index 251fddd..1585b43 100644
--- a/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
+++ b/addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
@@ -94,7 +94,7 @@
context.setOperation(ALTERTABLE_RENAME);
} else if (isColumnRename(oldTable, newTable, context)) {
context.setOperation(ALTERTABLE_RENAMECOL);
- } else {
+ } else if(isAlterTableProperty(tableEvent)){
context.setOperation(ALTERTABLE_PROPERTIES); // map other alter table operations to ALTERTABLE_PROPERTIES
}
@@ -190,4 +190,20 @@
return isColumnRename;
}
+
+ private boolean isAlterTableProperty(AlterTableEvent tableEvent) {
+ final boolean ret;
+ String oldTableModifiedTime = tableEvent.getOldTable().getParameters().get("last_modified_time");
+ String newTableModifiedTime = tableEvent.getNewTable().getParameters().get("last_modified_time");
+
+
+ if (oldTableModifiedTime == null) {
+ ret = newTableModifiedTime != null;
+ } else {
+ ret = !oldTableModifiedTime.equals(newTableModifiedTime);
+ }
+
+ return ret;
+
+ }
}
\ No newline at end of file
