blob: f869b75601fdfd672c7e70cb51b3412ec28f315a [file] [log] [blame]
ezcMailPartParser
=================
[x] The function parseHeader() should be refactored. The new code has in
the if() and elseif() case duplicated code that can easily be extracted
into a new private method.
The code is too coupled and the private function will have 4-5 params.
It applies to only 4 lines of code. The solution which I tried actually
looks worse than what it is now.
[x] The test in trunk/Mail/tests/composer_test.php should removed the
added check for "charset=binary" as that is a bug in PHP (line 647ish)
[ ] From reading the code, I don't think that it is possible to use
headers with the same name while creating mail as well. This needs to
be supported so that mails can be forwarded with all current headers
in tact. We'd need to add tests for both generation and forwarding/replying
here.