commit 50b7d235f4e1eaeffb7ff891d7cfc84cce0b9488
author Jeff Zhang <zjffdu@apache.org> Sun Nov 05 19:35:14 2017 +0800
committer Jeff Zhang <zjffdu@apache.org> Mon Nov 06 15:45:33 2017 +0800
tree b4593fab900eae821a3e5f80687a72dd8eda7119
parent c0e2ab6575f2d2cb88f9cfea98af041e88c8f02d

ZEPPELIN-3034. Only apply dynamic form for LivySqlnterpreter

Simple PR to only apply dynamic forms for LivySqlInterpreter, this make the behavior consistent with zeppelin's built-in spark interpreter.

[Bug Fix]

* [ ] - Task

* https://issues.apache.org/jira/browse/ZEPPELIN-3034

* Does the licenses files need update?  No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #2651 from zjffdu/ZEPPELIN-3034 and squashes the following commits:

39eff37 [Jeff Zhang] ZEPPELIN-3034. Only apply dynamic form for LivySqlnterpreter

(cherry picked from commit 4054320a443fbcb6c14225c589f56c01ea8b4eaa)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>

docs/interpreter/livy.md

diff --git a/docs/interpreter/livy.md b/docs/interpreter/livy.md
index 132f327..b70016e 100644
--- a/docs/interpreter/livy.md
+++ b/docs/interpreter/livy.md
@@ -200,12 +200,13 @@
 
 
 ## Apply Zeppelin Dynamic Forms
-You can leverage [Zeppelin Dynamic Form](../manual/dynamicform.html). You can use both the `text input` and `select form` parameterization features.
+You can leverage [Zeppelin Dynamic Form](../usage/dynamic_form/intro.html). Form templates is only avalible for livy sql interpreter.
+```
+%livy.sql
+select * from products where ${product_id=1}
+```
 
-```
-%livy.pyspark
-print "${group_by=product_id,product_id|product_name|customer_id|store_id}"
-```
+And creating dynamic formst programmatically is not feasible in livy interpreter, because ZeppelinContext is not available in livy interpreter.
 
 ## FAQ
 

livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java

diff --git a/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java b/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java
index 2c92bbf..67220b4 100644
--- a/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java
+++ b/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java
@@ -190,7 +190,7 @@
 
   @Override
   public FormType getFormType() {
-    return FormType.SIMPLE;
+    return FormType.NATIVE;
   }
 
   @Override

livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java

diff --git a/livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java b/livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
index 9a51971..05667bb 100644
--- a/livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
+++ b/livy/src/main/java/org/apache/zeppelin/livy/LivySparkSQLInterpreter.java
@@ -146,6 +146,11 @@
     }
   }
 
+  @Override
+  public FormType getFormType() {
+    return FormType.SIMPLE;
+  }
+
   protected List<String> parseSQLOutput(String output) {
     List<String> rows = new ArrayList<>();
     String[] lines = output.split("\n");