commit 881a0a58975ea91a4c676132ec9c93635d2caad8
author Michael Glavassevich <mrglavas@apache.org> Wed Dec 28 18:50:56 2011 +0000
committer Michael Glavassevich <mrglavas@apache.org> Wed Dec 28 18:50:56 2011 +0000
tree b7667954444bc5d8242d79e91e30ec6514267e3f
parent 7cd1b571c10d03f9cf6b5401a163a128060e8a5d

Reducing object allocation. Use Boolean constants instead.

src/org/apache/xpath/jaxp/XPathExpressionImpl.java

diff --git a/src/org/apache/xpath/jaxp/XPathExpressionImpl.java b/src/org/apache/xpath/jaxp/XPathExpressionImpl.java
index 1f88081..7fe69bf 100644
--- a/src/org/apache/xpath/jaxp/XPathExpressionImpl.java
+++ b/src/org/apache/xpath/jaxp/XPathExpressionImpl.java
@@ -342,7 +342,7 @@
         }
         // XPathConstants.BOOLEAN
         if ( returnType.equals( XPathConstants.BOOLEAN ) ) {
-            return new Boolean( resultObject.bool());
+            return resultObject.bool() ? Boolean.TRUE : Boolean.FALSE;
         }
         // XPathConstants.NODESET ---ORdered, UNOrdered???
         if ( returnType.equals( XPathConstants.NODESET ) ) {

src/org/apache/xpath/jaxp/XPathFactoryImpl.java

diff --git a/src/org/apache/xpath/jaxp/XPathFactoryImpl.java b/src/org/apache/xpath/jaxp/XPathFactoryImpl.java
index bdb917d..51bc31c 100644
--- a/src/org/apache/xpath/jaxp/XPathFactoryImpl.java
+++ b/src/org/apache/xpath/jaxp/XPathFactoryImpl.java
@@ -34,7 +34,7 @@
  * @version $Revision$
  * @author  Ramesh Mandava
  */
-public  class XPathFactoryImpl extends XPathFactory {
+public class XPathFactoryImpl extends XPathFactory {
 	
 	/**
 	 * <p>Name of class as a constant to use for debugging.</p>
@@ -140,7 +140,7 @@
             if (name == null) {
                 String fmsg = XSLMessages.createXPATHMessage(
                         XPATHErrorResources.ER_FEATURE_NAME_NULL,
-                        new Object[] { CLASS_NAME, new Boolean( value) } );
+                        new Object[] { CLASS_NAME, value ? Boolean.TRUE : Boolean.FALSE } );
                 throw new NullPointerException( fmsg );
              }
 		
@@ -156,7 +156,7 @@
             // unknown feature
             String fmsg = XSLMessages.createXPATHMessage(
                     XPATHErrorResources.ER_FEATURE_UNKNOWN,
-                    new Object[] { name, CLASS_NAME, new Boolean(value) } );
+                    new Object[] { name, CLASS_NAME, value ? Boolean.TRUE : Boolean.FALSE } );
             throw new XPathFactoryConfigurationException( fmsg );
 	}