commit 6c85ab1ed7c748bbc22e2fda40a8b2c85870f2f9
author Michael Glavassevich <mrglavas@apache.org> Thu Dec 29 05:36:43 2011 +0000
committer Michael Glavassevich <mrglavas@apache.org> Thu Dec 29 05:36:43 2011 +0000
tree d36e87849d18664d11f99575ef3866dbf48e6e2b
parent 2a2f7b1c541478af0c1d30c80480f67fc00eea58

Eliminate creation of temporary strings in loops.

src/org/apache/xalan/templates/ElemNumber.java

diff --git a/src/org/apache/xalan/templates/ElemNumber.java b/src/org/apache/xalan/templates/ElemNumber.java
index 23ad540..d65c5a5 100644
--- a/src/org/apache/xalan/templates/ElemNumber.java
+++ b/src/org/apache/xalan/templates/ElemNumber.java
@@ -1219,7 +1219,7 @@
           // then append the formatToken.
           else if (formatTokenizer.isLetterOrDigitAhead())
           {
-            formatTokenString = formatToken;
+            final StringBuffer formatTokenStringBuffer = new StringBuffer(formatToken);
 
             // Append the formatToken string...
             // For instance [2][1][5] with a format value of "1--1. "
@@ -1227,8 +1227,9 @@
             while (formatTokenizer.nextIsSep())
             {
               formatToken = formatTokenizer.nextToken();
-              formatTokenString += formatToken;
+              formatTokenStringBuffer.append(formatToken);
             }
+            formatTokenString = formatTokenStringBuffer.toString();
 
             // Record this separator, so it can be used as the 
             // next separator, if the next is the last.
@@ -1943,16 +1944,17 @@
       return getZeroString();
     }
 
-    String roman = "";
+    final String roman;
     int place = 0;
 
     if (val <= 3999L)
     {
+      StringBuffer romanBuffer = new StringBuffer();
       do
       {
         while (val >= m_romanConvertTable[place].m_postValue)
         {
-          roman += m_romanConvertTable[place].m_postLetter;
+          romanBuffer.append(m_romanConvertTable[place].m_postLetter);
           val -= m_romanConvertTable[place].m_postValue;
         }
 
@@ -1960,7 +1962,7 @@
         {
           if (val >= m_romanConvertTable[place].m_preValue)
           {
-            roman += m_romanConvertTable[place].m_preLetter;
+            romanBuffer.append(m_romanConvertTable[place].m_preLetter);
             val -= m_romanConvertTable[place].m_preValue;
           }
         }
@@ -1968,6 +1970,7 @@
         place++;
       }
       while (val > 0);
+      roman = romanBuffer.toString();
     }
     else
     {