commit 4a6b1e47ab84a8d97a611749bbf0149f1d8527da
author Michael Glavassevich <mrglavas@apache.org> Wed Dec 28 23:03:43 2011 +0000
committer Michael Glavassevich <mrglavas@apache.org> Wed Dec 28 23:03:43 2011 +0000
tree 0c20b7c4b1dcdeb2b7fbc3c2207706553ec89c4a
parent 35e7074e6001d8271bc606d357f153150d681ced

Minor performance improvement. String.length() == 0 tends to be slightly faster than String.equals("").

src/org/apache/xalan/templates/ElemLiteralResult.java

diff --git a/src/org/apache/xalan/templates/ElemLiteralResult.java b/src/org/apache/xalan/templates/ElemLiteralResult.java
index 1bf9cd2..246fb05 100644
--- a/src/org/apache/xalan/templates/ElemLiteralResult.java
+++ b/src/org/apache/xalan/templates/ElemLiteralResult.java
@@ -251,9 +251,9 @@
         AVT avt = (AVT) m_avts.get(i);
         namespace = avt.getURI();
         
-        if ((namespace != null && (!namespace.equals("")) && (namespace 
+        if ((namespace != null && (namespace.length() != 0) && (namespace 
                 +":"+avt.getName()).equals(name))|| ((namespace == null || 
-                namespace.equals(""))&& avt.getRawName().equals(name)))
+                namespace.length() == 0)&& avt.getRawName().equals(name)))
         {
           return avt;
         }
@@ -836,7 +836,7 @@
           public String getNamespaceURI()
           {
                   String uri = m_attribute.getURI();
-                  return (uri.equals(""))?null:uri;
+                  return (uri.length() == 0)?null:uri;
           }
 
           /**
@@ -858,7 +858,7 @@
           {
                   String uri = m_attribute.getURI();
                   String localName = getLocalName();
-                  return (uri.equals(""))?localName:uri+":"+localName;
+                  return (uri.length() == 0)?localName:uri+":"+localName;
           }
           
           /**
@@ -913,7 +913,7 @@
           {
                   String uri = m_attribute.getURI();
                   String rawName = m_attribute.getRawName();
-                  return (uri.equals(""))? 
+                  return (uri.length() == 0)? 
                         null:rawName.substring(0, rawName.indexOf(":"));
           }