Fixed quotes and missing {} (code style)
diff --git a/helpers/query.js b/helpers/query.js
index 0b3e6cd..5389860 100644
--- a/helpers/query.js
+++ b/helpers/query.js
@@ -5,6 +5,6 @@
module.exports = {
useQuotesIfRequired: function(value) {
- return isNumeric(value) ? value : util.format('\'%s\'', value)
+ return isNumeric(value) ? value : util.format("'%s'", value)
}
}
\ No newline at end of file
diff --git a/lib/client.js b/lib/client.js
index bf2d35b..44fa77b 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -32,7 +32,7 @@
if (self.orgId !== undefined && self.appId !== undefined) {
return self
} else {
- throw new Error('\'orgId\' and \'appId\' parameters are required when instantiating UsergridClient')
+ throw new Error('"orgId" and "appId" parameters are required when instantiating UsergridClient')
}
}
@@ -46,8 +46,9 @@
}
UsergridClient.prototype.PUT = function(type, uuidOrName, body, callback) {
- if (typeof uuidOrName !== 'string')
- throw new Error('\'uuidOrName\' parameter is required when making a PUT request')
+ if (typeof uuidOrName !== 'string') {
+ throw new Error('"uuidOrName" parameter is required when making a PUT request')
+ }
return new UsergridRequest({
client: this,
method: 'PUT',
@@ -68,8 +69,9 @@
}
UsergridClient.prototype.DELETE = function(type, uuidOrName, callback) {
- if (typeof uuidOrName !== 'string')
- throw new Error('\'uuidOrName\' parameter is required when making a DELETE request')
+ if (typeof uuidOrName !== 'string') {
+ throw new Error('"uuidOrName" parameter is required when making a DELETE request')
+ }
return new UsergridRequest({
client: this,
method: 'DELETE',
diff --git a/lib/request.js b/lib/request.js
index 620aab6..e63eb90 100644
--- a/lib/request.js
+++ b/lib/request.js
@@ -11,8 +11,9 @@
var UsergridRequest = function(opts, callback) {
callback = helpers.cb(callback)
- if (typeof opts.type !== 'string')
- throw new Error('\'type\' (or \'collection\') parameter is required when making a request')
+ if (typeof opts.type !== 'string') {
+ throw new Error('"type" (or "collection") parameter is required when making a request')
+ }
request(helpers.buildUrl(opts), {
headers: helpers.userAgent,
body: opts.body,
diff --git a/tests/lib/client.js b/tests/lib/client.js
index 5023637..dcc2efc 100644
--- a/tests/lib/client.js
+++ b/tests/lib/client.js
@@ -93,7 +93,7 @@
response.entity.should.be.an.Object.and.have.property('uuid').with.a.lengthOf(36)
})
- it('response.entity.author should equal \'Sir Arthur Conan Doyle\'', function() {
+ it('response.entity.author should equal "Sir Arthur Conan Doyle"', function() {
response.entity.should.have.property('author').equal('Sir Arthur Conan Doyle')
})
})
@@ -131,7 +131,7 @@
response.entity.should.be.an.Object.and.have.property('uuid').equal(_uuid)
})
- it('response.entity.narrator should equal \'Peter Doyle\'', function() {
+ it('response.entity.narrator should equal "Peter Doyle"', function() {
response.entity.should.have.property('narrator').equal('Peter Doyle')
})
})
@@ -163,7 +163,7 @@
response.statusCode.should.not.equal(200)
})
- it('response.error.name should equal \'service_resource_not_found\'', function() {
+ it('response.error.name should equal "service_resource_not_found"', function() {
response.error.name.should.equal('service_resource_not_found')
})
})
diff --git a/tests/lib/query.js b/tests/lib/query.js
index abde631..510f9ca 100644
--- a/tests/lib/query.js
+++ b/tests/lib/query.js
@@ -6,17 +6,17 @@
UsergridQuery = require('../../lib/query')
describe('type', function() {
- it('query._type should equal \'cats\' when passing \'type\' as a parameter to UsergridQuery', function() {
+ it('query._type should equal "cats" when passing "type" as a parameter to UsergridQuery', function() {
var query = new UsergridQuery('cats')
query.should.have.property('_type').equal('cats')
})
- it('query._type should equal \'cats\' when calling .type() builder method', function() {
+ it('query._type should equal "cats" when calling .type() builder method', function() {
var query = new UsergridQuery().type('cats')
query.should.have.property('_type').equal('cats')
})
- it('query._type should equal \'cats\' when calling .collection() builder method', function() {
+ it('query._type should equal "cats" when calling .collection() builder method', function() {
var query = new UsergridQuery().collection('cats')
query.should.have.property('_type').equal('cats')
})
@@ -30,9 +30,10 @@
})
describe('eq', function() {
- it('query._ql should equal \"select * where color = \'black\'\"', function() {
+ var queryString = "select * where color = 'black'"
+ it(util.format('query._ql should equal %s', queryString), function() {
var query = new UsergridQuery().collection('cats').eq('color', 'black')
- query.should.have.property('_ql').equal('select * where color = \'black\'')
+ query.should.have.property('_ql').equal(queryString)
})
})
