Review fixes
diff --git a/core/sql/cli/Cli.cpp b/core/sql/cli/Cli.cpp
index 8930885..1c7fec2 100644
--- a/core/sql/cli/Cli.cpp
+++ b/core/sql/cli/Cli.cpp
@@ -8560,7 +8560,7 @@
// insert into lob descriptor handle table
str_sprintf(query, "select syskey from (insert into table(ghost table %s) values (%ld, 1, %ld)) x",
lobDescHandleName, descPartnKey, (dataLen ? *dataLen : 0));
- /*str_sprintf(query, "select syskey from (insert into table(ghost table cast(? as varchar(1024)) values (cast(? as largeint), 1, cast(? as largeint))) x");*/
+
lobDebugInfo(query,0,__LINE__,lobTrace);
// set parserflags to allow ghost table
@@ -8568,20 +8568,7 @@
Int64 descSyskey = 0;
Lng32 len = 0;
- /*
- strcpy(stmtName,"INS1");
- cliRC = cliInterface->executeImmediatePrepare(query,NULL,0,&rowsAffected,FALSE,stmtName);
- if (cliRC < 0)
- goto error_return;
- char *inputValues = new (currContext.exHeap()) char[sizeof(Int32) + strlen(lobDescHandleName) + sizeof(Int64)*2];
- *(Int32 *)inputValues= strlen(lobDescHandleName);
- memcpy(&inputValues[sizeof(Int32)],lobDescHandleName,strlen(lobDescHandleName));
-
- inputValues[sizeof(Int32) + strlen(lobDescHandleName)] = descPartnKey;
- inputValues[sizeof(Int32) + strlen(lobDescHandleName)+sizeof(Int64)] = (dataLen ? *dataLen : 0);
- inputValuesLen = sizeof(Int32) + strlen(lobDescHandleName)+sizeof(Int64)*2;
- cliRC = cliInterface->clearExecFetchCloseOpt((char *)inputValues,inputValuesLen,(char*)&descSyskey,&len, &rowsAffected);
- */
+
cliRC = cliInterface->executeImmediate(query,
(char*)&descSyskey, &len, FALSE);
if (cliRC < 0)
diff --git a/core/sql/cli/SQLCLIdev.h b/core/sql/cli/SQLCLIdev.h
index 700c561..e7dee07 100644
--- a/core/sql/cli/SQLCLIdev.h
+++ b/core/sql/cli/SQLCLIdev.h
@@ -37,20 +37,7 @@
*
*
******************************************************************************
- }
- catch(...)
- {
- retcode = -CLI_INTERNAL_ERROR;
-#if defined(_THROW_EXCEPTIONS)
- if (cliWillThrow())
- {
- throw;
- }
-#endif
- }
-
- RecordError(NULL, retcode);
- return retcode;*/
+*/
#include "sqlcli.h"
#include "Platform.h" // 64-BIT