commit c05cc614f4e5942b264309f110eb3a8e0bbc7134
author remm <remm@apache.org> Tue Sep 22 09:30:53 2020 +0200
committer remm <remm@apache.org> Tue Sep 22 09:30:53 2020 +0200
tree 822662e9e5ac83f20642b509b1668592082796be
parent 5bf42bb3139f82e61b5098344e997e339ef14644

Fix warning

src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java

diff --git a/src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java b/src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java
index 418b57f..0e0ba2a 100644
--- a/src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java
+++ b/src/test/java/org/apache/tomcat/jakartaee/MigrationTest.java
@@ -157,11 +157,12 @@
         assertEquals("jakarta.servlet.CommonGatewayInterface", cls.getSuperclass().getName());
 
         // check the modification of the Implementation-Version manifest attribute
-        JarFile jar = new JarFile(jarFile);
-        String implementationVersion = jar.getManifest().getMainAttributes().getValue("Implementation-Version");
-        assertNotNull("Missing Implementation-Version manifest attribute", implementationVersion);
-        assertNotEquals("Implementation-Version manifest attribute not changed", "1.2.3", implementationVersion);
-        assertTrue("Implementation-Version manifest attribute doesn't match the expected pattern", implementationVersion.matches("1\\.2\\.3-migrated-[\\d\\.]+.*"));
+        try (JarFile jar = new JarFile(jarFile)) {
+            String implementationVersion = jar.getManifest().getMainAttributes().getValue("Implementation-Version");
+            assertNotNull("Missing Implementation-Version manifest attribute", implementationVersion);
+            assertNotEquals("Implementation-Version manifest attribute not changed", "1.2.3", implementationVersion);
+            assertTrue("Implementation-Version manifest attribute doesn't match the expected pattern", implementationVersion.matches("1\\.2\\.3-migrated-[\\d\\.]+.*"));
+        }
     }
 
     @Test
@@ -187,9 +188,10 @@
         migration.setDestination(jarFile);
         migration.execute();
 
-        JarFile jar = new JarFile(jarFile);
-        assertNull("Digest not removed from the manifest", jar.getManifest().getAttributes("org/apache/tomcat/jakartaee/HelloCGI.class"));
-        assertNull("Signature key not removed", jar.getEntry("META-INF/" + algorithm.toUpperCase() + "." + algorithm.toUpperCase()));
-        assertNull("Signed manifest not removed", jar.getEntry("META-INF/" + algorithm.toUpperCase() + ".SF"));
+        try (JarFile jar = new JarFile(jarFile)) {
+            assertNull("Digest not removed from the manifest", jar.getManifest().getAttributes("org/apache/tomcat/jakartaee/HelloCGI.class"));
+            assertNull("Signature key not removed", jar.getEntry("META-INF/" + algorithm.toUpperCase() + "." + algorithm.toUpperCase()));
+            assertNull("Signed manifest not removed", jar.getEntry("META-INF/" + algorithm.toUpperCase() + ".SF"));
+        }
     }
 }