[30086] Shell component should allow informal parameters
git-svn-id: https://svn.apache.org/repos/asf/jakarta/tapestry/branches/branch-3-0@243935 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/doc/src/ComponentReference/Shell.html b/doc/src/ComponentReference/Shell.html
index 49c7b4a..539e95e 100644
--- a/doc/src/ComponentReference/Shell.html
+++ b/doc/src/ComponentReference/Shell.html
@@ -199,7 +199,7 @@
</table>
<P>Body: <STRONG>rendered<BR></STRONG>Informal parameters:
- <STRONG>forbidden</STRONG>
+ <STRONG>allowed (applied to <html> tag)</STRONG>
<br>
Reserved parameters: <EM>none</EM>
diff --git a/framework/src/org/apache/tapestry/html/Shell.java b/framework/src/org/apache/tapestry/html/Shell.java
index 02bbf97..eba3eb9 100644
--- a/framework/src/org/apache/tapestry/html/Shell.java
+++ b/framework/src/org/apache/tapestry/html/Shell.java
@@ -67,6 +67,7 @@
writer.comment("Generated: " + new Date());
writer.begin("html");
+ renderInformalParameters(writer, cycle);
writer.println();
writer.begin("head");
writer.println();
diff --git a/framework/src/org/apache/tapestry/html/Shell.jwc b/framework/src/org/apache/tapestry/html/Shell.jwc
index 578707a..65b7894 100644
--- a/framework/src/org/apache/tapestry/html/Shell.jwc
+++ b/framework/src/org/apache/tapestry/html/Shell.jwc
@@ -14,12 +14,11 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<!-- $Id$ -->
<!DOCTYPE component-specification PUBLIC
"-//Apache Software Foundation//Tapestry Specification 3.0//EN"
"http://jakarta.apache.org/tapestry/dtd/Tapestry_3_0.dtd">
-<component-specification class="org.apache.tapestry.html.Shell" allow-informal-parameters="no">
+<component-specification class="org.apache.tapestry.html.Shell" allow-informal-parameters="yes">
<description>
Provides the outer tags in an HTML page: <html>, <head> and <title>.
diff --git a/junit/context37/Home.html b/junit/context37/Home.html
new file mode 100644
index 0000000..58733b2
--- /dev/null
+++ b/junit/context37/Home.html
@@ -0,0 +1 @@
+<html jwcid="@Shell" title="Shell Informal Parameters" xmlns="http://www.w3.org/1999/xhtml"/>
\ No newline at end of file
diff --git a/junit/context37/README b/junit/context37/README
new file mode 100644
index 0000000..7f0da6a
--- /dev/null
+++ b/junit/context37/README
@@ -0,0 +1 @@
+30086: Shell component should allow informal parameters
\ No newline at end of file
diff --git a/junit/mock-scripts/TestShellAbstractParameters.xml b/junit/mock-scripts/TestShellAbstractParameters.xml
new file mode 100644
index 0000000..f514d7c
--- /dev/null
+++ b/junit/mock-scripts/TestShellAbstractParameters.xml
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Copyright 2004 The Apache Software Foundation
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<mock-test>
+ <context name="c37" root="context37"/>
+
+ <servlet name="app" class="org.apache.tapestry.ApplicationServlet"/>
+
+ <request>
+ <assert-output name="HTML tag">
+<![CDATA[
+<html xmlns="http://www.w3.org/1999/xhtml">
+]]>
+ </assert-output>
+
+ </request>
+
+</mock-test>
\ No newline at end of file
diff --git a/status.xml b/status.xml
index fef36fa..e68c247 100644
--- a/status.xml
+++ b/status.xml
@@ -274,6 +274,10 @@
Allow abstract pages/components even if no specified properties (or other enhancements)
</action>
+ <action type="fix" dev="HLS" fixes-bug="30086">
+ Shell component should allow informal parameters
+ </action>
+
</release>
<release version="3.0" date="Apr 18 2004">
