commit 0c3ef11869225c2a8c3970404af20f9c34aa9f73
author Thiago H. de Paula Figueiredo <thiago@arsmachina.com.br> Tue Sep 29 10:49:54 2020 -0300
committer Thiago H. de Paula Figueiredo <thiago@arsmachina.com.br> Tue Sep 29 14:35:29 2020 -0300
tree 339393916a59652968e5ad0aacbf4e45b43a52a4
parent dbdd429affd0a05f6a5ff9ef82642bc6caada804

TAP5-2643: NPE in Label when corresponding form field isn't rendered

tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java

diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
index bc3fa8d..dd153b3 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Label.java
@@ -118,9 +118,13 @@
         labelElement.attribute("id", id);
         labelElement.forceAttributes("for", fieldId);
         
-        Element input = labelElement.getDocument().getElementById(field.getClientId());
-        if (input != null) {
-            input.attribute("aria-labelledby", id);
+        if (fieldId != null)
+        {
+            Element input = labelElement.getDocument().getElementById(field.getClientId());
+            if (input != null) 
+            {
+                input.attribute("aria-labelledby", id);
+            }
         }
         
         decorator.insideLabel(field, labelElement);