commit 62c9a978c642cddcc2c76d6f07a9cc771bc32ba0
author shafreen <shafreen@wso2.com> Tue Mar 31 07:47:46 2020 +0530
committer shafreen <shafreen@wso2.com> Tue Mar 31 07:47:46 2020 +0530
tree d68bea9497ca22fbac2beaab3b2b11195fa3e9f8
parent 69e0d5df566a15384c51a7cc197aa484f27c4264

Move constants to Message Processor Constents

modules/core/src/main/java/org/apache/synapse/SynapseConstants.java

diff --git a/modules/core/src/main/java/org/apache/synapse/SynapseConstants.java b/modules/core/src/main/java/org/apache/synapse/SynapseConstants.java
index b8e80c5..3424f0a 100644
--- a/modules/core/src/main/java/org/apache/synapse/SynapseConstants.java
+++ b/modules/core/src/main/java/org/apache/synapse/SynapseConstants.java
@@ -412,9 +412,6 @@
 
     public static final String HTTP_SENDER_STATUSCODE = "transport.http.statusCode";
 
-    public static final String HTTP_INTERNAL_SERVER_ERROR = "500";
-    public static final String HTTP_BAD_REQUEST_ERROR = "400";
-
     // Fail-safe mode properties
     public static final String FAIL_SAFE_MODE_STATUS = "failsafe.mode.enable";
     public static final String FAIL_SAFE_MODE_ALL = "all";

modules/core/src/main/java/org/apache/synapse/message/processors/MessageProcessorConsents.java

diff --git a/modules/core/src/main/java/org/apache/synapse/message/processors/MessageProcessorConsents.java b/modules/core/src/main/java/org/apache/synapse/message/processors/MessageProcessorConsents.java
index e7c98aa..92f83ef 100644
--- a/modules/core/src/main/java/org/apache/synapse/message/processors/MessageProcessorConsents.java
+++ b/modules/core/src/main/java/org/apache/synapse/message/processors/MessageProcessorConsents.java
@@ -35,4 +35,10 @@
      */
     public static final String MAX_DELIVER_ATTEMPTS = "max.deliver.attempts";
 
+    /**
+     * HTTP status codes which are used for message processor retry implementation
+     */
+    public static final String HTTP_INTERNAL_SERVER_ERROR = "500";
+    public static final String HTTP_BAD_REQUEST_ERROR = "400";
+
 }

modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java

diff --git a/modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java b/modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
index 90c8e65..40ef410 100644
--- a/modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
+++ b/modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
@@ -288,12 +288,12 @@
     private void handle400and500statusCodes(MessageContext outCtx) {
         if ((outCtx.getProperty(NhttpConstants.HTTP_SC) != null)) {
             String httpStatusCode =  outCtx.getProperty(NhttpConstants.HTTP_SC).toString();
-            if (httpStatusCode.equals(SynapseConstants.HTTP_INTERNAL_SERVER_ERROR)) {
+            if (httpStatusCode.equals(MessageProcessorConsents.HTTP_INTERNAL_SERVER_ERROR)) {
                 outCtx.setProperty(SynapseConstants.BLOCKING_CLIENT_ERROR, "true");
-                outCtx.setProperty(SynapseConstants.ERROR_MESSAGE, SynapseConstants.HTTP_INTERNAL_SERVER_ERROR);
-            } else if (httpStatusCode.equals(SynapseConstants.HTTP_BAD_REQUEST_ERROR)) {
+                outCtx.setProperty(SynapseConstants.ERROR_MESSAGE, MessageProcessorConsents.HTTP_INTERNAL_SERVER_ERROR);
+            } else if (httpStatusCode.equals(MessageProcessorConsents.HTTP_BAD_REQUEST_ERROR)) {
                 outCtx.setProperty(SynapseConstants.BLOCKING_CLIENT_ERROR, "true");
-                outCtx.setProperty(SynapseConstants.ERROR_MESSAGE, SynapseConstants.HTTP_BAD_REQUEST_ERROR);
+                outCtx.setProperty(SynapseConstants.ERROR_MESSAGE, MessageProcessorConsents.HTTP_BAD_REQUEST_ERROR);
             }
         }
     }