blob: 3b9f0666c9586f633182b3cac8abc876ff8beb2b [file] [log] [blame]
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import uuid
from unittest.mock import MagicMock, patch
import pytest
from parameterized import parameterized
from superset.models.slice import id_or_uuid_filter, Slice
class TestSlice:
"""Test cases for Slice model functionality."""
@parameterized.expand(
[
("numeric_id", "123"),
("uuid_string", "550e8400-e29b-41d4-a716-446655440000"),
]
)
def test_slice_get_calls_filter_correctly(self, test_name, id_or_uuid):
"""Test Slice.get() calls filter() correctly for ID and UUID."""
with patch("superset.models.slice.db") as mock_db:
# Setup mock chain
mock_query = MagicMock()
mock_filtered_query = MagicMock()
mock_db.session.query.return_value = mock_query
mock_query.filter.return_value = mock_filtered_query
mock_filtered_query.one_or_none.return_value = None
# Call the method
result = Slice.get(id_or_uuid)
# Verify correct methods called
mock_db.session.query.assert_called_once_with(Slice)
mock_query.filter.assert_called_once() # Not filter_by!
mock_filtered_query.one_or_none.assert_called_once()
assert result is None
@parameterized.expand(
[
("numeric_id", "123"),
("large_id", "999999"),
("uuid_string", str(uuid.uuid4())),
]
)
def test_slice_get_no_type_error(self, test_name, input_value):
"""Verify Slice.get() doesn't raise TypeError for various inputs."""
try:
result = Slice.get(input_value)
# Success - no TypeError, result can be None or a Slice
assert result is None or hasattr(result, "id")
except TypeError as e:
if "filter_by() takes 1 positional argument" in str(e):
pytest.fail(
f"filter_by() bug exists: Slice.get('{input_value}') failed with {e}" # noqa: E501
)
else:
raise
@parameterized.expand(
[
("numeric_id", "123"),
("uuid_format", "550e8400-e29b-41d4-a716-446655440000"),
("invalid_string", "not-a-number"),
]
)
def test_id_or_uuid_filter(self, test_name, input_value):
"""Test id_or_uuid_filter returns correct BinaryExpression."""
result = id_or_uuid_filter(input_value)
assert result is not None