commit bee386e643a202f182a5cffd03c460fc27efe959
author Guy Doulberg <guydou@gmail.com> Mon Jul 05 19:00:13 2021 +0300
committer GitHub <noreply@github.com> Tue Jul 06 00:00:13 2021 +0800
tree d25b879500570cf27206a4152ce8730132afe036
parent 15796ea4ac065c13e249f66b74e3272943227ecd

feat: supporting jinja templating in saved metrics  (#15502)

* feat: supporting jinja templating in saved metrics

* cutting the line length to fit requirements

* follwing PR I should have not created a new insance method

* running precommit locally and fixing the issue

Co-authored-by: Guy <guy@nexite.io>

superset/connectors/sqla/models.py

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index 7e3811a..a6aeabf 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -413,7 +413,8 @@
 
     def get_sqla_col(self, label: Optional[str] = None) -> Column:
         label = label or self.metric_name
-        sqla_col: ColumnClause = literal_column(self.expression)
+        tp = self.table.get_template_processor()
+        sqla_col: ColumnClause = literal_column(tp.process_template(self.expression))
         return self.table.make_sqla_column_compatible(sqla_col, label)
 
     @property