commit 960d1e4d5deb7a050e7f579e4224575880643c2c
author Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Mon Aug 30 16:42:02 2021 -0700
committer GitHub <noreply@github.com> Mon Aug 30 16:42:02 2021 -0700
tree 0a3911f14d687b4a814d9163528053f7554ddd92
parent 2199f65373c2ca9ccc51e1d2b046f14c1e801cdb

fix: stop endless loading when dataset no longer exist (#16511)

* initial fix

* add const

* add translate

superset-frontend/src/chart/Chart.jsx

diff --git a/superset-frontend/src/chart/Chart.jsx b/superset-frontend/src/chart/Chart.jsx
index d66dd86..e5cfd72 100644
--- a/superset-frontend/src/chart/Chart.jsx
+++ b/superset-frontend/src/chart/Chart.jsx
@@ -68,6 +68,9 @@
 };
 
 const BLANK = {};
+const NONEXISTENT_DATASET = t(
+  'The dataset associated with this chart no longer exists',
+);
 
 const defaultProps = {
   addFilter: () => BLANK,
@@ -178,7 +181,11 @@
     const message = chartAlert || queryResponse?.message;
 
     // if datasource is still loading, don't render JS errors
-    if (chartAlert && datasource === PLACEHOLDER_DATASOURCE) {
+    if (
+      chartAlert !== undefined &&
+      chartAlert !== NONEXISTENT_DATASET &&
+      datasource === PLACEHOLDER_DATASOURCE
+    ) {
       return (
         <Styles
           data-ui-anchor="chart"