commit 160273f843d52412477978e5aa5d9fa3479c01c2
author Stefan Fuhrmann <stefan2@apache.org> Sat Apr 10 15:32:06 2021 +0000
committer Stefan Fuhrmann <stefan2@apache.org> Sat Apr 10 15:32:06 2021 +0000
tree a10e6a8d6270cce4a837746a9cab20848e18596e
parent dd74d55dc3e95ac1a1e75c98060c41100c70842f

Fix segfault when the root task has output to process.

* subversion/libsvn_subr/task.c
  (remove_task): Make sure we don't access the RESULTS after freeing
                 the memory.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1888588 13f79535-47bb-0310-9956-ffa450edef68

subversion/libsvn_subr/task.c

diff --git a/subversion/libsvn_subr/task.c b/subversion/libsvn_subr/task.c
index 18343fd..80cfbf2 100644
--- a/subversion/libsvn_subr/task.c
+++ b/subversion/libsvn_subr/task.c
@@ -466,6 +466,12 @@
       if (parent->last_sub == task)
         parent->last_sub = NULL;
     }
+  else
+    {
+      /* Root task.  Keep it because we might rely on it being present.
+       * However, make sure nobody tries to process its outputs twice. */
+      task->results = NULL;
+    }
 
   return SVN_NO_ERROR;
 }