commit 332cbe5f1bfd8753a1a4f6ba1fcad5d3476de4e2
author Rui Li <rui.li@verizonmedia.com> Thu Jul 02 13:07:36 2020 -0500
committer GitHub <noreply@github.com> Thu Jul 02 13:07:36 2020 -0500
tree ea0d320574a028f7575190796f61217b727dabf9
parent c98b2d120c8af19148c61192beb4f56226078edb

[STORM-3661] handle exception when netty server receive unexpected message (#3296)

storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java

diff --git a/storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java b/storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
index 8a37d1e..94c5d75 100644
--- a/storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
+++ b/storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
@@ -260,7 +260,16 @@
 
     @Override
     public void received(Object message, String remote, Channel channel) throws InterruptedException {
-        List<TaskMessage> msgs = (List<TaskMessage>) message;
+        List<TaskMessage> msgs;
+
+        try {
+            msgs = (List<TaskMessage>) message;
+        } catch (ClassCastException e) {
+            LOG.error("Worker netty server received message other than the expected class List<TaskMessage> from remote: {}. Ignored.",
+                remote, e);
+            return;
+        }
+
         enqueue(msgs, remote);
     }