commit 0859cd191715a09f5c84e781e3d0e3ca89e60654
author agresch <agresch@gmail.com> Mon Mar 08 09:31:39 2021 -0600
committer GitHub <noreply@github.com> Mon Mar 08 09:31:39 2021 -0600
tree 9b0140be8f77d807ffb3a29f1d6dff3f78fcd300
parent 5f9fabc22e0741e62aa0c96c150709ccae74b9e8

STORM-3749 improve logging for server error (#3384)

Co-authored-by: Aaron Gresch <agresch@yahoo-inc.com>

storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java

diff --git a/storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java b/storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java
index 5cc5c05..0088395 100644
--- a/storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java
+++ b/storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java
@@ -16,7 +16,6 @@
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.Set;
-import java.util.concurrent.atomic.AtomicInteger;
 import org.apache.storm.shade.io.netty.channel.Channel;
 import org.apache.storm.shade.io.netty.channel.ChannelHandlerContext;
 import org.apache.storm.shade.io.netty.channel.ChannelInboundHandlerAdapter;
@@ -28,11 +27,9 @@
     private static final Logger LOG = LoggerFactory.getLogger(StormServerHandler.class);
     private static final Set<Class<?>> ALLOWED_EXCEPTIONS = new HashSet<>(Arrays.asList(new Class<?>[]{ IOException.class }));
     private final IServer server;
-    private final AtomicInteger failureCount;
 
     public StormServerHandler(IServer server) {
         this.server = server;
-        failureCount = new AtomicInteger(0);
     }
 
     @Override
@@ -51,14 +48,13 @@
             server.received(msg, channel.remoteAddress().toString(), channel);
         } catch (InterruptedException e) {
             LOG.info("failed to enqueue a request message", e);
-            failureCount.incrementAndGet();
         }
     }
 
     @Override
     public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
         try {
-            LOG.error("server errors in handling the request", cause);
+            LOG.error("server errors in handling the request from {}", ctx.channel().remoteAddress().toString(), cause);
         } catch (Throwable err) {
             // Doing nothing (probably due to an oom issue) and hoping Utils.handleUncaughtException will handle it
         }