commit 7f61ae21e39a45b2b5e0107c4165bc4a255a27eb
author Szabolcs Vasas <vasas@apache.org> Thu Oct 25 08:40:00 2018 +0200
committer Szabolcs Vasas <vasas@apache.org> Thu Oct 25 08:40:00 2018 +0200
tree 57daa86589cc770978e769f78be1fbc9ecdbb482
parent 7ab99f41cf75da22e523c132cb782bb20102b348

SQOOP-3399: TestS3ImportWithHadoopCredProvider fails if credential generator command is not provided

(Szabolcs Vasas)

src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java

diff --git a/src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java b/src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java
index e03eb64..3a0d636 100644
--- a/src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java
+++ b/src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java
@@ -78,11 +78,11 @@
         String generatorCommand = S3TestUtils.getGeneratorCommand();
         if (generatorCommand != null) {
             s3CredentialGenerator = new DefaultS3CredentialGenerator(generatorCommand);
+            generateTempProviderFileNames();
+            fillCredentialProviderDefault();
+            fillCredentialProviderPwdFile();
+            fillCredentialProviderEnv();
         }
-        generateTempProviderFileNames();
-        fillCredentialProviderDefault();
-        fillCredentialProviderPwdFile();
-        fillCredentialProviderEnv();
     }
 
     @Before
@@ -102,9 +102,9 @@
 
     @AfterClass
     public static void deleteTemporaryCredFiles() {
-        providerFileDefault.deleteOnExit();
-        providerFileEnvPwd.deleteOnExit();
-        providerFilePwdFile.deleteOnExit();
+        deleteFileOnExit(providerFileDefault);
+        deleteFileOnExit(providerFileEnvPwd);
+        deleteFileOnExit(providerFilePwdFile);
     }
 
     @Test
@@ -210,4 +210,10 @@
     private static void setHadoopCredStorePwdEnvVar() {
         environmentVariables.set(HADOOP_CREDSTORE_PASSWORD_ENV_NAME, "credProviderPwd");
     }
+
+    private static void deleteFileOnExit(File file) {
+        if (file != null) {
+            file.deleteOnExit();
+        }
+    }
 }