commit 7d6667ddb65ff1e5c5ff2c4b764a8b3996016bf1
author Venkat Ranganathan <venkat@hortonworks.com> Fri Nov 11 14:06:21 2016 -0800
committer Venkat Ranganathan <venkat@hortonworks.com> Fri Nov 11 14:06:21 2016 -0800
tree 1854007b32c9f2e095b2b76a1b02cddb83ed98bb
parent 68f76982a01ff2f7c92279df3466466c9cf5d8cc

SQOOP-2990: Sqoop(oracle) export [updateTableToOracle] with "--update-mode allowinsert" : app fails with java.sql.SQLException: Missing IN or OUT parameter at index

  (Sowmya Ramesh via Venkat Ranganathan)

src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java

diff --git a/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java b/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java
index f79aaa9..88754e7 100644
--- a/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java
+++ b/src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java
@@ -71,7 +71,7 @@
       // lookup table for update columns
       Set<String> updateKeyLookup = new LinkedHashSet<String>();
       for (String updateKey : updateCols) {
-        updateKeyLookup.add(updateKey);
+        updateKeyLookup.add('"' + updateKey + '"');
       }
 
       StringBuilder sb = new StringBuilder();
@@ -85,7 +85,7 @@
         } else {
           sb.append(" AND ");
         }
-        sb.append(updateCols[i]).append(" = ?");
+        sb.append('"' + updateCols[i] + '"').append(" = ?");
       }
       sb.append(" )");