commit 7dabbcd103f0714baed16ef1ec9e28cb3644efcb
author Stefan Seifert <stefanseifert@users.noreply.github.com> Fri Nov 26 15:45:57 2021 +0100
committer Stefan Seifert <stefanseifert@users.noreply.github.com> Fri Nov 26 15:45:57 2021 +0100
tree 77f041460678bdee887d38bcb1e912497f1b8a44
parent ce4aad991cba7869ad57b41bf96a6ce69df20f9b

cosmetic: move implemented method out of the "unsupported operations" block

core/src/main/java/org/apache/sling/testing/mock/osgi/MockConfigurationAdmin.java

diff --git a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockConfigurationAdmin.java b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockConfigurationAdmin.java
index 157f4dd..5c8eda0 100644
--- a/core/src/main/java/org/apache/sling/testing/mock/osgi/MockConfigurationAdmin.java
+++ b/core/src/main/java/org/apache/sling/testing/mock/osgi/MockConfigurationAdmin.java
@@ -18,20 +18,21 @@
  */
 package org.apache.sling.testing.mock.osgi;
 
+import java.io.IOException;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.Filter;
 import org.osgi.framework.InvalidSyntaxException;
 import org.osgi.service.cm.Configuration;
 import org.osgi.service.cm.ConfigurationAdmin;
 
-import java.io.IOException;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentMap;
-
 /**
  * Mock implementation of {@link ConfigurationAdmin}.
  */
 class MockConfigurationAdmin implements ConfigurationAdmin {
+
     private final BundleContext bundleContext;
     private final ConcurrentMap<String, Configuration> configs = new ConcurrentHashMap<>();
 
@@ -45,6 +46,21 @@
         return configs.get(pid);
     }
 
+    @Override
+    @SuppressWarnings("squid:S1168")
+    public Configuration[] listConfigurations(final String filter) throws IOException, InvalidSyntaxException {
+        final Filter filterObject = bundleContext.createFilter(filter);
+        final Configuration[] filtered = configs
+                .values()
+                .stream()
+                .filter(configuration -> filterObject.match(configuration.getProperties()))
+                .toArray(Configuration[]::new);
+        if (filtered.length != 0) {
+            return filtered;
+        }
+        return null;
+    }
+
     // --- unsupported operations ---
 
     @Override
@@ -63,21 +79,6 @@
     }
 
     @Override
-    @SuppressWarnings("squid:S1168")
-    public Configuration[] listConfigurations(final String filter) throws IOException, InvalidSyntaxException {
-        final Filter filterObject = bundleContext.createFilter(filter);
-        final Configuration[] filtered = configs
-                .values()
-                .stream()
-                .filter(configuration -> filterObject.match(configuration.getProperties()))
-                .toArray(Configuration[]::new);
-        if (filtered.length != 0) {
-            return filtered;
-        }
-        return null;
-    }
-
-    @Override
     public Configuration getFactoryConfiguration(final String factoryPid, final String name, final String location) throws IOException {
         throw new UnsupportedOperationException();
     }