commit da31a123d56b007971a6d46a9b56ae2756934895
author Vikas Saurabh <vsaurabh@adobe.com> Mon Sep 16 19:09:54 2019 +0530
committer Andrei Dulvac <andrei.dulvac@gmail.com> Mon Sep 16 21:57:19 2019 +0200
tree 7fdecd976fbbe969a4187f31cead13423d0ce29c
parent a04c8139fd6a232f67583a019c71b9f66d63f96b

SLING-8710: IndexingClient should have configurable lanes

Fix sonar's complain of code smell

src/main/java/org/apache/sling/testing/clients/indexing/IndexingClient.java

diff --git a/src/main/java/org/apache/sling/testing/clients/indexing/IndexingClient.java b/src/main/java/org/apache/sling/testing/clients/indexing/IndexingClient.java
index 62cf14d..8c6d57c 100644
--- a/src/main/java/org/apache/sling/testing/clients/indexing/IndexingClient.java
+++ b/src/main/java/org/apache/sling/testing/clients/indexing/IndexingClient.java
@@ -182,7 +182,7 @@
      */
     public List<String> getLaneNames() throws ClientException {
         List<String> configuredLanes = getConfiguredLaneNames();
-        if (configuredLanes != null) {
+        if (!configuredLanes.isEmpty()) {
             return configuredLanes;
         }
 
@@ -210,7 +210,7 @@
     private List<String> getConfiguredLaneNames() {
         String configLanesCsv = getValue(INDEX_LANES_CSV_CONFIG_NAME);
         if (configLanesCsv == null) {
-            return null;
+            return Collections.emptyList();
         }
 
         String[] configLanesArr = configLanesCsv.split(",");