Add missing vendor property
git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@1804960 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/sling/rewriter/impl/PipelineImpl.java b/src/main/java/org/apache/sling/rewriter/impl/PipelineImpl.java
index 76b6e3d..a4a3e88 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/PipelineImpl.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/PipelineImpl.java
@@ -39,7 +39,7 @@
*/
public class PipelineImpl implements Processor {
- private static Logger LOGGER = LoggerFactory.getLogger(PipelineImpl.class);
+ private final Logger LOGGER = LoggerFactory.getLogger(PipelineImpl.class);
/** Empty array of transformers. */
private static final Transformer[] EMPTY_TRANSFORMERS = new Transformer[0];
@@ -69,6 +69,7 @@
/**
* @see org.apache.sling.rewriter.Processor#init(org.apache.sling.rewriter.ProcessingContext, org.apache.sling.rewriter.ProcessorConfiguration)
*/
+ @Override
public void init(ProcessingContext processingContext,
ProcessorConfiguration c)
throws IOException {
@@ -166,6 +167,7 @@
/**
* @see org.apache.sling.rewriter.Processor#getWriter()
*/
+ @Override
public PrintWriter getWriter() {
return this.generator.getWriter();
}
@@ -173,6 +175,7 @@
/**
* @see org.apache.sling.rewriter.Processor#getContentHandler()
*/
+ @Override
public ContentHandler getContentHandler() {
return this.firstContentHandler;
}
@@ -180,6 +183,7 @@
/**
* @see org.apache.sling.rewriter.Processor#finished(boolean)
*/
+ @Override
public void finished(final boolean errorOccured) throws IOException {
try {
// if an error occurred, we only clean up
diff --git a/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java b/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
index 8bad23f..e1df6c6 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java
@@ -43,6 +43,7 @@
import org.apache.sling.rewriter.ProcessorConfiguration;
import org.apache.sling.rewriter.ProcessorManager;
import org.osgi.framework.BundleContext;
+import org.osgi.framework.Constants;
import org.osgi.framework.InvalidSyntaxException;
import org.osgi.framework.ServiceRegistration;
import org.osgi.service.component.ComponentContext;
@@ -56,7 +57,10 @@
* This manager keeps track of configured processors.
*
*/
-@Component(service = ProcessorManager.class)
+@Component(service = ProcessorManager.class,
+ property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation"
+ })
public class ProcessorManagerImpl
implements ProcessorManager, ResourceChangeListener, ExternalResourceChangeListener {
@@ -75,10 +79,10 @@
private ResourceResolverFactory resourceResolverFactory;
/** loaded processor configurations */
- private final Map<String, ConfigEntry[]> processors = new HashMap<String, ConfigEntry[]>();
+ private final Map<String, ConfigEntry[]> processors = new HashMap<>();
/** Ordered processor configurations. */
- private List<ProcessorConfiguration> orderedProcessors = new ArrayList<ProcessorConfiguration>();
+ private List<ProcessorConfiguration> orderedProcessors = new ArrayList<>();
/** Event handler registration */
private volatile ServiceRegistration<ResourceChangeListener> eventHandlerRegistration;
@@ -102,7 +106,7 @@
// create array of search paths for actions and constraints
this.searchPath = this.initProcessors();
// register event handler
- final Dictionary<String, Object> props = new Hashtable<String, Object>();
+ final Dictionary<String, Object> props = new Hashtable<>();
props.put(ResourceChangeListener.CHANGES,
new String[] { ChangeType.ADDED.toString(), ChangeType.CHANGED.toString(),
ChangeType.REMOVED.toString(), ChangeType.PROVIDER_ADDED.toString(), ChangeType.PROVIDER_REMOVED.toString() });
diff --git a/src/main/java/org/apache/sling/rewriter/impl/RewriterFilter.java b/src/main/java/org/apache/sling/rewriter/impl/RewriterFilter.java
index 4cc80eb..453f071 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/RewriterFilter.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/RewriterFilter.java
@@ -39,6 +39,7 @@
@Component(
service = Filter.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"sling.filter.scope=request",
"sling.filter.scope=error",
Constants.SERVICE_RANKING + ":Integer=2500"
@@ -52,6 +53,7 @@
/**
* @see javax.servlet.Filter#init(javax.servlet.FilterConfig)
*/
+ @Override
public void init(FilterConfig config) throws ServletException {
// nothing to do
}
@@ -59,6 +61,7 @@
/**
* @see javax.servlet.Filter#destroy()
*/
+ @Override
public void destroy() {
// nothing to do
}
@@ -66,6 +69,7 @@
/**
* @see javax.servlet.Filter#doFilter(javax.servlet.ServletRequest, javax.servlet.ServletResponse, javax.servlet.FilterChain)
*/
+ @Override
public void doFilter(ServletRequest request,
ServletResponse response,
FilterChain chain)
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/HtmlGeneratorFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/HtmlGeneratorFactory.java
index 2353c85..0c5f2da 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/HtmlGeneratorFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/HtmlGeneratorFactory.java
@@ -26,6 +26,7 @@
import org.apache.sling.rewriter.GeneratorFactory;
import org.apache.sling.rewriter.ProcessingComponentConfiguration;
import org.apache.sling.rewriter.ProcessingContext;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Reference;
import org.xml.sax.ContentHandler;
@@ -38,6 +39,7 @@
*/
@Component(service = GeneratorFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=html-generator"
})
public class HtmlGeneratorFactory implements GeneratorFactory {
@@ -48,6 +50,7 @@
/**
* @see org.apache.sling.rewriter.GeneratorFactory#createGenerator()
*/
+ @Override
public Generator createGenerator() {
return new HtmlGenerator(htmlParser);
}
@@ -68,6 +71,7 @@
/**
* @see org.apache.sling.rewriter.Generator#finished()
*/
+ @Override
public void finished() throws IOException, SAXException {
this.htmlParser.parse(new ByteArrayInputStream(this.writer.toString().getBytes("UTF-8")), "UTF-8", this.contentHandler);
}
@@ -75,10 +79,12 @@
/**
* @see org.apache.sling.rewriter.Generator#getWriter()
*/
+ @Override
public PrintWriter getWriter() {
return new PrintWriter(writer);
}
+ @Override
public void init(ProcessingContext context,
ProcessingComponentConfiguration config)
throws IOException {
@@ -88,6 +94,7 @@
/**
* @see org.apache.sling.rewriter.Generator#setContentHandler(org.xml.sax.ContentHandler)
*/
+ @Override
public void setContentHandler(ContentHandler handler) {
this.contentHandler = handler;
}
@@ -95,6 +102,7 @@
/**
* @see org.apache.sling.rewriter.Generator#dispose()
*/
+ @Override
public void dispose() {
// nothing to do
}
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/HtmlSerializerFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/HtmlSerializerFactory.java
index b9c692c..1020007 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/HtmlSerializerFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/HtmlSerializerFactory.java
@@ -23,6 +23,7 @@
import org.apache.sling.rewriter.ProcessingContext;
import org.apache.sling.rewriter.Serializer;
import org.apache.sling.rewriter.SerializerFactory;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
/**
@@ -30,6 +31,7 @@
*/
@Component(service = SerializerFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=html-serializer"
})
public class HtmlSerializerFactory implements SerializerFactory {
@@ -37,6 +39,7 @@
/**
* @see org.apache.sling.rewriter.SerializerFactory#createSerializer()
*/
+ @Override
public Serializer createSerializer() {
return new HTMLSerializer();
}
@@ -74,6 +77,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#init(org.apache.sling.rewriter.ProcessingContext, org.apache.sling.rewriter.ProcessingComponentConfiguration)
*/
+ @Override
public void init(ProcessingContext context,
ProcessingComponentConfiguration config)
throws IOException {
@@ -94,6 +98,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#dispose()
*/
+ @Override
public void dispose() {
// nothing to do
}
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/TraxHtmlSerializerFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/TraxHtmlSerializerFactory.java
index 5ebd2dc..8609e01 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/TraxHtmlSerializerFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/TraxHtmlSerializerFactory.java
@@ -17,6 +17,7 @@
package org.apache.sling.rewriter.impl.components;
import org.apache.sling.rewriter.SerializerFactory;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
@@ -25,6 +26,7 @@
*/
@Component(service = SerializerFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=trax-html-serializer"
})
public class TraxHtmlSerializerFactory extends AbstractTraxSerializerFactory {
@@ -34,10 +36,12 @@
return "html";
}
+ @Override
protected String getDoctypePublic() {
return "-//W3C//DTD HTML 4.01 Transitional//EN";
}
+ @Override
protected String getDoctypeSystem() {
return "http://www.w3.org/TR/html4/loose.dtd";
}
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/TraxXHtmlSerializerFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/TraxXHtmlSerializerFactory.java
index a1b81f1..a32214b 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/TraxXHtmlSerializerFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/TraxXHtmlSerializerFactory.java
@@ -17,6 +17,7 @@
package org.apache.sling.rewriter.impl.components;
import org.apache.sling.rewriter.SerializerFactory;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
@@ -25,6 +26,7 @@
*/
@Component(service = SerializerFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=trax-xhtml-serializer"
})
public class TraxXHtmlSerializerFactory extends AbstractTraxSerializerFactory {
@@ -34,10 +36,12 @@
return "xhtml";
}
+ @Override
protected String getDoctypePublic() {
return "-//W3C//DTD XHTML 1.0 Strict//EN";
}
+ @Override
protected String getDoctypeSystem() {
return "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";
}
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/XHtmlSerializerFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/XHtmlSerializerFactory.java
index 194129f..761096a 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/XHtmlSerializerFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/XHtmlSerializerFactory.java
@@ -23,6 +23,7 @@
import org.apache.sling.rewriter.ProcessingContext;
import org.apache.sling.rewriter.Serializer;
import org.apache.sling.rewriter.SerializerFactory;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
/**
@@ -30,6 +31,7 @@
*/
@Component(service = SerializerFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=xhtml-serializer"
})
public class XHtmlSerializerFactory implements SerializerFactory {
@@ -37,6 +39,7 @@
/**
* @see org.apache.sling.rewriter.SerializerFactory#createSerializer()
*/
+ @Override
public Serializer createSerializer() {
return new XHTMLSerializer();
}
@@ -72,6 +75,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#init(org.apache.sling.rewriter.ProcessingContext, org.apache.sling.rewriter.ProcessingComponentConfiguration)
*/
+ @Override
public void init(ProcessingContext context,
ProcessingComponentConfiguration config)
throws IOException {
@@ -92,6 +96,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#dispose()
*/
+ @Override
public void dispose() {
// nothing to do
}
diff --git a/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java b/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
index 950bc21..2c99301 100644
--- a/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
+++ b/src/main/java/org/apache/sling/rewriter/impl/components/XMLSerializerFactory.java
@@ -23,6 +23,7 @@
import org.apache.sling.rewriter.ProcessingContext;
import org.apache.sling.rewriter.Serializer;
import org.apache.sling.rewriter.SerializerFactory;
+import org.osgi.framework.Constants;
import org.osgi.service.component.annotations.Component;
/**
@@ -30,6 +31,7 @@
*/
@Component(service = SerializerFactory.class,
property = {
+ Constants.SERVICE_VENDOR + "=The Apache Software Foundation",
"pipeline.type=xml-serializer"
})
public class XMLSerializerFactory implements SerializerFactory {
@@ -37,6 +39,7 @@
/**
* @see org.apache.sling.rewriter.SerializerFactory#createSerializer()
*/
+ @Override
public Serializer createSerializer() {
return new XMLSerializer();
}
@@ -48,6 +51,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#init(org.apache.sling.rewriter.ProcessingContext, org.apache.sling.rewriter.ProcessingComponentConfiguration)
*/
+ @Override
public void init(ProcessingContext context,
ProcessingComponentConfiguration config)
throws IOException {
@@ -66,6 +70,7 @@
/**
* @see org.apache.sling.rewriter.Serializer#dispose()
*/
+ @Override
public void dispose() {
// nothing to do
}
