commit 131afd005cbb98731b1cf7cf0f4571fda78c16a5
author Jörg Hoh <joerghoh@users.noreply.github.com> Tue Oct 11 11:08:00 2022 +0200
committer GitHub <noreply@github.com> Tue Oct 11 11:08:00 2022 +0200
tree a157690ed5ff3fc6566704b9d3920563f1fffc7b
parent c53fb4a2cf6e4bed1f8161efee83d85a5b3218f3

SLING-11614 avoid duplicate creation of child node iterator (#37)

src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java

diff --git a/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java b/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java
index dba7f67..9371aa5 100644
--- a/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java
+++ b/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java
@@ -25,6 +25,7 @@
 import javax.jcr.Item;
 import javax.jcr.ItemNotFoundException;
 import javax.jcr.Node;
+import javax.jcr.NodeIterator;
 import javax.jcr.Property;
 import javax.jcr.RepositoryException;
 
@@ -217,15 +218,13 @@
         return null;
     }
 
-
-    // ---------- Descendable interface ----------------------------------------
-
     @Override
     @Nullable Iterator<Resource> listJcrChildren() {
         try {
-            if (getNode().hasNodes()) {
+        	NodeIterator iter = getNode().getNodes();
+            if (iter.hasNext()) {
                 return new JcrNodeResourceIterator(getResourceResolver(), path, version,
-                        getNode().getNodes(), this.helper, null);
+                        iter, this.helper, null);
             }
         } catch (final RepositoryException re) {
             LOGGER.error("listChildren: Cannot get children of " + this, re);