Fixing some minor sonarqube issues and ignoring others
diff --git a/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerEventHandler.java b/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerEventHandler.java
index 2ad4e11..4d50277 100644
--- a/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerEventHandler.java
+++ b/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerEventHandler.java
@@ -49,9 +49,11 @@
@ObjectClassDefinition(name = "%event.handler.name", description = "%event.handler.description", localization = "OSGI-INF/l10n/bundle")
public @interface Config {
+ @SuppressWarnings("squid:S00100")
@AttributeDefinition(name = "%event.handler.filter.name", description = "%event.handler.filter.description")
String event_filter() default "(&(resourceType=sling:File)(|(path=*.png)(path=*.jpg)))";
+ @SuppressWarnings("squid:S00100")
@AttributeDefinition(name = "%event.handler.topics.name", description = "%event.handler.topics.description")
String[] event_topics() default { SlingConstants.TOPIC_RESOURCE_ADDED, SlingConstants.TOPIC_RESOURCE_CHANGED };
}
diff --git a/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerWebConsole.java b/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerWebConsole.java
index 81be914..f1cfff6 100644
--- a/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerWebConsole.java
+++ b/src/main/java/org/apache/sling/fileoptim/impl/FileOptimizerWebConsole.java
@@ -53,7 +53,7 @@
public static final String CONSOLE_TITLE = "File Optimizer";
@Reference
- private FileOptimizerService fileOptimizer;
+ private transient FileOptimizerService fileOptimizer;
@Override
public String getTitle() {
diff --git a/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerData.java b/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerData.java
index 23fc572..af72c37 100644
--- a/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerData.java
+++ b/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerData.java
@@ -39,11 +39,11 @@
"sling.servlet.methods=GET" })
public class FileOptimizerData extends SlingSafeMethodsServlet {
+ private static final long serialVersionUID = 3410212658357219464L;
+
@Reference
private transient FileOptimizerService fileOptimizer;
- private static final long serialVersionUID = 8635343288414416865L;
-
@Override
protected void doGet(SlingHttpServletRequest request, SlingHttpServletResponse response)
throws ServletException, IOException {
diff --git a/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerPreview.java b/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerPreview.java
index 7055dc0..90bdaf2 100644
--- a/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerPreview.java
+++ b/src/main/java/org/apache/sling/fileoptim/impl/servlets/FileOptimizerPreview.java
@@ -40,11 +40,11 @@
"sling.servlet.methods=GET" }, immediate = true)
public class FileOptimizerPreview extends SlingSafeMethodsServlet {
+ private static final long serialVersionUID = 8635343288414416865L;
+
@Reference
private transient FileOptimizerService fileOptimizer;
- private static final long serialVersionUID = 8635343288414416865L;
-
@Override
protected void doGet(SlingHttpServletRequest request, SlingHttpServletResponse response)
throws ServletException, IOException {
