Refactor bad smells: (#115)
- UnnecessaryToStringCall
The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.
diff --git a/src/main/java/org/apache/sling/distribution/journal/bookkeeper/LocalStore.java b/src/main/java/org/apache/sling/distribution/journal/bookkeeper/LocalStore.java
index c3c510a..db9500a 100644
--- a/src/main/java/org/apache/sling/distribution/journal/bookkeeper/LocalStore.java
+++ b/src/main/java/org/apache/sling/distribution/journal/bookkeeper/LocalStore.java
@@ -88,7 +88,7 @@
} else {
serviceResolver.create(parent, storeId, map);
}
- LOG.debug(String.format("Stored data %s for storeId %s", map.toString(), storeId));
+ LOG.debug(String.format("Stored data %s for storeId %s", map, storeId));
}
public <T> T load(String key, Class<T> clazz) {
