SLING-6589 - DistributionPackageUtils#disposable should handle hanging packages
git-svn-id: https://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/distribution/core@1785100 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java b/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java
index 3a0ffd2..c334d39 100644
--- a/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java
+++ b/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java
@@ -318,8 +318,16 @@
public static boolean disposable(@Nonnull Resource resource) throws RepositoryException {
Node parent = resource.adaptTo(Node.class);
- Node refs = parent.getNode("refs");
- return !refs.hasNodes() && refs.hasProperty("released");
+ if (parent.hasNode("refs")) {
+ Node refs = parent.getNode("refs");
+ return !refs.hasNodes() && refs.hasProperty("released");
+ } else {
+ // Packages without refs nodes are likely the result of the concurrency
+ // issue fixed in SLING-6503. Yet, we consider them non disposable.
+ log.warn("Package {} has no refs resource. Consider removing it explicitly.", resource.getPath());
+ return false;
+ }
+
}
public static void release(Resource resource, @Nonnull String[] holderNames) throws RepositoryException {
diff --git a/src/main/java/org/apache/sling/distribution/packaging/impl/ResourceDistributionPackageCleanup.java b/src/main/java/org/apache/sling/distribution/packaging/impl/ResourceDistributionPackageCleanup.java
index 58642d5..dd592de 100644
--- a/src/main/java/org/apache/sling/distribution/packaging/impl/ResourceDistributionPackageCleanup.java
+++ b/src/main/java/org/apache/sling/distribution/packaging/impl/ResourceDistributionPackageCleanup.java
@@ -61,12 +61,16 @@
for (Iterator<ResourceDistributionPackage> pkgs = packageBuilder.getPackages(serviceResolver) ; pkgs.hasNext() ; total++) {
ResourceDistributionPackage pkg = pkgs.next();
if (pkg.disposable()) {
- log.trace("Delete package {}", pkg.getId());
+ log.debug("Delete package {}", pkg.getId());
deleted++;
pkg.delete(false);
+ } else {
+ log.debug("package {} is not disposable", pkg.getId());
}
}
- serviceResolver.commit();
+ if (serviceResolver.hasChanges()) {
+ serviceResolver.commit();
+ }
log.debug("Cleaned up {}/{} {} packages",
new Object[]{deleted, total, packageBuilder.getType()});
} catch (LoginException e) {
