commit e041e99219f5441ceee10cea84a4addd764d685c
author Chetan Mehrotra <chetanm@apache.org> Fri Dec 01 16:21:30 2017 +0530
committer Chetan Mehrotra <chetanm@apache.org> Fri Dec 01 16:21:30 2017 +0530
tree 97c2a528ba0802c88ce6f7663dc5c467be4dea59
parent 182c55e3f253e81bb08a0b26fdfd9142dab27d61

SLING-6702 - Make MetricsService accessible as easily as a Logger

Add a note around handling rewiring of metric service later on

src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java

diff --git a/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java b/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
index 5d57ab9..6d5fd08 100644
--- a/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
+++ b/src/main/java/org/apache/sling/commons/metrics/internal/MetricsServiceImpl.java
@@ -61,6 +61,11 @@
 
     private JmxReporter reporter;
 
+    /*  WARNING: if any OSGi configuration parameters are added to this class
+     *  we’ll need to handle the service restart case to prevent service
+     *  references retrieved using MetricsServiceFactory from becoming
+     *  stale. See discussion in SLING-6702.
+     */
     @Activate
     private void activate(BundleContext context, Map<String, Object> config) {
         enableJMXReporter();