| commit | b3e7c1ecf93cf5d608f014bc702b4a7aceccbb6c | [log] [tgz] |
|---|---|---|
| author | liubao <bismy@qq.com> | Fri Jul 05 19:34:43 2019 +0800 |
| committer | bao liu <bismy@qq.com> | Mon Jul 08 15:35:43 2019 +0800 |
| tree | 538a7a901f86f367850b6e65c67a5c530ef8dec8 | |
| parent | bb5731ddb1ffcb534cda5f7ac9df215c04c05565 [diff] |
[SCB-1350]minor fix
diff --git a/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/GithubTokenGranter.java b/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/GithubTokenGranter.java index 4c372e6..2840840 100644 --- a/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/GithubTokenGranter.java +++ b/api/authentication-server/endpoint/src/main/java/org/apache/servicecomb/authentication/server/GithubTokenGranter.java
@@ -92,11 +92,15 @@ LOGGER.error("Call github error. ", e); } + if (response == null || StringUtils.isEmpty(response.getAccess_token())) { + return null; + } + if (StringUtils.isEmpty(login)) { login = "anonymous"; } try { - UserDetails userDetails = userDetailsService.loadUserByUsername("github:" + login); + UserDetails userDetails = userDetailsService.loadUserByUsername(name() + ":" + login); OpenIDToken openIDToken = openIDTokenStore.createToken(userDetails); openIDToken.addAdditionalInformation(AuthenticationServerConstants.TOKEN_ADDTIONAL_INFORMATION_GITHUB_TOKEN,