blob: 521f38211cf9da58dac5ab079a53c3ae23ceb74c [file] [log] [blame]
/* Copyright 2002-2007 Justin Erenkrantz and Greg Stein
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <apr.h>
#include <apr_pools.h>
#include <apr_strings.h>
#include "serf.h"
#include "test_serf.h"
/* test case has access to internal functions. */
#include "serf_private.h"
#include "serf_bucket_util.h"
static apr_status_t read_all(serf_bucket_t *bkt,
char *buf,
apr_size_t buf_len,
apr_size_t *read_len)
{
const char *data;
apr_size_t data_len;
apr_status_t status;
apr_size_t read;
read = 0;
do
{
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &data_len);
if (!SERF_BUCKET_READ_ERROR(status))
{
if (data_len > buf_len - read)
{
/* Buffer is not large enough to read all data */
data_len = buf_len - read;
status = SERF_ERROR_ISSUE_IN_TESTSUITE;
}
memcpy(buf + read, data, data_len);
read += data_len;
}
} while(status == APR_SUCCESS);
*read_len = read;
return status;
}
/* Reads bucket until EOF found and compares read data with zero terminated
string expected. Report all failures using CuTest. */
void read_and_check_bucket(CuTest *tc, serf_bucket_t *bkt,
const char *expected)
{
apr_status_t status;
do
{
const char *data;
apr_size_t len;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Got error during bucket reading.",
!SERF_BUCKET_READ_ERROR(status));
CuAssert(tc, "Read more data than expected.",
strlen(expected) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(expected, data, len) == 0);
expected += len;
} while(!APR_STATUS_IS_EOF(status));
CuAssert(tc, "Read less data than expected.", strlen(expected) == 0);
}
/* Reads bucket with serf_bucket_readline until EOF found and compares:
- actual line endings with expected line endings
- actual data with zero terminated string expected.
Reports all failures using CuTest. */
void readlines_and_check_bucket(CuTest *tc, serf_bucket_t *bkt,
int acceptable,
const char *expected,
int expected_nr_of_lines)
{
apr_status_t status;
int actual_nr_of_lines = 0;
do
{
const char *data;
apr_size_t len;
int found;
status = serf_bucket_readline(bkt, acceptable, &found,
&data, &len);
CuAssert(tc, "Got error during bucket reading.",
!SERF_BUCKET_READ_ERROR(status));
CuAssert(tc, "Read more data than expected.",
strlen(expected) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(expected, data, len) == 0);
expected += len;
if (found == SERF_NEWLINE_CRLF_SPLIT)
continue;
if (found != SERF_NEWLINE_NONE)
{
actual_nr_of_lines++;
CuAssert(tc, "Unexpected line ending type!",
found & acceptable);
if (found & SERF_NEWLINE_CR)
CuAssert(tc, "CR Line ending was reported but not in data!",
strncmp(data + len - 1, "\r", 1) == 0);
if (found & SERF_NEWLINE_LF)
CuAssert(tc, "LF Line ending was reported but not in data!",
strncmp(data + len - 1, "\n", 1) == 0);
if (found & SERF_NEWLINE_CRLF)
CuAssert(tc, "CRLF Line ending was reported but not in data!",
strncmp(data + len - 2, "\r\n", 2) == 0);
} else
{
if (status == APR_EOF && len)
actual_nr_of_lines++;
if (acceptable & SERF_NEWLINE_CR)
CuAssert(tc, "CR Line ending was not reported but in data!",
strncmp(data + len - 1, "\r", 1) != 0);
if (acceptable & SERF_NEWLINE_LF)
CuAssert(tc, "LF Line ending was not reported but in data!",
strncmp(data + len - 1, "\n", 1) != 0);
if (acceptable & SERF_NEWLINE_CRLF)
CuAssert(tc, "CRLF Line ending was not reported but in data!",
strncmp(data + len - 2, "\r\n", 2) != 0);
}
} while(!APR_STATUS_IS_EOF(status));
CuAssertIntEquals(tc, expected_nr_of_lines, actual_nr_of_lines);
CuAssert(tc, "Read less data than expected.", strlen(expected) == 0);
}
/******************************** TEST CASES **********************************/
static void test_simple_bucket_readline(CuTest *tc)
{
apr_status_t status;
serf_bucket_t *bkt;
const char *data;
int found;
apr_size_t len;
const char *body;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
bkt = SERF_BUCKET_SIMPLE_STRING(
"line1" CRLF
"line2",
alloc);
/* Initialize parameters to check that they will be initialized. */
len = 0x112233;
data = 0;
status = serf_bucket_readline(bkt, SERF_NEWLINE_CRLF, &found, &data, &len);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, SERF_NEWLINE_CRLF, found);
CuAssertIntEquals(tc, 7, len);
CuAssert(tc, data, strncmp("line1" CRLF, data, len) == 0);
/* Initialize parameters to check that they will be initialized. */
len = 0x112233;
data = 0;
status = serf_bucket_readline(bkt, SERF_NEWLINE_CRLF, &found, &data, &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, SERF_NEWLINE_NONE, found);
CuAssertIntEquals(tc, 5, len);
CuAssert(tc, data, strncmp("line2", data, len) == 0);
/* acceptable line types should be reported */
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CRLF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_CRLF, "line1" CRLF, 1);
bkt = SERF_BUCKET_SIMPLE_STRING("line1" LF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_LF, "line1" LF, 1);
bkt = SERF_BUCKET_SIMPLE_STRING("line1" LF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_LF, "line1" LF, 1);
/* special cases, but acceptable */
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CRLF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_CR, "line1" CRLF, 2);
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CRLF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_LF, "line1" CRLF, 1);
/* Unacceptable line types should not be reported */
bkt = SERF_BUCKET_SIMPLE_STRING("line1" LF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_CR, "line1" LF, 1);
bkt = SERF_BUCKET_SIMPLE_STRING("line1" LF, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_CRLF, "line1" LF, 1);
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CR, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_LF, "line1" CR, 1);
#if 0
/* TODO: looks like a bug, CRLF acceptable on buffer with CR returns
SERF_NEWLINE_CRLF_SPLIT, but here that CR comes at the end of the
buffer (APR_EOF), so should have been SERF_NEWLINE_NONE! */
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CR, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_CRLF, "line1" CR, 1);
#endif
body = "12345678901234567890" CRLF
"12345678901234567890" CRLF
"12345678901234567890" CRLF;
bkt = SERF_BUCKET_SIMPLE_STRING(body, alloc);
readlines_and_check_bucket(tc, bkt, SERF_NEWLINE_LF, body, 3);
}
static void test_response_bucket_read(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING(
"HTTP/1.1 200 OK" CRLF
"Content-Length: 7" CRLF
CRLF
"abc1234",
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
/* Read all bucket and check it content. */
read_and_check_bucket(tc, bkt, "abc1234");
}
static void test_response_bucket_headers(CuTest *tc)
{
serf_bucket_t *bkt, *tmp, *hdr;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING(
"HTTP/1.1 405 Method Not Allowed" CRLF
"Date: Sat, 12 Jun 2010 14:17:10 GMT" CRLF
"Server: Apache" CRLF
"Allow: " CRLF
"Content-Length: 7" CRLF
"Content-Type: text/html; charset=iso-8859-1" CRLF
"NoSpace:" CRLF
CRLF
"abc1234",
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
/* Read all bucket and check it content. */
read_and_check_bucket(tc, bkt, "abc1234");
hdr = serf_bucket_response_get_headers(bkt);
CuAssertStrEquals(tc,
"",
serf_bucket_headers_get(hdr, "Allow"));
CuAssertStrEquals(tc,
"7",
serf_bucket_headers_get(hdr, "Content-Length"));
CuAssertStrEquals(tc,
"",
serf_bucket_headers_get(hdr, "NoSpace"));
}
static void test_response_bucket_chunked_read(CuTest *tc)
{
serf_bucket_t *bkt, *tmp, *hdrs;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING(
"HTTP/1.1 200 OK" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF
"3" CRLF
"abc" CRLF
"4" CRLF
"1234" CRLF
"0" CRLF
"Footer: value" CRLF
CRLF,
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
/* Read all bucket and check it content. */
read_and_check_bucket(tc, bkt, "abc1234");
hdrs = serf_bucket_response_get_headers(bkt);
CuAssertTrue(tc, hdrs != NULL);
/* Check that trailing headers parsed correctly. */
CuAssertStrEquals(tc, "value", serf_bucket_headers_get(hdrs, "Footer"));
}
static void test_bucket_header_set(CuTest *tc)
{
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
serf_bucket_t *hdrs = serf_bucket_headers_create(alloc);
CuAssertTrue(tc, hdrs != NULL);
serf_bucket_headers_set(hdrs, "Foo", "bar");
CuAssertStrEquals(tc, "bar", serf_bucket_headers_get(hdrs, "Foo"));
serf_bucket_headers_set(hdrs, "Foo", "baz");
CuAssertStrEquals(tc, "bar,baz", serf_bucket_headers_get(hdrs, "Foo"));
serf_bucket_headers_set(hdrs, "Foo", "test");
CuAssertStrEquals(tc, "bar,baz,test", serf_bucket_headers_get(hdrs, "Foo"));
/* headers are case insensitive. */
CuAssertStrEquals(tc, "bar,baz,test", serf_bucket_headers_get(hdrs, "fOo"));
}
static void test_iovec_buckets(CuTest *tc)
{
apr_status_t status;
serf_bucket_t *bkt, *iobkt;
const char *data;
apr_size_t len;
struct iovec vecs[32];
struct iovec tgt_vecs[32];
int i;
int vecs_used;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
/* Test 1: Read a single string in an iovec, store it in a iovec_bucket
and then read it back. */
bkt = SERF_BUCKET_SIMPLE_STRING(
"line1" CRLF
"line2",
alloc);
status = serf_bucket_read_iovec(bkt, SERF_READ_ALL_AVAIL, 32, vecs,
&vecs_used);
iobkt = serf_bucket_iovec_create(vecs, vecs_used, alloc);
/* Check available data */
status = serf_bucket_peek(iobkt, &data, &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, strlen("line1" CRLF "line2"), len);
/* Try to read only a few bytes (less than what's in the first buffer). */
status = serf_bucket_read_iovec(iobkt, 3, 32, tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 1, vecs_used);
CuAssertIntEquals(tc, 3, tgt_vecs[0].iov_len);
CuAssert(tc, tgt_vecs[0].iov_base,
strncmp("lin", tgt_vecs[0].iov_base, tgt_vecs[0].iov_len) == 0);
/* Read the rest of the data. */
status = serf_bucket_read_iovec(iobkt, SERF_READ_ALL_AVAIL, 32, tgt_vecs,
&vecs_used);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 1, vecs_used);
CuAssertIntEquals(tc, strlen("e1" CRLF "line2"), tgt_vecs[0].iov_len);
CuAssert(tc, tgt_vecs[0].iov_base,
strncmp("e1" CRLF "line2", tgt_vecs[0].iov_base, tgt_vecs[0].iov_len - 3) == 0);
/* Bucket should now be empty */
status = serf_bucket_peek(iobkt, &data, &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 0, len);
/* Test 2: Read multiple character bufs in an iovec, then read them back
in bursts. */
for (i = 0; i < 32 ; i++) {
vecs[i].iov_base = apr_psprintf(test_pool, "data %02d 901234567890", i);
vecs[i].iov_len = strlen(vecs[i].iov_base);
}
iobkt = serf_bucket_iovec_create(vecs, 32, alloc);
/* Check that some data is in the buffer. Don't verify the actual data, the
amount of data returned is not guaranteed to be the full buffer. */
status = serf_bucket_peek(iobkt, &data, &len);
CuAssertTrue(tc, len > 0);
CuAssertIntEquals(tc, APR_SUCCESS, status); /* this assumes not all data is
returned at once,
not guaranteed! */
/* Read 1 buf. 20 = sizeof("data %2d 901234567890") */
status = serf_bucket_read_iovec(iobkt, 1 * 20, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 1, vecs_used);
CuAssert(tc, tgt_vecs[0].iov_base,
strncmp("data 00 901234567890", tgt_vecs[0].iov_base, tgt_vecs[0].iov_len) == 0);
/* Read 2 bufs. */
status = serf_bucket_read_iovec(iobkt, 2 * 20, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 2, vecs_used);
/* Read the remaining 29 bufs. */
vecs_used = 400; /* test if iovec code correctly resets vecs_used */
status = serf_bucket_read_iovec(iobkt, SERF_READ_ALL_AVAIL, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 29, vecs_used);
/* Test 3: use serf_bucket_read */
for (i = 0; i < 32 ; i++) {
vecs[i].iov_base = apr_psprintf(test_pool, "DATA %02d 901234567890", i);
vecs[i].iov_len = strlen(vecs[i].iov_base);
}
iobkt = serf_bucket_iovec_create(vecs, 32, alloc);
status = serf_bucket_read(iobkt, 10, &data, &len);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 10, len);
CuAssert(tc, data,
strncmp("DATA 00 90", data, len) == 0);
status = serf_bucket_read(iobkt, 10, &data, &len);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 10, len);
CuAssert(tc, tgt_vecs[0].iov_base,
strncmp("1234567890", data, len) == 0);
for (i = 1; i < 31 ; i++) {
const char *exp = apr_psprintf(test_pool, "DATA %02d 901234567890", i);
status = serf_bucket_read(iobkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 20, len);
CuAssert(tc, data,
strncmp(exp, data, len) == 0);
}
status = serf_bucket_read(iobkt, 20, &data, &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 20, len);
CuAssert(tc, data,
strncmp("DATA 31 901234567890", data, len) == 0);
/* Test 3: read an empty iovec */
iobkt = serf_bucket_iovec_create(vecs, 0, alloc);
status = serf_bucket_read_iovec(iobkt, SERF_READ_ALL_AVAIL, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 0, vecs_used);
status = serf_bucket_read(iobkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 0, len);
/* Test 4: read 0 bytes from an iovec */
bkt = SERF_BUCKET_SIMPLE_STRING("line1" CRLF, alloc);
status = serf_bucket_read_iovec(bkt, SERF_READ_ALL_AVAIL, 32, vecs,
&vecs_used);
iobkt = serf_bucket_iovec_create(vecs, vecs_used, alloc);
status = serf_bucket_read_iovec(iobkt, 0, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 0, vecs_used);
}
/* Construct a header bucket with some headers, and then read from it. */
static void test_header_buckets(CuTest *tc)
{
apr_status_t status;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
const char *cur;
serf_bucket_t *hdrs = serf_bucket_headers_create(alloc);
CuAssertTrue(tc, hdrs != NULL);
serf_bucket_headers_set(hdrs, "Content-Type", "text/plain");
serf_bucket_headers_set(hdrs, "Content-Length", "100");
/* Note: order not guaranteed, assume here that it's fifo. */
cur = "Content-Type: text/plain" CRLF
"Content-Length: 100" CRLF
CRLF
CRLF;
while (1) {
const char *data;
apr_size_t len;
status = serf_bucket_read(hdrs, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Unexpected error when waiting for response headers",
!SERF_BUCKET_READ_ERROR(status));
if (SERF_BUCKET_READ_ERROR(status) ||
APR_STATUS_IS_EOF(status))
break;
/* Check that the bytes read match with expected at current position. */
CuAssertStrnEquals(tc, cur, len, data);
cur += len;
}
CuAssertIntEquals(tc, APR_EOF, status);
}
static void test_aggregate_buckets(CuTest *tc)
{
apr_status_t status;
serf_bucket_t *bkt, *aggbkt;
struct iovec tgt_vecs[32];
int vecs_used;
apr_size_t len;
const char *data;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
const char *BODY = "12345678901234567890"\
"12345678901234567890"\
"12345678901234567890"\
CRLF;
/* Test 1: read 0 bytes from an aggregate */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING(BODY, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
status = serf_bucket_read_iovec(aggbkt, 0, 32,
tgt_vecs, &vecs_used);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssertIntEquals(tc, 0, vecs_used);
/* Test 2: peek the available bytes, should be non-0 */
len = SERF_READ_ALL_AVAIL;
status = serf_bucket_peek(aggbkt, &data, &len);
/* status should be either APR_SUCCESS or APR_EOF */
if (status == APR_SUCCESS)
CuAssertTrue(tc, len > 0 && len < strlen(BODY));
else if (status == APR_EOF)
CuAssertIntEquals(tc, strlen(BODY), len);
else
CuAssertIntEquals(tc, APR_SUCCESS, status);
/* Test 3: read the data from the bucket. */
read_and_check_bucket(tc, aggbkt, BODY);
/* Test 4: multiple child buckets appended. */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 15, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+15, strlen(BODY)-15, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
read_and_check_bucket(tc, aggbkt, BODY);
/* Test 5: multiple child buckets prepended. */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+15, strlen(BODY)-15, alloc);
serf_bucket_aggregate_prepend(aggbkt, bkt);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 15, alloc);
serf_bucket_aggregate_prepend(aggbkt, bkt);
read_and_check_bucket(tc, aggbkt, BODY);
/* Test 6: ensure peek doesn't return APR_EAGAIN, or APR_EOF incorrectly. */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 15, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+15, strlen(BODY)-15, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
len = 1234;
status = serf_bucket_peek(aggbkt, &data, &len);
CuAssertIntEquals(tc, APR_SUCCESS, status);
CuAssert(tc, "Length should be positive.",
len > 0 && len <= strlen(BODY) );
CuAssert(tc, "Data should match first part of body.",
strncmp(BODY, data, len) == 0);
}
static void test_aggregate_bucket_readline(CuTest *tc)
{
serf_bucket_t *bkt, *aggbkt;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
const char *BODY = "12345678901234567890" CRLF
"12345678901234567890" CRLF
"12345678901234567890" CRLF;
/* Test 1: read lines from an aggregate bucket */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 22, alloc);
serf_bucket_aggregate_append(aggbkt, bkt); /* 1st line */
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+22, strlen(BODY)-22, alloc);
serf_bucket_aggregate_append(aggbkt, bkt); /* 2nd and 3rd line */
bkt = SERF_BUCKET_SIMPLE_STRING(BODY, alloc);
readlines_and_check_bucket(tc, aggbkt, SERF_NEWLINE_CRLF, BODY, 3);
/* Test 2: start with empty bucket */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN("", 0, alloc);
serf_bucket_aggregate_append(aggbkt, bkt); /* empty bucket */
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 22, alloc);
serf_bucket_aggregate_append(aggbkt, bkt); /* 1st line */
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+22, strlen(BODY)-22, alloc);
serf_bucket_aggregate_append(aggbkt, bkt); /* 2nd and 3rd line */
bkt = SERF_BUCKET_SIMPLE_STRING(BODY, alloc);
readlines_and_check_bucket(tc, aggbkt, SERF_NEWLINE_CRLF, BODY, 3);
}
/* Test for issue: the server aborts the connection in the middle of
streaming the body of the response, where the length was set with the
Content-Length header. Test that we get a decent error code from the
response bucket instead of APR_EOF. */
static void test_response_body_too_small_cl(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
/* Make a response of 60 bytes, but set the Content-Length to 100. */
#define BODY "12345678901234567890"\
"12345678901234567890"\
"12345678901234567890"
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Content-Length: 100" CRLF
CRLF
BODY,
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
{
const char *data;
apr_size_t len;
apr_status_t status;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Read more data than expected.",
strlen(BODY) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(BODY, data, len) == 0);
CuAssert(tc, "Error expected due to response body too short!",
SERF_BUCKET_READ_ERROR(status));
CuAssertIntEquals(tc, SERF_ERROR_TRUNCATED_HTTP_RESPONSE, status);
}
}
#undef BODY
/* Test for issue: the server aborts the connection in the middle of
streaming the body of the response, using chunked encoding. Test that we get
a decent error code from the response bucket instead of APR_EOF. */
static void test_response_body_too_small_chunked(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
/* Make a response of 60 bytes, but set the chunk size to 60 and don't end
with chunk of length 0. */
#define BODY "12345678901234567890"\
"12345678901234567890"\
"12345678901234567890"
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF
"64" CRLF BODY,
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
{
const char *data;
apr_size_t len;
apr_status_t status;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Read more data than expected.",
strlen(BODY) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(BODY, data, len) == 0);
CuAssert(tc, "Error expected due to response body too short!",
SERF_BUCKET_READ_ERROR(status));
CuAssertIntEquals(tc, SERF_ERROR_TRUNCATED_HTTP_RESPONSE, status);
}
}
#undef BODY
/* Test for issue: the server aborts the connection in the middle of
streaming trailing CRLF after body chunk. Test that we get
a decent error code from the response bucket instead of APR_EOF. */
static void test_response_body_chunked_no_crlf(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF
"2" CRLF
"AB",
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
{
char buf[1024];
apr_size_t len;
apr_status_t status;
status = read_all(bkt, buf, sizeof(buf), &len);
CuAssertIntEquals(tc, SERF_ERROR_TRUNCATED_HTTP_RESPONSE, status);
}
}
/* Test for issue: the server aborts the connection in the middle of
streaming trailing CRLF after body chunk. Test that we get
a decent error code from the response bucket instead of APR_EOF. */
static void test_response_body_chunked_incomplete_crlf(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF
"2" CRLF
"AB"
"\r",
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
{
char buf[1024];
apr_size_t len;
apr_status_t status;
status = read_all(bkt, buf, sizeof(buf), &len);
CuAssertIntEquals(tc, SERF_ERROR_TRUNCATED_HTTP_RESPONSE, status);
}
}
static void test_response_body_chunked_gzip_small(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Transfer-Encoding: chunked" CRLF
"Content-Encoding: gzip" CRLF
CRLF
"2" CRLF
"A",
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
{
char buf[1024];
apr_size_t len;
apr_status_t status;
status = read_all(bkt, buf, sizeof(buf), &len);
CuAssertIntEquals(tc, SERF_ERROR_TRUNCATED_HTTP_RESPONSE, status);
}
}
static void test_response_bucket_peek_at_headers(CuTest *tc)
{
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_t *resp_bkt1, *tmp, *hdrs;
serf_status_line sl;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
const char *hdr_val, *cur;
apr_status_t status;
#define EXP_RESPONSE "HTTP/1.1 200 OK" CRLF\
"Content-Type: text/plain" CRLF\
"Content-Length: 100" CRLF\
CRLF\
"12345678901234567890"\
"12345678901234567890"\
"12345678901234567890"
tmp = SERF_BUCKET_SIMPLE_STRING(EXP_RESPONSE,
alloc);
resp_bkt1 = serf_bucket_response_create(tmp, alloc);
status = serf_bucket_response_status(resp_bkt1, &sl);
CuAssertIntEquals(tc, 200, sl.code);
CuAssertStrEquals(tc, "OK", sl.reason);
CuAssertIntEquals(tc, SERF_HTTP_11, sl.version);
/* Ensure that the status line & headers are read in the response_bucket. */
status = serf_bucket_response_wait_for_headers(resp_bkt1);
CuAssert(tc, "Unexpected error when waiting for response headers",
!SERF_BUCKET_READ_ERROR(status));
hdrs = serf_bucket_response_get_headers(resp_bkt1);
CuAssertPtrNotNull(tc, hdrs);
hdr_val = serf_bucket_headers_get(hdrs, "Content-Type");
CuAssertStrEquals(tc, "text/plain", hdr_val);
hdr_val = serf_bucket_headers_get(hdrs, "Content-Length");
CuAssertStrEquals(tc, "100", hdr_val);
/* Create a new bucket for the response which still has the original
status line & headers. */
status = serf_response_full_become_aggregate(resp_bkt1);
CuAssertIntEquals(tc, APR_SUCCESS, status);
cur = EXP_RESPONSE;
while (1) {
const char *data;
apr_size_t len;
apr_status_t status;
status = serf_bucket_read(resp_bkt1, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Unexpected error when waiting for response headers",
!SERF_BUCKET_READ_ERROR(status));
if (SERF_BUCKET_READ_ERROR(status) ||
APR_STATUS_IS_EOF(status))
break;
/* Check that the bytes read match with expected at current position. */
CuAssertStrnEquals(tc, cur, len, data);
cur += len;
}
}
#undef EXP_RESPONSE
/* ### this test is useful, but needs to switch to the new COPY bucket
### to test the behavior. */
#if 0
/* Test that the internal function serf_default_read_iovec, used by many
bucket types, groups multiple buffers in one iovec. */
static void test_serf_default_read_iovec(CuTest *tc)
{
apr_status_t status;
serf_bucket_t *bkt, *aggbkt;
struct iovec tgt_vecs[32];
int vecs_used, i;
apr_size_t actual_len = 0;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
const char *BODY = "12345678901234567890"\
"12345678901234567890"\
"12345678901234567890"\
CRLF;
/* Test 1: multiple children, should be read in one iovec. */
aggbkt = serf_bucket_aggregate_create(alloc);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY, 20, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+20, 20, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
bkt = SERF_BUCKET_SIMPLE_STRING_LEN(BODY+40, strlen(BODY)-40, alloc);
serf_bucket_aggregate_append(aggbkt, bkt);
status = serf_default_read_iovec(aggbkt, SERF_READ_ALL_AVAIL, 32, tgt_vecs,
&vecs_used);
CuAssertIntEquals(tc, APR_EOF, status);
for (i = 0; i < vecs_used; i++)
actual_len += tgt_vecs[i].iov_len;
CuAssertIntEquals(tc, strlen(BODY), actual_len);
}
#endif
/* Test that serf doesn't hang in an endless loop when a linebuf is in
split-CRLF state. */
static void test_linebuf_crlf_split(CuTest *tc)
{
serf_bucket_t *mock_bkt, *bkt;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
mockbkt_action actions[]= {
{ 1, "HTTP/1.1 200 OK" CRLF, APR_SUCCESS },
{ 1, "Content-Type: text/plain" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF, APR_SUCCESS },
{ 1, "6" CR, APR_SUCCESS },
{ 1, "", APR_EAGAIN },
{ 1, LF "blabla" CRLF CRLF, APR_SUCCESS }, };
apr_status_t status;
const char *expected = "blabla";
mock_bkt = serf_bucket_mock_create(actions, 5, alloc);
bkt = serf_bucket_response_create(mock_bkt, alloc);
do
{
const char *data;
apr_size_t len;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Got error during bucket reading.",
!SERF_BUCKET_READ_ERROR(status));
CuAssert(tc, "Read more data than expected.",
strlen(expected) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(expected, data, len) == 0);
expected += len;
if (len == 0 && status == APR_EAGAIN)
serf_bucket_mock_more_data_arrived(mock_bkt);
} while(!APR_STATUS_IS_EOF(status));
CuAssert(tc, "Read less data than expected.", strlen(expected) == 0);
}
/* Test that serf can handle lines that don't arrive completely in one go.
It doesn't really run random, it tries inserting APR_EAGAIN in all possible
places in the response message, only one currently. */
static void test_random_eagain_in_response(CuTest *tc)
{
apr_pool_t *test_pool = tc->testBaton;
apr_pool_t *iter_pool;
#define BODY "12345678901234567890123456789012345678901234567890"\
"12345678901234567890123456789012345678901234567890"
const char *expected = apr_psprintf(test_pool, "%s%s", BODY, BODY);
const char *fullmsg = "HTTP/1.1 200 OK" CRLF
"Date: Fri, 12 Jul 2013 15:13:52 GMT" CRLF
"Server: Apache/2.2.17 (Unix) mod_ssl/2.2.17 OpenSSL/1.0.1e DAV/2 "
"mod_wsgi/3.4 Python/2.7.3 SVN/1.7.10" CRLF
"DAV: 1,2" CRLF
"DAV: version-control,checkout,working-resource" CRLF
"DAV: merge,baseline,activity,version-controlled-collection" CRLF
"DAV: http://subversion.tigris.org/xmlns/dav/svn/depth" CRLF
"DAV: http://subversion.tigris.org/xmlns/dav/svn/log-revprops" CRLF
"DAV: http://subversion.tigris.org/xmlns/dav/svn/atomic-revprops" CRLF
"DAV: http://subversion.tigris.org/xmlns/dav/svn/partial-replay" CRLF
"DAV: http://subversion.tigris.org/xmlns/dav/svn/mergeinfo" CRLF
"DAV: <http://apache.org/dav/propset/fs/1>" CRLF
"MS-Author-Via: DAV" CRLF
"Allow: OPTIONS,GET,HEAD,POST,DELETE,TRACE,PROPFIND,PROPPATCH,COPY,MOVE,"
"LOCK,UNLOCK,CHECKOUT" CRLF
"SVN-Youngest-Rev: 1502584" CRLF
"SVN-Repository-UUID: 13f79535-47bb-0310-9956-ffa450edef68" CRLF
"SVN-Repository-Root: /repos/asf" CRLF
"SVN-Me-Resource: /repos/asf/!svn/me" CRLF
"SVN-Rev-Root-Stub: /repos/asf/!svn/rvr" CRLF
"SVN-Rev-Stub: /repos/asf/!svn/rev" CRLF
"SVN-Txn-Root-Stub: /repos/asf/!svn/txr" CRLF
"SVN-Txn-Stub: /repos/asf/!svn/txn" CRLF
"SVN-VTxn-Root-Stub: /repos/asf/!svn/vtxr" CRLF
"SVN-VTxn-Stub: /repos/asf/!svn/vtxn" CRLF
"Vary: Accept-Encoding" CRLF
"Content-Type: text/plain" CRLF
"Content-Type: text/xml; charset=\"utf-8\"" CRLF
"Transfer-Encoding: chunked" CRLF
CRLF
"64" CRLF
BODY CRLF
"64" CRLF
BODY CRLF
"0" CRLF
CRLF;
const long nr_of_tests = strlen(fullmsg);
long i;
mockbkt_action actions[]= {
{ 1, NULL, APR_EAGAIN },
{ 1, NULL, APR_EAGAIN },
};
apr_pool_create(&iter_pool, test_pool);
for (i = 0; i < nr_of_tests; i++) {
serf_bucket_t *mock_bkt, *bkt;
serf_bucket_alloc_t *alloc;
const char *ptr = expected;
const char *part1, *part2;
apr_size_t cut;
apr_status_t status;
apr_pool_clear(iter_pool);
alloc = serf_bucket_allocator_create(iter_pool, NULL, NULL);
cut = i % strlen(fullmsg);
part1 = apr_pstrndup(iter_pool, fullmsg, cut);
part2 = apr_pstrdup(iter_pool, fullmsg + cut);
actions[0].data = part1;
actions[1].data = part2;
mock_bkt = serf_bucket_mock_create(actions, 2, alloc);
bkt = serf_bucket_response_create(mock_bkt, alloc);
do
{
const char *data, *errmsg;
apr_size_t len;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Got error during bucket reading.",
!SERF_BUCKET_READ_ERROR(status));
errmsg = apr_psprintf(iter_pool,
"Read more data than expected, EAGAIN"
" inserted at pos: %d, remainder: \"%s\"",
cut, fullmsg + cut);
CuAssert(tc, errmsg, strlen(ptr) >= len);
errmsg = apr_psprintf(iter_pool,
"Read data is not equal to expected, EAGAIN"
" inserted at pos: %d, remainder: \"%s\"",
cut, fullmsg + cut);
CuAssertStrnEquals_Msg(tc, errmsg, ptr, len, data);
ptr += len;
if (len == 0 && status == APR_EAGAIN)
serf_bucket_mock_more_data_arrived(mock_bkt);
} while(!APR_STATUS_IS_EOF(status));
CuAssert(tc, "Read less data than expected.", strlen(ptr) == 0);
}
apr_pool_destroy(iter_pool);
}
static void test_dechunk_buckets(CuTest *tc)
{
serf_bucket_t *mock_bkt, *bkt;
apr_pool_t *test_pool = tc->testBaton;
serf_bucket_alloc_t *alloc = serf_bucket_allocator_create(test_pool, NULL,
NULL);
mockbkt_action actions[]= {
/* one chunk */
{ 1, "6" CRLF "blabla" CRLF, APR_SUCCESS },
/* EAGAIN after first chunk */
{ 1, "6" CRLF "blabla" CRLF, APR_EAGAIN },
{ 1, "6" CRLF "blabla" CRLF, APR_SUCCESS },
/* CRLF after body split */
{ 1, "6" CRLF "blabla" CR, APR_EAGAIN },
{ 1, LF, APR_SUCCESS },
/* CRLF before body split */
{ 1, "6" CR, APR_SUCCESS },
{ 1, "", APR_EAGAIN },
{ 1, LF "blabla" CRLF, APR_SUCCESS },
/* empty chunk */
{ 1, "", APR_SUCCESS },
/* two chunks */
{ 1, "6" CRLF "blabla" CRLF "6" CRLF "blabla" CRLF, APR_SUCCESS },
/* three chunks */
{ 1, "6" CRLF "blabla" CRLF "6" CRLF "blabla" CRLF
"0" CRLF "" CRLF, APR_SUCCESS },
};
const int nr_of_actions = sizeof(actions) / sizeof(mockbkt_action);
apr_status_t status;
const char *body = "blabla";
const char *expected = apr_psprintf(test_pool, "%s%s%s%s%s%s%s%s%s", body,
body, body, body, body, body, body,
body, body);
mock_bkt = serf_bucket_mock_create(actions, nr_of_actions, alloc);
bkt = serf_bucket_dechunk_create(mock_bkt, alloc);
do
{
const char *data;
apr_size_t len;
status = serf_bucket_read(bkt, SERF_READ_ALL_AVAIL, &data, &len);
CuAssert(tc, "Got error during bucket reading.",
!SERF_BUCKET_READ_ERROR(status));
CuAssert(tc, "Read more data than expected.",
strlen(expected) >= len);
CuAssert(tc, "Read data is not equal to expected.",
strncmp(expected, data, len) == 0);
expected += len;
if (len == 0 && status == APR_EAGAIN)
serf_bucket_mock_more_data_arrived(mock_bkt);
} while(!APR_STATUS_IS_EOF(status));
CuAssert(tc, "Read less data than expected.", strlen(expected) == 0);
}
/* Test that the Content-Length header will be ignored when the response
should not have returned a body. See RFC2616, section 4.4, nbr. 1. */
static void test_response_no_body_expected(CuTest *tc)
{
serf_bucket_t *bkt, *tmp;
apr_pool_t *test_pool = tc->testBaton;
char buf[1024];
apr_size_t len;
serf_bucket_alloc_t *alloc;
int i;
apr_status_t status;
/* response bucket should consider the blablablablabla as start of the
next response, in all these cases it should APR_EOF after the empty
line. */
test_server_message_t message_list[] = {
{ "HTTP/1.1 100 Continue" CRLF
"Content-Type: text/plain" CRLF
"Content-Length: 6500000" CRLF
CRLF
"blablablablabla" CRLF },
{ "HTTP/1.1 204 No Content" CRLF
"Content-Type: text/plain" CRLF
"Content-Length: 6500000" CRLF
CRLF
"blablablablabla" CRLF },
{ "HTTP/1.1 304 Not Modified" CRLF
"Content-Type: text/plain" CRLF
"Content-Length: 6500000" CRLF
CRLF
"blablablablabla" CRLF },
};
alloc = serf_bucket_allocator_create(test_pool, NULL, NULL);
/* Test 1: a response to a HEAD request. */
tmp = SERF_BUCKET_SIMPLE_STRING("HTTP/1.1 200 OK" CRLF
"Content-Type: text/plain" CRLF
"Content-Length: 6500000" CRLF
CRLF
"blablablablabla" CRLF,
alloc);
bkt = serf_bucket_response_create(tmp, alloc);
serf_bucket_response_set_head(bkt);
status = read_all(bkt, buf, sizeof(buf), &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 0, len);
/* Test 2: a response with status for which server must not send a body. */
for (i = 0; i < sizeof(message_list) / sizeof(test_server_message_t); i++) {
tmp = SERF_BUCKET_SIMPLE_STRING(message_list[i].text, alloc);
bkt = serf_bucket_response_create(tmp, alloc);
status = read_all(bkt, buf, sizeof(buf), &len);
CuAssertIntEquals(tc, APR_EOF, status);
CuAssertIntEquals(tc, 0, len);
}
}
CuSuite *test_buckets(void)
{
CuSuite *suite = CuSuiteNew();
CuSuiteSetSetupTeardownCallbacks(suite, test_setup, test_teardown);
SUITE_ADD_TEST(suite, test_simple_bucket_readline);
SUITE_ADD_TEST(suite, test_response_bucket_read);
SUITE_ADD_TEST(suite, test_response_bucket_headers);
SUITE_ADD_TEST(suite, test_response_bucket_chunked_read);
SUITE_ADD_TEST(suite, test_response_body_too_small_cl);
SUITE_ADD_TEST(suite, test_response_body_too_small_chunked);
SUITE_ADD_TEST(suite, test_response_body_chunked_no_crlf);
SUITE_ADD_TEST(suite, test_response_body_chunked_incomplete_crlf);
SUITE_ADD_TEST(suite, test_response_body_chunked_gzip_small);
SUITE_ADD_TEST(suite, test_response_bucket_peek_at_headers);
SUITE_ADD_TEST(suite, test_bucket_header_set);
SUITE_ADD_TEST(suite, test_iovec_buckets);
SUITE_ADD_TEST(suite, test_aggregate_buckets);
SUITE_ADD_TEST(suite, test_aggregate_bucket_readline);
SUITE_ADD_TEST(suite, test_header_buckets);
SUITE_ADD_TEST(suite, test_linebuf_crlf_split);
SUITE_ADD_TEST(suite, test_random_eagain_in_response);
SUITE_ADD_TEST(suite, test_dechunk_buckets);
SUITE_ADD_TEST(suite, test_response_no_body_expected);
#if 0
SUITE_ADD_TEST(suite, test_serf_default_read_iovec);
#endif
return suite;
}