commit 060fe2efe674873a713f5640376a967c780ddd6f
author Branko Čibej <brane@apache.org> Thu Dec 15 08:32:47 2016 +0000
committer Branko Čibej <brane@apache.org> Thu Dec 15 08:32:47 2016 +0000
tree a1179fedda84e987dd1720df7bdda122fb9065a2
parent 3d31e2b32d6e844343e09c1078573dee91e7c3c1

On the ocsp-verification branch: Use the new certificate cleanup function.

* buckets/ssl_buckets.c
  (serf_ssl_cert_import): Don't leak SSL certificates.


git-svn-id: https://svn.apache.org/repos/asf/serf/branches/ocsp-verification@1774387 13f79535-47bb-0310-9956-ffa450edef68

buckets/ssl_buckets.c

diff --git a/buckets/ssl_buckets.c b/buckets/ssl_buckets.c
index cd2b0b2..fecb23a 100644
--- a/buckets/ssl_buckets.c
+++ b/buckets/ssl_buckets.c
@@ -2426,9 +2426,12 @@
         return NULL;
     }
 
-    /* TODO: Setup pool cleanup to free certificate */
     cert = apr_palloc(result_pool, sizeof(serf_ssl_certificate_t));
     cert->ssl_cert = ssl_cert;
+
+    apr_pool_cleanup_register(result_pool, ssl_cert, free_ssl_cert,
+                              apr_pool_cleanup_null);
+
     return cert;
 }