commit 126ab81ba33bb3d2fa3444c541aa51aa55e3b23b
author Colm O hEigeartaigh <coheigea@apache.org> Mon Oct 16 10:21:37 2017 +0000
committer Colm O hEigeartaigh <coheigea@apache.org> Mon Oct 16 10:21:37 2017 +0000
tree 4dbb6d78c1ccdfb16c6cd21ac40d2c13e170bae1
parent 1f34336271a30ccb98e375a4fdde6747c5078ad3

Integrating ErrorProne into build

git-svn-id: https://svn.apache.org/repos/asf/santuario/xml-security-java/trunk@1812273 13f79535-47bb-0310-9956-ffa450edef68

pom.xml

diff --git a/pom.xml b/pom.xml
index 2566b55..eaf86d5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -157,7 +157,23 @@
                 <configuration>
                     <source>${targetJdk}</source>
                     <target>${targetJdk}</target>
+                    <compilerId>javac-with-errorprone</compilerId>
+                    <forceJavacCompilerUse>true</forceJavacCompilerUse>
                 </configuration>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.codehaus.plexus</groupId>
+                        <artifactId>plexus-compiler-javac-errorprone</artifactId>
+                        <version>2.8</version>
+                    </dependency>
+                    <!-- override plexus-compiler-javac-errorprone's dependency on
+                         Error Prone with the latest version -->
+                    <dependency>
+                        <groupId>com.google.errorprone</groupId>
+                        <artifactId>error_prone_core</artifactId>
+                        <version>2.1.1</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             
             <plugin>

src/test/java/javax/xml/crypto/test/dsig/SecureXSLTTest.java

diff --git a/src/test/java/javax/xml/crypto/test/dsig/SecureXSLTTest.java b/src/test/java/javax/xml/crypto/test/dsig/SecureXSLTTest.java
index 553d887..4368caf 100644
--- a/src/test/java/javax/xml/crypto/test/dsig/SecureXSLTTest.java
+++ b/src/test/java/javax/xml/crypto/test/dsig/SecureXSLTTest.java
@@ -50,6 +50,7 @@
         testSignature(new File(baseDir, "signature1.xml"));
     }
 
+    @org.junit.Test
     public void testSignature2() throws Exception {
 
         String fs = System.getProperty("file.separator");
@@ -61,6 +62,7 @@
         testSignature(new File(baseDir, "signature2.xml"));
     }
 
+    @org.junit.Test
     public void testSignature3() throws Exception {
 
         String fs = System.getProperty("file.separator");

src/test/java/org/apache/xml/security/test/dom/utils/DocumentBuilderPoolingTest.java

diff --git a/src/test/java/org/apache/xml/security/test/dom/utils/DocumentBuilderPoolingTest.java b/src/test/java/org/apache/xml/security/test/dom/utils/DocumentBuilderPoolingTest.java
index b276aec..05add92 100644
--- a/src/test/java/org/apache/xml/security/test/dom/utils/DocumentBuilderPoolingTest.java
+++ b/src/test/java/org/apache/xml/security/test/dom/utils/DocumentBuilderPoolingTest.java
@@ -39,7 +39,6 @@
     public void testEquals() throws Exception {
         DocumentBuilder documentBuilder = XMLUtils.createDocumentBuilder(true);
         assertEquals(documentBuilder, documentBuilder);
-        assertSame(documentBuilder, documentBuilder);
     }
 
     @Test

src/test/java/org/apache/xml/security/test/stax/c14n/Canonicalizer11Test.java

diff --git a/src/test/java/org/apache/xml/security/test/stax/c14n/Canonicalizer11Test.java b/src/test/java/org/apache/xml/security/test/stax/c14n/Canonicalizer11Test.java
index a93f357..28f5522 100644
--- a/src/test/java/org/apache/xml/security/test/stax/c14n/Canonicalizer11Test.java
+++ b/src/test/java/org/apache/xml/security/test/stax/c14n/Canonicalizer11Test.java
@@ -214,7 +214,8 @@
      *
      * @see <A HREF="http://www.w3.org/TR/2007/CR-xml-c14n11-20070621/#Example-DocSubsetsXMLAttrs">the example from the spec</A>
      */
-    // @Test
+    @Test
+    @org.junit.Ignore
     public void test38() throws Exception {
 
         ByteArrayOutputStream baos = new ByteArrayOutputStream();