23e64f0e7297d9267cbd9b2d4d37fb60c6582552 - royale-compiler

commit	23e64f0e7297d9267cbd9b2d4d37fb60c6582552	[log] [tgz]
author	Josh Tynjala <joshtynjala@apache.org>	Tue Jan 05 10:50:56 2021 -0800
committer	Josh Tynjala <joshtynjala@apache.org>	Tue Jan 05 10:50:56 2021 -0800
tree	24fd47114dfb605a5c7dca154494cccded8b35b2
parent	cefb26b7bd814edc259aaba51477279f17343a15 [diff]

AccessorEmitter: similar to static accessors, instance accessors are written as a variable first

As with statics, this is because Closure compiler doesn't know how to properly analyze defineProperties() calls and assumes that getters/setters have no side effects. Declaring them as a variable first ensures that Closure understands that changes are possible.

This will eventually allow accessors to be safely renamed with advanced optimizations enabled.

compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/AccessorEmitter.java[diff]
compiler-jx/src/test/java/org/apache/royale/compiler/internal/codegen/js/royale/TestRoyaleAccessorMembers.java[diff]
compiler-jx/src/test/java/org/apache/royale/compiler/internal/codegen/js/royale/TestRoyaleAccessors.java[diff]
compiler-jx/src/test/java/org/apache/royale/compiler/internal/codegen/js/royale/TestRoyaleClass.java[diff]
compiler-jx/src/test/java/org/apache/royale/compiler/internal/codegen/js/royale/TestRoyaleExpressions.java[diff]
compiler-jx/src/test/java/org/apache/royale/compiler/internal/codegen/js/royale/TestRoyalePackage.java[diff]
compiler-jx/src/test/resources/royale/files/MyInitialView_result.js[diff]
compiler-jx/src/test/resources/royale/files/models/MyModel_result.js[diff]
compiler-jx/src/test/resources/royale/projects/super/Base_result.js[diff]
compiler-jx/src/test/resources/royale/projects/super/Super_result.js[diff]

10 files changed