Better error logging around access-denied/
diff --git a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UISecurityInterceptor.java b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UISecurityInterceptor.java
index e3c62d2..8e97899 100644
--- a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UISecurityInterceptor.java
+++ b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/util/UISecurityInterceptor.java
@@ -73,13 +73,12 @@
// are we also enforcing global permissions?
if (theAction.requiredGlobalPermissionActions() != null
- && !theAction.requiredGlobalPermissionActions()
- .isEmpty()) {
- GlobalPermission perm = new GlobalPermission(
- theAction.requiredGlobalPermissionActions());
+ && !theAction.requiredGlobalPermissionActions().isEmpty()) {
+ GlobalPermission perm = new GlobalPermission(theAction.requiredGlobalPermissionActions());
if (!umgr.checkPermission(perm, authenticatedUser)) {
if (log.isDebugEnabled()) {
- log.debug("DENIED: user does not have permission = " + perm.toString());
+ log.debug(String.format("DENIED: user %s does not have permission = %s",
+ authenticatedUser.getUserName(), perm));
}
return UIAction.DENIED;
}
@@ -92,9 +91,9 @@
.getActionWeblog();
if (actionWeblog == null) {
if (log.isWarnEnabled()) {
- log.warn("User " + authenticatedUser.getUserName() +
- " unable to process action \"" + ((UIAction) theAction).getActionName() +
- "\" because no weblog was defined (Check JSP form provides weblog value.)");
+ log.warn(String.format("User %s unable to process action %s " +
+ "because no weblog was defined (Check JSP form provides weblog value).",
+ authenticatedUser.getUserName(), ((UIAction) theAction).getActionName()));
}
return UIAction.DENIED;
}
@@ -109,8 +108,8 @@
if (!umgr.checkPermission(required, authenticatedUser)) {
if (log.isDebugEnabled()) {
- log.debug("DENIED: user does not have required weblog permissions = "
- + required);
+ log.debug(String.format("DENIED: user %s does not have required weblog permissions %s",
+ authenticatedUser.getUserName(), required));
}
return UIAction.DENIED;
}
