commit b566decdaa2ea2630a0b64ef29d6ee8935e6ceea
author yizhe.wcm <42297186+WoodsCumming@users.noreply.github.com> Fri Feb 28 11:31:51 2020 +0800
committer GitHub <noreply@github.com> Fri Feb 28 11:31:51 2020 +0800
tree 689ef10f291eea3ed1959fbcc1b886d3eea9b05b
parent 12a73b1f0c750c9582c9f816dd0d11218728ddd8

fix(memory): fix the risk of heap-buffer-overflow when ‘OrderTopicConf’ is configured illegally.

src/MQClientFactory.cpp

diff --git a/src/MQClientFactory.cpp b/src/MQClientFactory.cpp
index f64818a..cb1a491 100644
--- a/src/MQClientFactory.cpp
+++ b/src/MQClientFactory.cpp
@@ -232,8 +232,8 @@
     for (size_t i = 0; i < brokers.size(); i++) {
       vector<string> item;
       UtilAll::Split(item, brokers[i], ':');
-      int nums = atoi(item[1].c_str());
-      for (int i = 0; i < nums; i++) {
+      size_t nums = (item.size() > 1) ? atoi(item[1].c_str()) : 0;
+      for (size_t i = 0; i < nums; i++) {
         MQMessageQueue mq(topic, item[0], i);
         info->updateMessageQueueList(mq);
       }