[REEF-1904] add toString() to LocalAddressProvider implementations
We need this to improve log readability in the remote manager
JIRA: [REEF-1904](https://issues.apache.org/jira/browse/REEF-1904)
Pull Request:
This closes #1393
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
index c8b484c..4f0d442 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
@@ -31,7 +31,9 @@
* A LocalAddressProvider that uses <code>Inet4Address.getLocalHost().getHostAddress()</code>.
*/
public final class HostnameBasedLocalAddressProvider implements LocalAddressProvider {
+
private static final Logger LOG = Logger.getLogger(HostnameBasedLocalAddressProvider.class.getName());
+
private String cached = null;
/**
@@ -63,4 +65,9 @@
.bind(LocalAddressProvider.class, HostnameBasedLocalAddressProvider.class)
.build();
}
+
+ @Override
+ public String toString() {
+ return "HostnameBasedLocalAddressProvider:" + this.getLocalAddress();
+ }
}
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java
index 9baff92..5f7dcfc 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LoopbackLocalAddressProvider.java
@@ -31,6 +31,8 @@
*/
public final class LoopbackLocalAddressProvider implements LocalAddressProvider {
+ private final String address = InetAddress.getLoopbackAddress().getHostAddress();
+
@Inject
private LoopbackLocalAddressProvider() {
}
@@ -38,7 +40,7 @@
@Override
public String getLocalAddress() {
// Use the loopback address.
- return InetAddress.getLoopbackAddress().getHostAddress();
+ return this.address;
}
@Override
@@ -48,4 +50,9 @@
.bindNamedParameter(RemoteConfiguration.HostAddress.class, getLocalAddress())
.build();
}
+
+ @Override
+ public String toString() {
+ return "LoopbackLocalAddressProvider:" + address;
+ }
}
