[REEF-1376] Delete empty setter in Common.Tasks.TaskMessage.Message (breaking)
JIRA:
[REEF-1376](https://issues.apache.org/jira/browse/REEF-1376)
Pull request:
This closes #1246
diff --git a/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs b/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs
index 4e1a5a0..0e1d8b2 100644
--- a/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Tasks/TaskMessage.cs
@@ -17,48 +17,48 @@
using System;
using Org.Apache.REEF.Utilities;
-using Org.Apache.REEF.Utilities.Logging;
namespace Org.Apache.REEF.Common.Tasks
{
+ /// <summary>
+ /// Task-side TaskMessage.
+ /// </summary>
public class TaskMessage : IMessage
{
- private static readonly Logger LOGGER = Logger.GetLogger(typeof(TaskMessage));
- private readonly string _messageSourcId;
+ private readonly string _messageSourceId;
private readonly byte[] _bytes;
private TaskMessage(string messageSourceId, byte[] bytes)
{
- _messageSourcId = messageSourceId;
+ _messageSourceId = messageSourceId;
_bytes = bytes;
}
public string MessageSourceId
{
- get { return _messageSourcId; }
+ get { return _messageSourceId; }
}
public byte[] Message
{
get { return _bytes; }
- set { }
}
/// <summary>
- /// From byte[] message to a TaskMessage
+ /// From byte[] message to a TaskMessage
/// </summary>
- /// <param name="messageSourceId">messageSourceId The message's sourceID. This will be accessible in the Driver for routing</param>
+ /// <param name="messageSourceId">The message's sourceID. This will be accessible in the Driver for routing</param>
/// <param name="message">The actual content of the message, serialized into a byte[]</param>
/// <returns>a new TaskMessage with the given content</returns>
public static TaskMessage From(string messageSourceId, byte[] message)
{
if (string.IsNullOrEmpty(messageSourceId))
{
- Org.Apache.REEF.Utilities.Diagnostics.Exceptions.Throw(new ArgumentNullException("messageSourceId"), LOGGER);
+ throw new ArgumentNullException("messageSourceId");
}
if (message == null)
{
- Org.Apache.REEF.Utilities.Diagnostics.Exceptions.Throw(new ArgumentNullException("bytes"), LOGGER);
+ throw new ArgumentNullException("message");
}
return new TaskMessage(messageSourceId, message);
}
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
index ea4c1e9..70de035 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
@@ -22,7 +22,7 @@
namespace Org.Apache.REEF.Driver.Bridge.Events
{
/// <summary>
- /// TaskMessage which wraps ITaskMessageClr2Java
+ /// Driver-side TaskMessage which wraps ITaskMessageClr2Java
/// </summary>
[DataContract]
internal sealed class TaskMessage : ITaskMessage
