[REEF-2064] Fix minor java style issues before the CheckStyle and FindBugs upgrade
Mostly remove unnecessary `final` declarations for interfaces and `try() {}` statements
JIRA: [REEF-2064](https://issues.apache.org/jira/browse/REEF-2064)
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/FutureCallback.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/FutureCallback.java
index 75df796..1d5495d 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/FutureCallback.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/FutureCallback.java
@@ -30,11 +30,11 @@
* Invoked with the result of the Tasklet computation on success.
* @param result the result.
*/
- void onSuccess(final V result);
+ void onSuccess(V result);
/**
* Invoked with the error of the Tasklet computation on failure.
* @param t the error.
*/
- void onFailure(final Throwable t);
+ void onFailure(Throwable t);
}
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexAggregateFunction.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexAggregateFunction.java
index b96d19c..7c4ba6d 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexAggregateFunction.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexAggregateFunction.java
@@ -38,5 +38,5 @@
* @return the aggregated output of Tasklets.
* @throws Exception
*/
- TOutput call(final List<TOutput> taskletOutputs) throws VortexAggregateException;
+ TOutput call(List<TOutput> taskletOutputs) throws VortexAggregateException;
}
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexStart.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexStart.java
index 50f9308..d1fbd21 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexStart.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/api/VortexStart.java
@@ -30,5 +30,5 @@
* Your implementation of this interface will be instantiated by Tang
* and this method will be called upon the start of REEF Driver.
*/
- void start(final VortexThreadPool vortexThreadPool);
+ void start(VortexThreadPool vortexThreadPool);
}
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/common/KryoUtils.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/common/KryoUtils.java
index 5fe3f17..406b60a 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/common/KryoUtils.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/common/KryoUtils.java
@@ -56,7 +56,7 @@
}
public byte[] serialize(final Object object) {
- try (final Output out = new Output(new ByteArrayOutputStream())) {
+ try (Output out = new Output(new ByteArrayOutputStream())) {
final Kryo kryo = kryoPool.borrow();
kryo.writeClassAndObject(out, object);
kryoPool.release(kryo);
@@ -65,7 +65,7 @@
}
public Object deserialize(final byte[] bytes) {
- try (final Input input = new Input(new ByteArrayInputStream(bytes))) {
+ try (Input input = new Input(new ByteArrayInputStream(bytes))) {
final Kryo kryo = kryoPool.borrow();
final Object object = kryo.readClassAndObject(input);
kryoPool.release(kryo);
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/SchedulingPolicy.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/SchedulingPolicy.java
index bccc0ea..6081e6e 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/SchedulingPolicy.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/SchedulingPolicy.java
@@ -33,25 +33,25 @@
* @param tasklet to schedule
* @return the worker onto which the tasklet should be scheduled, null if there's none
*/
- Optional<String> trySchedule(final Tasklet tasklet);
+ Optional<String> trySchedule(Tasklet tasklet);
/**
* Worker added.
*/
- void workerAdded(final VortexWorkerManager vortexWorker);
+ void workerAdded(VortexWorkerManager vortexWorker);
/**
* Worker removed.
*/
- void workerRemoved(final VortexWorkerManager vortexWorker);
+ void workerRemoved(VortexWorkerManager vortexWorker);
/**
* Tasklet launched.
*/
- void taskletLaunched(final VortexWorkerManager vortexWorker, final Tasklet tasklet);
+ void taskletLaunched(VortexWorkerManager vortexWorker, Tasklet tasklet);
/**
* Tasklets completed.
*/
- void taskletsDone(final VortexWorkerManager vortexWorker, final List<Tasklet> tasklets);
+ void taskletsDone(VortexWorkerManager vortexWorker, List<Tasklet> tasklets);
}
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexFutureDelegate.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexFutureDelegate.java
index e84840d..893ef69 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexFutureDelegate.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexFutureDelegate.java
@@ -36,25 +36,25 @@
/**
* A Tasklet associated with the future has completed with a result.
*/
- void completed(final int taskletId, TOutput result);
+ void completed(int taskletId, TOutput result);
/**
* The list of aggregated Tasklets associated with the Future that have completed with a result.
*/
- void aggregationCompleted(final List<Integer> taskletIds, final TOutput result);
+ void aggregationCompleted(List<Integer> taskletIds, TOutput result);
/**
* A Tasklet associated with the Future has thrown an Exception.
*/
- void threwException(final int taskletId, final Exception exception);
+ void threwException(int taskletId, Exception exception);
/**
* The list of Tasklets associated with the Future that have thrown an Exception.
*/
- void aggregationThrewException(final List<Integer> taskletIds, final Exception exception);
+ void aggregationThrewException(List<Integer> taskletIds, Exception exception);
/**
* A Tasklet associated with the Future has been cancelled.
*/
- void cancelled(final int taskletId);
+ void cancelled(int taskletId);
}
diff --git a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexMaster.java b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexMaster.java
index 959ed5f..3477cee 100644
--- a/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexMaster.java
+++ b/lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/VortexMaster.java
@@ -39,19 +39,19 @@
* Submit a new Tasklet to be run sometime in the future, with an optional callback function on the result.
*/
<TInput, TOutput> VortexFuture<TOutput>
- enqueueTasklet(final VortexFunction<TInput, TOutput> vortexFunction, final TInput input,
- final Optional<FutureCallback<TOutput>> callback);
+ enqueueTasklet(VortexFunction<TInput, TOutput> vortexFunction, TInput input,
+ Optional<FutureCallback<TOutput>> callback);
/**
* Submits aggregate-able Tasklets to be run sometime in the future, with an optional callback function on
* the aggregation progress.
*/
<TInput, TOutput> VortexAggregateFuture<TInput, TOutput>
- enqueueTasklets(final VortexAggregateFunction<TOutput> aggregateFunction,
- final VortexFunction<TInput, TOutput> vortexFunction,
- final VortexAggregatePolicy policy,
- final List<TInput> inputs,
- final Optional<FutureCallback<AggregateResult<TInput, TOutput>>> callback);
+ enqueueTasklets(VortexAggregateFunction<TOutput> aggregateFunction,
+ VortexFunction<TInput, TOutput> vortexFunction,
+ VortexAggregatePolicy policy,
+ List<TInput> inputs,
+ Optional<FutureCallback<AggregateResult<TInput, TOutput>>> callback);
/**
* Call this when a Tasklet is to be cancelled.
@@ -59,22 +59,22 @@
* prevent a pending Tasklet from running.
* @param taskletId the ID of the Tasklet.
*/
- void cancelTasklet(final boolean mayInterruptIfRunning, final int taskletId);
+ void cancelTasklet(boolean mayInterruptIfRunning, int taskletId);
/**
* Call this when a new worker is up and running.
*/
- void workerAllocated(final VortexWorkerManager vortexWorkerManager);
+ void workerAllocated(VortexWorkerManager vortexWorkerManager);
/**
* Call this when a worker is preempted.
*/
- void workerPreempted(final String id);
+ void workerPreempted(String id);
/**
* Call this when a worker has reported back.
*/
- void workerReported(final String workerId, final WorkerToMasterReports workerToMasterReports);
+ void workerReported(String workerId, WorkerToMasterReports workerToMasterReports);
/**
* Release all resources and shut down.
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroMultiRuntimeAppSubmissionParametersSerializer.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroMultiRuntimeAppSubmissionParametersSerializer.java
index af497cc..02faacb 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroMultiRuntimeAppSubmissionParametersSerializer.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroMultiRuntimeAppSubmissionParametersSerializer.java
@@ -45,7 +45,7 @@
* @throws IOException
*/
AvroMultiRuntimeAppSubmissionParameters fromFile(final File file) throws IOException {
- try (final FileInputStream fileInputStream = new FileInputStream(file)) {
+ try (FileInputStream fileInputStream = new FileInputStream(file)) {
// This is mainly a test hook.
return fromInputStream(fileInputStream);
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroYarnJobSubmissionParametersSerializer.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroYarnJobSubmissionParametersSerializer.java
index 84f0a19..1862851 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroYarnJobSubmissionParametersSerializer.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AvroYarnJobSubmissionParametersSerializer.java
@@ -45,7 +45,7 @@
* @throws IOException
*/
AvroYarnJobSubmissionParameters fromFile(final File file) throws IOException {
- try (final FileInputStream fileInputStream = new FileInputStream(file)) {
+ try (FileInputStream fileInputStream = new FileInputStream(file)) {
// This is mainly a test hook.
return fromInputStream(fileInputStream);
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java
index 35a2e86..800d033 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/AzureBatchBootstrapREEFLauncher.java
@@ -109,7 +109,7 @@
final Configuration launcherConfig = launcherConfigBuilder.build();
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(
azureBatchBootstrapDriverConfigGenerator.getDriverConfigurationFromParams(
jobSubmissionParameters), launcherConfig)) {
reef.run();
@@ -125,7 +125,7 @@
private static AvroAzureBatchJobSubmissionParameters readAvroJobSubmissionParameters(
final File paramsFile) throws IOException {
final AvroAzureBatchJobSubmissionParameters avroAzureBatchJobSubmissionParameters;
- try (final FileInputStream fileInputStream = new FileInputStream(paramsFile)) {
+ try (FileInputStream fileInputStream = new FileInputStream(paramsFile)) {
final JsonDecoder decoder = DecoderFactory.get().jsonDecoder(
AvroAzureBatchJobSubmissionParameters.getClassSchema(), fileInputStream);
final SpecificDatumReader<AvroAzureBatchJobSubmissionParameters> reader =
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/DriverStatusHTTPHandler.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/DriverStatusHTTPHandler.java
index c2c2b87..2334e8f 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/DriverStatusHTTPHandler.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/DriverStatusHTTPHandler.java
@@ -116,7 +116,7 @@
@Override
public void onHttpRequest(final ParsedHttpRequest parsedHttpRequest, final HttpServletResponse response)
throws IOException, ServletException {
- try (final PrintWriter writer = response.getWriter()) {
+ try (PrintWriter writer = response.getWriter()) {
writer.write(waitAndGetMessage());
this.wasCalledViaHTTP = true;
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/JobResourceUploader.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/JobResourceUploader.java
index e03013a..4801e2a 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/JobResourceUploader.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/JobResourceUploader.java
@@ -77,7 +77,7 @@
resource.getPort(), resource.getFile(), localResource.getTimestamp(), localResource.getSize());
LOG.log(Level.INFO, "Writing output: " + outputString);
try (Writer writer = new BufferedWriter(new OutputStreamWriter(
- new FileOutputStream(localOutputPath), "utf-8"))) {
+ new FileOutputStream(localOutputPath), "utf-8"))) {
writer.write(outputString);
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalSubmissionFromCS.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalSubmissionFromCS.java
index 3c7e6b2..fa49e88 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalSubmissionFromCS.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/LocalSubmissionFromCS.java
@@ -172,7 +172,7 @@
final AvroLocalJobSubmissionParameters localJobSubmissionParameters;
- try (final FileInputStream fileInputStream = new FileInputStream(localJobSubmissionParametersFile)) {
+ try (FileInputStream fileInputStream = new FileInputStream(localJobSubmissionParametersFile)) {
final JsonDecoder decoder = DecoderFactory.get().jsonDecoder(
AvroLocalJobSubmissionParameters.getClassSchema(), fileInputStream);
final SpecificDatumReader<AvroLocalJobSubmissionParameters> reader =
@@ -180,7 +180,7 @@
localJobSubmissionParameters = reader.read(null, decoder);
}
- try (final FileInputStream fileInputStream = new FileInputStream(localAppSubmissionParametersFile)) {
+ try (FileInputStream fileInputStream = new FileInputStream(localAppSubmissionParametersFile)) {
final JsonDecoder decoder = DecoderFactory.get().jsonDecoder(
AvroLocalAppSubmissionParameters.getClassSchema(), fileInputStream);
final SpecificDatumReader<AvroLocalAppSubmissionParameters> reader =
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/SecurityTokensReader.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/SecurityTokensReader.java
index a1d908e..32fddde 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/SecurityTokensReader.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/SecurityTokensReader.java
@@ -61,7 +61,7 @@
void addTokensFromFile(final UserGroupInformation ugi) throws IOException {
LOG.log(Level.FINE, "Reading security tokens from file: {0}", this.securityTokensFile);
- try (final FileInputStream stream = new FileInputStream(securityTokensFile)) {
+ try (FileInputStream stream = new FileInputStream(securityTokensFile)) {
final BinaryDecoder decoder = decoderFactory.binaryDecoder(stream, null);
while (!decoder.isEnd()) {
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnBootstrapDriverConfigGenerator.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnBootstrapDriverConfigGenerator.java
index 9814e84..1e9ee71 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnBootstrapDriverConfigGenerator.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnBootstrapDriverConfigGenerator.java
@@ -146,7 +146,7 @@
static AvroYarnAppSubmissionParameters readYarnAppSubmissionParametersFromFile(final File file)
throws IOException {
- try (final FileInputStream fileInputStream = new FileInputStream(file)) {
+ try (FileInputStream fileInputStream = new FileInputStream(file)) {
// This is mainly a test hook.
return readYarnAppSubmissionParametersFromInputStream(fileInputStream);
}
@@ -163,7 +163,7 @@
static AvroYarnJobSubmissionParameters readYarnJobSubmissionParametersFromFile(final File file)
throws IOException {
- try (final FileInputStream fileInputStream = new FileInputStream(file)) {
+ try (FileInputStream fileInputStream = new FileInputStream(file)) {
// This is mainly a test hook.
return readYarnJobSubmissionParametersFromInputStream(fileInputStream);
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java
index b45a2f2..e2115c3 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnClusterSubmissionFromCS.java
@@ -255,8 +255,8 @@
static YarnClusterSubmissionFromCS fromJobSubmissionParametersFile(final File yarnClusterAppSubmissionParametersFile,
final File yarnClusterJobSubmissionParametersFile)
throws IOException {
- try (final FileInputStream appFileInputStream = new FileInputStream(yarnClusterAppSubmissionParametersFile)) {
- try (final FileInputStream jobFileInputStream = new FileInputStream(yarnClusterJobSubmissionParametersFile)) {
+ try (FileInputStream appFileInputStream = new FileInputStream(yarnClusterAppSubmissionParametersFile)) {
+ try (FileInputStream jobFileInputStream = new FileInputStream(yarnClusterJobSubmissionParametersFile)) {
// this is mainly a test hook
return readYarnClusterSubmissionFromCSFromInputStream(appFileInputStream, jobFileInputStream);
}
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
index b62c2e4..e169ced 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnJobSubmissionClient.java
@@ -129,7 +129,7 @@
// ------------------------------------------------------------------------
// Get an application ID
- try (final YarnSubmissionHelper submissionHelper = new YarnSubmissionHelper(
+ try (YarnSubmissionHelper submissionHelper = new YarnSubmissionHelper(
this.yarnConfiguration, this.fileNames, this.classpath, this.yarnProxyUser,
this.tokenProvider, this.isUnmanaged, this.commandPrefixList)) {
diff --git a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnSubmissionParametersFileGenerator.java b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnSubmissionParametersFileGenerator.java
index 506ced6..2c12743 100644
--- a/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnSubmissionParametersFileGenerator.java
+++ b/lang/java/reef-bridge-client/src/main/java/org/apache/reef/bridge/client/YarnSubmissionParametersFileGenerator.java
@@ -60,8 +60,8 @@
final File yarnJobParametersFile = new File(yarnClusterSubmissionFromCS.getDriverFolder(),
fileNames.getYarnBootstrapJobParamFilePath());
- try (final FileOutputStream appFileOutputStream = new FileOutputStream(yarnAppParametersFile)) {
- try (final FileOutputStream jobFileOutputStream = new FileOutputStream(yarnJobParametersFile)) {
+ try (FileOutputStream appFileOutputStream = new FileOutputStream(yarnAppParametersFile)) {
+ try (FileOutputStream jobFileOutputStream = new FileOutputStream(yarnJobParametersFile)) {
// this is mainly a test hook.
writeAvroYarnAppSubmissionParametersToOutputStream(yarnClusterSubmissionFromCS, appFileOutputStream);
writeAvroYarnJobSubmissionParametersToOutputStream(
diff --git a/lang/java/reef-bridge-client/src/test/java/org/apache/reef/bridge/client/TestAvroJobSubmissionParametersSerializationFromCS.java b/lang/java/reef-bridge-client/src/test/java/org/apache/reef/bridge/client/TestAvroJobSubmissionParametersSerializationFromCS.java
index f733131..6688614 100644
--- a/lang/java/reef-bridge-client/src/test/java/org/apache/reef/bridge/client/TestAvroJobSubmissionParametersSerializationFromCS.java
+++ b/lang/java/reef-bridge-client/src/test/java/org/apache/reef/bridge/client/TestAvroJobSubmissionParametersSerializationFromCS.java
@@ -236,8 +236,8 @@
*/
@Test
public void testAvroYarnParametersSerialization() throws IOException {
- try (final ByteArrayOutputStream appOutputStream = new ByteArrayOutputStream()) {
- try (final ByteArrayOutputStream jobOutputStream = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream appOutputStream = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream jobOutputStream = new ByteArrayOutputStream()) {
final YarnClusterSubmissionFromCS clusterSubmissionFromCS = createYarnClusterSubmissionFromCS();
YarnSubmissionParametersFileGenerator.writeAvroYarnAppSubmissionParametersToOutputStream(
clusterSubmissionFromCS, appOutputStream);
@@ -247,8 +247,8 @@
final byte[] jobContent = jobOutputStream.toByteArray();
final byte[] appContent = appOutputStream.toByteArray();
- try (final InputStream appStream = new ByteArrayInputStream(appContent)) {
- try (final InputStream jobStream = new ByteArrayInputStream(jobContent)) {
+ try (InputStream appStream = new ByteArrayInputStream(appContent)) {
+ try (InputStream jobStream = new ByteArrayInputStream(jobContent)) {
verifyYarnJobSubmissionParams(
YarnBootstrapDriverConfigGenerator.readYarnJobSubmissionParametersFromInputStream(jobStream),
YarnBootstrapDriverConfigGenerator.readYarnAppSubmissionParametersFromInputStream(appStream));
@@ -279,7 +279,7 @@
}
private static AvroYarnAppSubmissionParameters createAvroYarnAppSubmissionParameters() throws IOException {
- try (final InputStream stream =
+ try (InputStream stream =
new ByteArrayInputStream(AVRO_YARN_APP_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets.UTF_8))) {
return YarnBootstrapDriverConfigGenerator.readYarnAppSubmissionParametersFromInputStream(stream);
}
@@ -287,7 +287,7 @@
private static AvroMultiRuntimeAppSubmissionParameters createAvroMultiruntimeAppSubmissionParameters()
throws IOException, InjectionException {
- try (final InputStream stream =
+ try (InputStream stream =
new ByteArrayInputStream(
AVRO_YARN_MULTIRUNTIME_APP_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets.UTF_8))) {
return Tang.Factory.getTang().newInjector().getInstance(AvroMultiRuntimeAppSubmissionParametersSerializer.class)
@@ -297,7 +297,7 @@
private static AvroMultiRuntimeAppSubmissionParameters createAvroMultiruntimeYarnOnlyAppSubmissionParameters()
throws IOException, InjectionException {
- try (final InputStream stream =
+ try (InputStream stream =
new ByteArrayInputStream(
AVRO_YARN_MULTIRUNTIME_YARNONLY_APP_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets
.UTF_8))) {
@@ -308,7 +308,7 @@
private static AvroMultiRuntimeAppSubmissionParameters createAvroMultiruntimeLocalOnlyAppSubmissionParameters()
throws IOException, InjectionException {
- try (final InputStream stream =
+ try (InputStream stream =
new ByteArrayInputStream(
AVRO_YARN_MULTIRUNTIME_LOCALONLY_APP_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets
.UTF_8))) {
@@ -318,17 +318,17 @@
}
private static AvroYarnJobSubmissionParameters createAvroYarnJobSubmissionParameters() throws IOException {
- try (final InputStream stream =
+ try (InputStream stream =
new ByteArrayInputStream(AVRO_YARN_JOB_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets.UTF_8))) {
return YarnBootstrapDriverConfigGenerator.readYarnJobSubmissionParametersFromInputStream(stream);
}
}
private static YarnClusterSubmissionFromCS createYarnClusterSubmissionFromCS() throws IOException {
- try (final InputStream appStream =
+ try (InputStream appStream =
new ByteArrayInputStream(
AVRO_YARN_APP_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets.UTF_8))) {
- try (final InputStream jobStream =
+ try (InputStream jobStream =
new ByteArrayInputStream(
AVRO_YARN_CLUSTER_JOB_PARAMETERS_SERIALIZED_STRING.getBytes(StandardCharsets.UTF_8))) {
return YarnClusterSubmissionFromCS.readYarnClusterSubmissionFromCSFromInputStream(appStream, jobStream);
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/EvaluatorRequestorBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/EvaluatorRequestorBridge.java
index 2327846..b20700f 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/EvaluatorRequestorBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/EvaluatorRequestorBridge.java
@@ -80,7 +80,7 @@
LOG.log(Level.WARNING, "Ignoring rack preference.");
}
- try (final LoggingScope ls = loggingScopeFactory.evaluatorRequestSubmitToJavaDriver(evaluatorsNumber)) {
+ try (LoggingScope ls = loggingScopeFactory.evaluatorRequestSubmitToJavaDriver(evaluatorsNumber)) {
clrEvaluatorsNumber += evaluatorsNumber;
final EvaluatorRequest request = EvaluatorRequest.newBuilder()
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedTaskBridge.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedTaskBridge.java
index 0f2221a..ab6f0f0 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedTaskBridge.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/FailedTaskBridge.java
@@ -75,7 +75,7 @@
if (jfailedTask.getData() != null && jfailedTask.getData().isPresent()) {
// Deserialize what was passed in from C#.
- try (final ByteArrayInputStream fileInputStream = new ByteArrayInputStream(jfailedTask.getData().get())) {
+ try (ByteArrayInputStream fileInputStream = new ByteArrayInputStream(jfailedTask.getData().get())) {
final JsonDecoder decoder = DecoderFactory.get().jsonDecoder(
AvroFailedTask.getClassSchema(), fileInputStream);
final SpecificDatumReader<AvroFailedTask> reader =
@@ -101,7 +101,7 @@
final DatumWriter<AvroFailedTask> datumWriter = new SpecificDatumWriter<>(AvroFailedTask.class);
- try (final ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(avroFailedTask.getSchema(), outputStream);
datumWriter.write(avroFailedTask, encoder);
encoder.flush();
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
index de9f95b..8e11502 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/NativeInterop.java
@@ -29,121 +29,122 @@
@Private
@Interop(CppFiles = { "JavaClrBridge.h", "JavaClrBridge.cpp" })
public final class NativeInterop {
+
public static final String GLOBAL_LIBRARIES_FILENAME = "userSuppliedGlobalLibraries.txt";
- public static native void loadClrAssembly(final String filePath);
+ public static native void loadClrAssembly(String filePath);
- public static native void clrBufferedLog(final int level, final String message);
+ public static native void clrBufferedLog(int level, String message);
public static native void callClrSystemOnStartHandler();
public static native void clrSystemAllocatedEvaluatorHandlerOnNext(
- final long handle,
- final AllocatedEvaluatorBridge javaEvaluatorBridge,
- final InteropLogger interopLogger,
- final String nameServerInfo,
- final String evaluatorId
+ long handle,
+ AllocatedEvaluatorBridge javaEvaluatorBridge,
+ InteropLogger interopLogger,
+ String nameServerInfo,
+ String evaluatorId
);
public static native void clrSystemActiveContextHandlerOnNext(
- final long handle,
- final ActiveContextBridge javaActiveContextBridge,
- final InteropLogger interopLogger
+ long handle,
+ ActiveContextBridge javaActiveContextBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemTaskMessageHandlerOnNext(
- final long handle,
- final byte[] message,
- final TaskMessageBridge javaTaskMessageBridge,
- final InteropLogger interopLogger
+ long handle,
+ byte[] message,
+ TaskMessageBridge javaTaskMessageBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemFailedTaskHandlerOnNext(
- final long handle,
- final FailedTaskBridge failedTaskBridge,
- final InteropLogger interopLogger
+ long handle,
+ FailedTaskBridge failedTaskBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemHttpServerHandlerOnNext(
- final long handle,
- final HttpServerEventBridge httpServerEventBridge,
- final InteropLogger interopLogger
+ long handle,
+ HttpServerEventBridge httpServerEventBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemFailedEvaluatorHandlerOnNext(
- final long handle,
- final FailedEvaluatorBridge failedEvaluatorBridge,
- final InteropLogger interopLogger
+ long handle,
+ FailedEvaluatorBridge failedEvaluatorBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemCompletedTaskHandlerOnNext(
- final long handle,
- final CompletedTaskBridge completedTaskBridge,
- final InteropLogger interopLogger
+ long handle,
+ CompletedTaskBridge completedTaskBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemRunningTaskHandlerOnNext(
- final long handle,
- final RunningTaskBridge runningTaskBridge,
- final InteropLogger interopLogger
+ long handle,
+ RunningTaskBridge runningTaskBridge,
+ InteropLogger interopLogger
);
public static native void clrSystemSuspendedTaskHandlerOnNext(
- final long handle,
- final SuspendedTaskBridge suspendedTaskBridge
+ long handle,
+ SuspendedTaskBridge suspendedTaskBridge
);
public static native void clrSystemCompletedEvaluatorHandlerOnNext(
- final long handle,
- final CompletedEvaluatorBridge completedEvaluatorBridge
+ long handle,
+ CompletedEvaluatorBridge completedEvaluatorBridge
);
public static native void clrSystemClosedContextHandlerOnNext(
- final long handle,
- final ClosedContextBridge closedContextBridge
+ long handle,
+ ClosedContextBridge closedContextBridge
);
public static native void clrSystemFailedContextHandlerOnNext(
- final long handle,
- final FailedContextBridge failedContextBridge
+ long handle,
+ FailedContextBridge failedContextBridge
);
public static native void clrSystemContextMessageHandlerOnNext(
- final long handle,
- final ContextMessageBridge contextMessageBridge
+ long handle,
+ ContextMessageBridge contextMessageBridge
);
public static native void callClrSystemOnRestartHandler(
- final DriverRestartedBridge driverRestartedBridge
+ DriverRestartedBridge driverRestartedBridge
);
public static native void clrSystemDriverRestartActiveContextHandlerOnNext(
- final long handle,
- final ActiveContextBridge activeContextBridge
+ long handle,
+ ActiveContextBridge activeContextBridge
);
public static native void clrSystemDriverRestartRunningTaskHandlerOnNext(
- final long handle,
- final RunningTaskBridge runningTaskBridge
+ long handle,
+ RunningTaskBridge runningTaskBridge
);
public static native void clrSystemDriverRestartCompletedHandlerOnNext(
- final long handle,
- final DriverRestartCompletedBridge driverRestartCompletedBridge
+ long handle,
+ DriverRestartCompletedBridge driverRestartCompletedBridge
);
public static native void clrSystemDriverRestartFailedEvaluatorHandlerOnNext(
- final long handle,
- final FailedEvaluatorBridge failedEvaluatorBridge,
- final InteropLogger interopLogger
+ long handle,
+ FailedEvaluatorBridge failedEvaluatorBridge,
+ InteropLogger interopLogger
);
- public static native float clrSystemProgressProviderGetProgress(final long handle);
+ public static native float clrSystemProgressProviderGetProgress(long handle);
public static native void clrSystemSetupBridgeHandlerManager(
- final String httpServerPortNumber,
- final BridgeHandlerManager bridgeHandlerManager,
- final EvaluatorRequestorBridge javaEvaluatorRequestorBridge
+ String httpServerPortNumber,
+ BridgeHandlerManager bridgeHandlerManager,
+ EvaluatorRequestorBridge javaEvaluatorRequestorBridge
);
/**
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
index b50131c..a4b3c71 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/Utilities.java
@@ -49,7 +49,7 @@
throw new RuntimeException("cannot find file " + p.toAbsolutePath());
}
// TODO[JIRA REEF-400] Use the AvroClassHierarchySerializer in place of protobuf
- try (final InputStream chin = new FileInputStream(p.toAbsolutePath().toString())) {
+ try (InputStream chin = new FileInputStream(p.toAbsolutePath().toString())) {
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
final ClassHierarchy ch = new ProtocolBufferClassHierarchy(root);
return ch;
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
index 8ec68ae..8253a93 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobClient.java
@@ -163,7 +163,7 @@
}
public void addCLRFiles(final File folder) throws BindException {
- try (final LoggingScope ls = this.loggingScopeFactory.getNewLoggingScope("JobClient::addCLRFiles")) {
+ try (LoggingScope ls = this.loggingScopeFactory.getNewLoggingScope("JobClient::addCLRFiles")) {
ConfigurationModule result = this.driverConfigModule;
final File[] files = folder.listFiles();
if (files != null) {
@@ -211,7 +211,7 @@
*/
public void submit(final File clrFolder, final boolean submitDriver,
final boolean local, final Configuration clientConfig) {
- try (final LoggingScope ls = this.loggingScopeFactory.driverSubmit(submitDriver)) {
+ try (LoggingScope ls = this.loggingScopeFactory.driverSubmit(submitDriver)) {
if (!local) {
this.driverConfiguration = Configurations.merge(this.driverConfiguration, getYarnConfiguration());
}
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
index ddc3385..737d09c 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/JobDriver.java
@@ -175,7 +175,7 @@
// Signal to the clr buffered log handler that the driver has started and that
// we can begin logging
LOG.log(Level.INFO, "Initializing CLRBufferedLogHandler...");
- try (final LoggingScope lb = this.loggingScopeFactory.setupBridge()) {
+ try (LoggingScope lb = this.loggingScopeFactory.setupBridge()) {
final CLRBufferedLogHandler handler = getCLRBufferedLogHandler();
if (handler == null) {
LOG.log(Level.WARNING, "CLRBufferedLogHandler could not be initialized");
@@ -204,7 +204,7 @@
NativeInterop.clrSystemSetupBridgeHandlerManager(portNumber,
JobDriver.this.handlerManager, evaluatorRequestorBridge);
- try (final LoggingScope lp =
+ try (LoggingScope lp =
this.loggingScopeFactory.getNewLoggingScope("setupBridge::clrSystemHttpServerHandlerOnNext")) {
final HttpServerEventBridge httpServerEventBridge = new HttpServerEventBridge("SPEC");
NativeInterop.clrSystemHttpServerHandlerOnNext(JobDriver.this.handlerManager.getHttpServerEventHandler(),
@@ -251,7 +251,7 @@
}
private void handleFailedEvaluator(final FailedEvaluator eval, final boolean isRestartFailed) {
- try (final LoggingScope ls = loggingScopeFactory.evaluatorFailed(eval.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.evaluatorFailed(eval.getId())) {
LOG.log(Level.SEVERE, "FailedEvaluator", eval);
for (final FailedContext failedContext : eval.getFailedContextList()) {
final String failedContextId = failedContext.getId();
@@ -349,7 +349,7 @@
public final class AllocatedEvaluatorHandler implements EventHandler<AllocatedEvaluator> {
@Override
public void onNext(final AllocatedEvaluator allocatedEvaluator) {
- try (final LoggingScope ls = loggingScopeFactory.evaluatorAllocated(allocatedEvaluator.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.evaluatorAllocated(allocatedEvaluator.getId())) {
LOG.log(Level.INFO, "AllocatedEvaluatorHandler.OnNext");
JobDriver.this.submitEvaluator(allocatedEvaluator, clrProcessFactory.newEvaluatorProcess());
}
@@ -362,7 +362,7 @@
public final class ActiveContextHandler implements EventHandler<ActiveContext> {
@Override
public void onNext(final ActiveContext context) {
- try (final LoggingScope ls = loggingScopeFactory.activeContextReceived(context.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.activeContextReceived(context.getId())) {
LOG.log(Level.INFO, "ActiveContextHandler: Context available: {0}",
new Object[]{context.getId()});
JobDriver.this.contexts.put(context.getId(), context);
@@ -378,7 +378,7 @@
@Override
public void onNext(final CompletedTask task) {
LOG.log(Level.INFO, "Completed task: {0}", task.getId());
- try (final LoggingScope ls = loggingScopeFactory.taskCompleted(task.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.taskCompleted(task.getId())) {
// Take the message returned by the task and add it to the running result.
String result = "default result";
try {
@@ -443,7 +443,7 @@
public void onHttpRequest(final ParsedHttpRequest parsedHttpRequest, final HttpServletResponse response)
throws IOException, ServletException {
LOG.log(Level.INFO, "HttpServerBridgeEventHandler onHttpRequest: {0}", parsedHttpRequest.getRequestUri());
- try (final LoggingScope ls = loggingScopeFactory.httpRequest(parsedHttpRequest.getRequestUri())) {
+ try (LoggingScope ls = loggingScopeFactory.httpRequest(parsedHttpRequest.getRequestUri())) {
final AvroHttpSerializer httpSerializer = new AvroHttpSerializer();
final AvroHttpRequest avroHttpRequest = httpSerializer.toAvro(parsedHttpRequest);
@@ -493,7 +493,7 @@
public final class RunningTaskHandler implements EventHandler<RunningTask> {
@Override
public void onNext(final RunningTask task) {
- try (final LoggingScope ls = loggingScopeFactory.taskRunning(task.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.taskRunning(task.getId())) {
if (JobDriver.this.handlerManager.getRunningTaskHandler() == 0) {
LOG.log(Level.INFO, "RunningTask event received but no CLR handler was bound. Exiting handler.");
} else {
@@ -517,7 +517,7 @@
public final class DriverRestartRunningTaskHandler implements EventHandler<RunningTask> {
@Override
public void onNext(final RunningTask task) {
- try (final LoggingScope ls = loggingScopeFactory.driverRestartRunningTask(task.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.driverRestartRunningTask(task.getId())) {
clock.scheduleAlarm(0, new EventHandler<Alarm>() {
@Override
public void onNext(final Alarm time) {
@@ -548,7 +548,7 @@
public final class DriverRestartActiveContextHandler implements EventHandler<ActiveContext> {
@Override
public void onNext(final ActiveContext context) {
- try (final LoggingScope ls = loggingScopeFactory.driverRestartActiveContextReceived(context.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.driverRestartActiveContextReceived(context.getId())) {
JobDriver.this.contexts.put(context.getId(), context);
LOG.log(Level.INFO, "DriverRestartActiveContextHandler event received: " + context.getId());
clock.scheduleAlarm(0, new EventHandler<Alarm>() {
@@ -581,7 +581,7 @@
public final class StartHandler implements EventHandler<StartTime> {
@Override
public void onNext(final StartTime startTime) {
- try (final LoggingScope ls = loggingScopeFactory.driverStart(startTime)) {
+ try (LoggingScope ls = loggingScopeFactory.driverStart(startTime)) {
// CLR bridge setup must be done before other event handlers try to access the CLR bridge
// thus we grab a lock on this instance
synchronized (JobDriver.this) {
@@ -602,7 +602,7 @@
public final class RestartHandler implements EventHandler<DriverRestarted> {
@Override
public void onNext(final DriverRestarted driverRestarted) {
- try (final LoggingScope ls = loggingScopeFactory.driverRestart(driverRestarted.getStartTime())) {
+ try (LoggingScope ls = loggingScopeFactory.driverRestart(driverRestarted.getStartTime())) {
// CLR bridge setup must be done before other event handlers try to access the CLR bridge
// thus we lock on this instance
synchronized (JobDriver.this) {
@@ -625,7 +625,7 @@
public void onNext(final DriverRestartCompleted driverRestartCompleted) {
LOG.log(Level.INFO, "Java DriverRestartCompleted event received at time [{0}]. ",
driverRestartCompleted.getCompletedTime());
- try (final LoggingScope ls = loggingScopeFactory.driverRestartCompleted(
+ try (LoggingScope ls = loggingScopeFactory.driverRestartCompleted(
driverRestartCompleted.getCompletedTime().getTimestamp())) {
if (JobDriver.this.handlerManager.getDriverRestartCompletedHandler() != 0) {
LOG.log(Level.INFO, "CLR driver restart handler implemented, now handle it in CLR.");
@@ -647,7 +647,7 @@
@Override
public void onNext(final StopTime time) {
LOG.log(Level.INFO, " StopTime: {0}", new Object[]{time});
- try (final LoggingScope ls = loggingScopeFactory.driverStop(time.getTimestamp())) {
+ try (LoggingScope ls = loggingScopeFactory.driverStop(time.getTimestamp())) {
for (final ActiveContext context : contexts.values()) {
context.close();
}
@@ -682,7 +682,7 @@
public void onNext(final SuspendedTask task) {
final String message = "Received notification that task [" + task.getId() + "] has been suspended.";
LOG.log(Level.INFO, message);
- try (final LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.taskSuspended(task.getId())) {
if (JobDriver.this.handlerManager.getSuspendedTaskHandler() != 0) {
final SuspendedTaskBridge suspendedTaskBridge = new SuspendedTaskBridge(task, activeContextBridgeFactory);
// if CLR implements the suspended task handler, handle it in CLR
@@ -702,7 +702,7 @@
@Override
public void onNext(final CompletedEvaluator evaluator) {
LOG.log(Level.INFO, " Completed Evaluator {0}", evaluator.getId());
- try (final LoggingScope ls = loggingScopeFactory.evaluatorCompleted(evaluator.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.evaluatorCompleted(evaluator.getId())) {
if (JobDriver.this.handlerManager.getCompletedEvaluatorHandler() != 0) {
final CompletedEvaluatorBridge completedEvaluatorBridge = new CompletedEvaluatorBridge(evaluator);
// if CLR implements the completed evaluator handler, handle it in CLR
@@ -724,7 +724,7 @@
@Override
public void onNext(final ClosedContext context) {
LOG.log(Level.INFO, "Completed Context: {0}", context.getId());
- try (final LoggingScope ls = loggingScopeFactory.closedContext(context.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.closedContext(context.getId())) {
if (JobDriver.this.handlerManager.getClosedContextHandler() != 0) {
final ClosedContextBridge closedContextBridge = new ClosedContextBridge(context, activeContextBridgeFactory);
// if CLR implements the closed context handler, handle it in CLR
@@ -746,7 +746,7 @@
@Override
public void onNext(final FailedContext context) {
LOG.log(Level.SEVERE, "FailedContext", context);
- try (final LoggingScope ls = loggingScopeFactory.evaluatorFailed(context.getId())) {
+ try (LoggingScope ls = loggingScopeFactory.evaluatorFailed(context.getId())) {
if (JobDriver.this.handlerManager.getFailedContextHandler() != 0) {
final FailedContextBridge failedContextBridge = new FailedContextBridge(context, activeContextBridgeFactory);
// if CLR implements the failed context handler, handle it in CLR
@@ -770,7 +770,7 @@
@Override
public void onNext(final ContextMessage message) {
LOG.log(Level.SEVERE, "Received ContextMessage:", message.get());
- try (final LoggingScope ls =
+ try (LoggingScope ls =
loggingScopeFactory.contextMessageReceived(new String(message.get(), StandardCharsets.UTF_8))) {
if (JobDriver.this.handlerManager.getContextMessageHandler() != 0) {
final ContextMessageBridge contextMessageBridge = new ContextMessageBridge(message);
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
index 0d53071..772cb77 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/generic/Launch.java
@@ -104,7 +104,7 @@
private static Configuration getClientConfiguration(final String[] args)
throws BindException, InjectionException, IOException {
- try (final LoggingScope ls = LoggingScopeFactory.getNewLoggingScope(Level.INFO, "Launch::getClientConfiguration")) {
+ try (LoggingScope ls = LoggingScopeFactory.getNewLoggingScope(Level.INFO, "Launch::getClientConfiguration")) {
final Configuration commandLineConf = parseCommandLine(args);
final Configuration clientConfiguration = ClientConfiguration.CONF
diff --git a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/utils/DefinedRuntimesSerializer.java b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/utils/DefinedRuntimesSerializer.java
index 02c5df7..44a79a5 100644
--- a/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/utils/DefinedRuntimesSerializer.java
+++ b/lang/java/reef-bridge-java/src/main/java/org/apache/reef/javabridge/utils/DefinedRuntimesSerializer.java
@@ -44,7 +44,7 @@
public byte[] toBytes(final DefinedRuntimes definedRuntimes){
final DatumWriter<DefinedRuntimes> configurationWriter =
new SpecificDatumWriter<>(DefinedRuntimes.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder binaryEncoder = EncoderFactory.get().binaryEncoder(out, null);
configurationWriter.write(definedRuntimes, binaryEncoder);
binaryEncoder.flush();
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverClientService.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverClientService.java
index 42b00af..3937434 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverClientService.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverClientService.java
@@ -40,7 +40,7 @@
* requested by the application.
* @param count of the number of evaluators
*/
- void notifyEvaluatorRequest(final int count);
+ void notifyEvaluatorRequest(int count);
/**
* Wait for termination of driver client service.
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverServiceClient.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverServiceClient.java
index 038a529..9018955 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverServiceClient.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/DriverServiceClient.java
@@ -33,7 +33,7 @@
@Private
public interface DriverServiceClient {
- void onInitializationException(final Throwable ex);
+ void onInitializationException(Throwable ex);
/**
* Initiate shutdown.
@@ -44,26 +44,26 @@
* Initiate shutdown with error.
* @param ex exception error
*/
- void onShutdown(final Throwable ex);
+ void onShutdown(Throwable ex);
/**
* Set alarm.
* @param alarmId alarm identifier
* @param timeoutMS timeout in milliseconds
*/
- void onSetAlarm(final String alarmId, final int timeoutMS);
+ void onSetAlarm(String alarmId, int timeoutMS);
/**
* Request evaluators.
* @param evaluatorRequest event
*/
- void onEvaluatorRequest(final EvaluatorRequest evaluatorRequest);
+ void onEvaluatorRequest(EvaluatorRequest evaluatorRequest);
/**
* Close evaluator.
* @param evalautorId to close
*/
- void onEvaluatorClose(final String evalautorId);
+ void onEvaluatorClose(String evalautorId);
/**
* Submit context and/or task.
@@ -75,12 +75,12 @@
* @param addLibraryList to include
*/
void onEvaluatorSubmit(
- final String evaluatorId,
- final Optional<Configuration> contextConfiguration,
- final Optional<Configuration> taskConfiguration,
- final Optional<JVMClientProcess> evaluatorProcess,
- final List<File> addFileList,
- final List<File> addLibraryList);
+ String evaluatorId,
+ Optional<Configuration> contextConfiguration,
+ Optional<Configuration> taskConfiguration,
+ Optional<JVMClientProcess> evaluatorProcess,
+ List<File> addFileList,
+ List<File> addLibraryList);
// Context Operations
@@ -88,7 +88,7 @@
* Close context.
* @param contextId to close
*/
- void onContextClose(final String contextId);
+ void onContextClose(String contextId);
/**
* Submit child context.
@@ -96,8 +96,8 @@
* @param contextConfiguration for child context
*/
void onContextSubmitContext(
- final String contextId,
- final Configuration contextConfiguration);
+ String contextId,
+ Configuration contextConfiguration);
/**
* Submit task.
@@ -105,15 +105,15 @@
* @param taskConfiguration for task
*/
void onContextSubmitTask(
- final String contextId,
- final Configuration taskConfiguration);
+ String contextId,
+ Configuration taskConfiguration);
/**
* Send message to context.
* @param contextId to destination context
* @param message to send
*/
- void onContextMessage(final String contextId, final byte[] message);
+ void onContextMessage(String contextId, byte[] message);
// Task operations
@@ -122,19 +122,19 @@
* @param taskId to close
* @param message optional message to include
*/
- void onTaskClose(final String taskId, final Optional<byte[]> message);
+ void onTaskClose(String taskId, Optional<byte[]> message);
/**
* Send task a message.
* @param taskId of destination task
* @param message to send
*/
- void onTaskMessage(final String taskId, final byte[] message);
+ void onTaskMessage(String taskId, byte[] message);
/**
* Suspend a running task.
* @param taskId task identifier
* @param message optional message
*/
- void onSuspendTask(final String taskId, final Optional<byte[]> message);
+ void onSuspendTask(String taskId, Optional<byte[]> message);
}
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/JavaDriverClientLauncher.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/JavaDriverClientLauncher.java
index 7522cba..5bc6575 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/JavaDriverClientLauncher.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/JavaDriverClientLauncher.java
@@ -188,7 +188,7 @@
final Injector injector = TANG.newInjector(launcher.envConfig);
try {
final DriverServiceClient driverServiceClient = injector.getInstance(DriverServiceClient.class);
- try (final Clock reef = injector.getInstance(Clock.class)) {
+ try (Clock reef = injector.getInstance(Clock.class)) {
reef.run();
} catch (final InjectionException ex) {
LOG.log(Level.SEVERE, "Unable to configure driver client.");
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/grpc/GRPCDriverClientService.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/grpc/GRPCDriverClientService.java
index f68a1cb..a4b50f3 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/grpc/GRPCDriverClientService.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/client/grpc/GRPCDriverClientService.java
@@ -164,7 +164,7 @@
@Override
public void startHandler(final StartTimeInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "StartHandler at time {0}", request.getStartTime());
final StartTime startTime = new StartTime(request.getStartTime());
this.clientDriverDispatcher.get().dispatch(startTime);
@@ -190,7 +190,7 @@
@Override
public void alarmTrigger(final AlarmTriggerInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Alarm Trigger id {0}", request.getAlarmId());
this.clientDriverDispatcher.get().dispatchAlarm(request.getAlarmId());
}
@@ -198,7 +198,7 @@
@Override
public void allocatedEvaluatorHandler(final EvaluatorInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
synchronized (this.lock) {
assert this.outstandingEvaluatorCount > 0;
this.outstandingEvaluatorCount--;
@@ -215,7 +215,7 @@
@Override
public void completedEvaluatorHandler(final EvaluatorInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Completed Evaluator id {0}", request.getEvaluatorId());
this.evaluatorBridgeMap.remove(request.getEvaluatorId());
this.clientDriverDispatcher.get().dispatch(new CompletedEvaluatorBridge(request.getEvaluatorId()));
@@ -224,7 +224,7 @@
@Override
public void failedEvaluatorHandler(final EvaluatorInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
if (!this.evaluatorBridgeMap.containsKey(request.getEvaluatorId())) {
LOG.log(Level.INFO, "Failed evalautor that we were not allocated");
synchronized (this.lock) {
@@ -271,7 +271,7 @@
@Override
public void activeContextHandler(final ContextInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Active context id {0}", request.getContextId());
final AllocatedEvaluatorBridge eval = this.evaluatorBridgeMap.get(request.getEvaluatorId());
final ActiveContextBridge context = new ActiveContextBridge(
@@ -289,7 +289,7 @@
public void closedContextHandler(final ContextInfo request, final StreamObserver<Void> responseObserver) {
if (this.activeContextBridgeMap.containsKey(request.getContextId())) {
LOG.log(Level.INFO, "Closed context id {0}", request.getContextId());
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
final ActiveContextBridge context = this.activeContextBridgeMap.remove(request.getContextId());
this.clientDriverDispatcher.get().dispatch(
new ClosedContextBridge(
@@ -309,7 +309,7 @@
public void failedContextHandler(final ContextInfo request, final StreamObserver<Void> responseObserver) {
if (this.activeContextBridgeMap.containsKey(request.getContextId())) {
LOG.log(Level.INFO, "Failed context id {0}", request.getContextId());
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
final ActiveContextBridge context = this.activeContextBridgeMap.remove(request.getContextId());
final Optional<ActiveContext> parent =
Optional.<ActiveContext>ofNullable(this.activeContextBridgeMap.get(context.getParentId().get()));
@@ -336,7 +336,7 @@
public void contextMessageHandler(final ContextMessageInfo request, final StreamObserver<Void> responseObserver) {
if (this.activeContextBridgeMap.containsKey(request.getContextId())) {
LOG.log(Level.INFO, "Message context id {0}", request.getContextId());
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().dispatch(
new ContextMessageBridge(
request.getContextId(),
@@ -354,7 +354,7 @@
@Override
public void runningTaskHandler(final TaskInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Running task id {0}", request.getTaskId());
final ContextInfo contextInfo = request.getContext();
final ActiveContextBridge context = addContextIfMissing(contextInfo);
@@ -365,7 +365,7 @@
@Override
public void failedTaskHandler(final TaskInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Failed task id {0}", request.getTaskId());
ActiveContextBridge context = request.hasContext() ?
addContextIfMissing(request.getContext()) : null;
@@ -384,7 +384,7 @@
@Override
public void completedTaskHandler(final TaskInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Completed task id {0}", request.getTaskId());
final ContextInfo contextInfo = request.getContext();
ActiveContextBridge context = addContextIfMissing(contextInfo);
@@ -398,7 +398,7 @@
@Override
public void suspendedTaskHandler(final TaskInfo request, final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Suspended task id {0}", request.getTaskId());
final ContextInfo contextInfo = request.getContext();
ActiveContextBridge context = addContextIfMissing(contextInfo);
@@ -414,7 +414,7 @@
public void taskMessageHandler(final TaskMessageInfo request, final StreamObserver<Void> responseObserver) {
if (this.activeContextBridgeMap.containsKey(request.getContextId())) {
LOG.log(Level.INFO, "Message task id {0}", request.getTaskId());
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().dispatch(
new TaskMessageBridge(
request.getTaskId(),
@@ -434,7 +434,7 @@
@Override
public void clientMessageHandler(final ClientMessageInfo request, final StreamObserver<Void> responseObserver) {
LOG.log(Level.INFO, "Client message");
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().clientMessageDispatch(request.getPayload().toByteArray());
}
}
@@ -442,7 +442,7 @@
@Override
public void clientCloseHandler(final Void request, final StreamObserver<Void> responseObserver) {
LOG.log(Level.INFO, "Client close");
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().clientCloseDispatch();
}
}
@@ -452,7 +452,7 @@
final ClientMessageInfo request,
final StreamObserver<Void> responseObserver) {
LOG.log(Level.INFO, "Client close with message");
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().clientCloseWithMessageDispatch(request.getPayload().toByteArray());
}
}
@@ -460,7 +460,7 @@
@Override
public void driverRestartHandler(final DriverRestartInfo request, final StreamObserver<Void> responseObserver) {
LOG.log(Level.INFO, "Driver restarted");
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
final DriverRestarted driverRestarted = new DriverRestarted() {
@Override
public int getResubmissionAttempts() {
@@ -485,7 +485,7 @@
public void driverRestartActiveContextHandler(
final ContextInfo request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Driver restarted active context {0}", request.getContextId());
if (!this.evaluatorBridgeMap.containsKey(request.getEvaluatorId())) {
final AllocatedEvaluatorBridge eval = new AllocatedEvaluatorBridge(
@@ -503,7 +503,7 @@
public void driverRestartRunningTaskHandler(
final TaskInfo request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "Driver restarted running task {0}", request.getTaskId());
if (!this.evaluatorBridgeMap.containsKey(request.getContext().getEvaluatorId())) {
final AllocatedEvaluatorBridge eval = new AllocatedEvaluatorBridge(
@@ -522,7 +522,7 @@
public void driverRestartCompletedHandler(
final DriverRestartCompletedInfo request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().dispatchRestart(new DriverRestartCompleted() {
@Override
public Time getCompletedTime() {
@@ -541,7 +541,7 @@
public void driverRestartFailedEvaluatorHandler(
final EvaluatorInfo request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
this.clientDriverDispatcher.get().dispatchRestart(new FailedEvaluatorBridge(
request.getEvaluatorId(),
new EvaluatorException(request.getFailure() != null ?
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/launch/RuntimeConfigurationProvider.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/launch/RuntimeConfigurationProvider.java
index a19c91d..1dcad09 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/launch/RuntimeConfigurationProvider.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/launch/RuntimeConfigurationProvider.java
@@ -32,5 +32,5 @@
* Generate driver runtime configuration with the dynamic {@link ClientProtocol.DriverClientConfiguration}.
* @param driverClientConfiguration dynamic driver configuration parameters
*/
- Configuration getRuntimeConfiguration(final ClientProtocol.DriverClientConfiguration driverClientConfiguration);
+ Configuration getRuntimeConfiguration(ClientProtocol.DriverClientConfiguration driverClientConfiguration);
}
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverService.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverService.java
index 4a7f6bd..46ca02b 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverService.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverService.java
@@ -42,121 +42,121 @@
* Driver restart handler.
* @param restart event
*/
- void driverRestarted(final DriverRestarted restart);
+ void driverRestarted(DriverRestarted restart);
/**
* Restart running task.
* @param task running
*/
- void restartRunningTask(final RunningTask task);
+ void restartRunningTask(RunningTask task);
/**
* Restart active context.
* @param context restart
*/
- void restartActiveContext(final ActiveContext context);
+ void restartActiveContext(ActiveContext context);
/**
* Driver restart completed.
* @param restartCompleted event
*/
- void driverRestartCompleted(final DriverRestartCompleted restartCompleted);
+ void driverRestartCompleted(DriverRestartCompleted restartCompleted);
/**
* Failed to restart evaluator.
* @param evaluator that failed.
*/
- void restartFailedEvalautor(final FailedEvaluator evaluator);
+ void restartFailedEvalautor(FailedEvaluator evaluator);
/**
* Handle start time event.
* @param startTime event
*/
- void startHandler(final StartTime startTime);
+ void startHandler(StartTime startTime);
/**
* Handle stop event.
* @param stopTime event
*/
- void stopHandler(final StopTime stopTime);
+ void stopHandler(StopTime stopTime);
/**
* Handle allocated evaluator event.
* @param eval allocated
*/
- void allocatedEvaluatorHandler(final AllocatedEvaluator eval);
+ void allocatedEvaluatorHandler(AllocatedEvaluator eval);
/**
* Handle completed evaluator event.
* @param eval that completed
*/
- void completedEvaluatorHandler(final CompletedEvaluator eval);
+ void completedEvaluatorHandler(CompletedEvaluator eval);
/**
* Handle failed evaluator event.
* @param eval that failed
*/
- void failedEvaluatorHandler(final FailedEvaluator eval);
+ void failedEvaluatorHandler(FailedEvaluator eval);
/**
* Handle active context.
* @param context activated
*/
- void activeContextHandler(final ActiveContext context);
+ void activeContextHandler(ActiveContext context);
/**
* Handle closed context event.
* @param context that closed
*/
- void closedContextHandler(final ClosedContext context);
+ void closedContextHandler(ClosedContext context);
/**
* Handle context message event.
* @param message sent by context
*/
- void contextMessageHandler(final ContextMessage message);
+ void contextMessageHandler(ContextMessage message);
/**
* Handled failed context event.
* @param context that failed
*/
- void failedContextHandler(final FailedContext context);
+ void failedContextHandler(FailedContext context);
/**
* Handle running task event.
* @param task that is now running
*/
- void runningTaskHandler(final RunningTask task);
+ void runningTaskHandler(RunningTask task);
/**
* Handle failed task event.
* @param task that failed
*/
- void failedTaskHandler(final FailedTask task);
+ void failedTaskHandler(FailedTask task);
/**
* Handle completed task event.
* @param task that completed
*/
- void completedTaskHandler(final CompletedTask task);
+ void completedTaskHandler(CompletedTask task);
/**
* Handle suspended task event.
* @param task that is suspended
*/
- void suspendedTaskHandler(final SuspendedTask task);
+ void suspendedTaskHandler(SuspendedTask task);
/**
* Handle task message event.
* @param message sent by task
*/
- void taskMessageHandler(final TaskMessage message);
+ void taskMessageHandler(TaskMessage message);
/**
* Handle client message event.
* @param message sent by client
*/
- void clientMessageHandler(final byte[] message);
+ void clientMessageHandler(byte[] message);
/**
* Handle client close event.
@@ -167,5 +167,5 @@
* Handle client close event with message.
* @param message sent by client
*/
- void clientCloseWithMessageHandler(final byte[] message);
+ void clientCloseWithMessageHandler(byte[] message);
}
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverServiceConfigurationProvider.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverServiceConfigurationProvider.java
index 88a2038..2d6a5fd 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverServiceConfigurationProvider.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverServiceConfigurationProvider.java
@@ -32,5 +32,5 @@
@DefaultImplementation(GRPCDriverServiceConfigurationProvider.class)
public interface DriverServiceConfigurationProvider {
- Configuration getDriverServiceConfiguration(final ClientProtocol.DriverClientConfiguration driverClientConfiguration);
+ Configuration getDriverServiceConfiguration(ClientProtocol.DriverClientConfiguration driverClientConfiguration);
}
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverStatusHTTPHandler.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverStatusHTTPHandler.java
index 2336eff..581315e 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverStatusHTTPHandler.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/DriverStatusHTTPHandler.java
@@ -119,7 +119,7 @@
@Override
public void onHttpRequest(final ParsedHttpRequest parsedHttpRequest, final HttpServletResponse response)
throws IOException, ServletException {
- try (final PrintWriter writer = response.getWriter()) {
+ try (PrintWriter writer = response.getWriter()) {
writer.write(waitAndGetMessage());
this.wasCalledViaHTTP = true;
}
diff --git a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/grpc/GRPCDriverService.java b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/grpc/GRPCDriverService.java
index 75106b8..87e403d 100644
--- a/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/grpc/GRPCDriverService.java
+++ b/lang/java/reef-bridge-proto-java/src/main/java/org/apache/reef/bridge/driver/service/grpc/GRPCDriverService.java
@@ -256,7 +256,7 @@
LOG.log(Level.INFO, "capturing driver process {0}", name);
try {
stringBuilder.append("\n==============================================\n");
- try (final BufferedReader reader = new BufferedReader(new InputStreamReader(stream))) {
+ try (BufferedReader reader = new BufferedReader(new InputStreamReader(stream))) {
while (reader.ready()) {
stringBuilder.append(reader.readLine()).append('\n');
}
@@ -727,7 +727,7 @@
final StreamObserver<Void> responseObserver) {
LOG.log(Level.INFO, "driver client register");
synchronized (GRPCDriverService.this) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
if (request.hasException()) {
LOG.log(Level.SEVERE, "Driver client initialization exception");
final Optional<Throwable> optionalEx = parseException(request.getException());
@@ -759,7 +759,7 @@
public void requestResources(
final ResourceRequest request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
synchronized (GRPCDriverService.this) {
EvaluatorRequest.Builder requestBuilder = GRPCDriverService.this.evaluatorRequestor.newRequest();
requestBuilder.setNumber(request.getResourceCount());
@@ -784,7 +784,7 @@
public void shutdown(
final ShutdownRequest request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "driver shutdown");
if (request.hasException()) {
final Optional<Throwable> exception = parseException(request.getException());
@@ -809,7 +809,7 @@
public void setAlarm(
final AlarmRequest request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
// do not synchronize when scheduling an alarm (or deadlock)
LOG.log(Level.INFO, "Set alarm {0} offset {1}",
new Object[] {request.getAlarmId(), request.getTimeoutMs()});
@@ -834,7 +834,7 @@
public void allocatedEvaluatorOp(
final AllocatedEvaluatorRequest request,
final StreamObserver<Void> responseObserver) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
synchronized (GRPCDriverService.this) {
final AllocatedEvaluator evaluator =
GRPCDriverService.this.allocatedEvaluatorMap.get(request.getEvaluatorId());
@@ -955,7 +955,7 @@
switch (request.getOperationCase()) {
case CLOSE_CONTEXT:
if (request.getCloseContext()) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "closing context {0}", context.getId());
context.close();
}
@@ -968,7 +968,7 @@
break;
case MESSAGE:
if (request.getMessage() != null) {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "send message to context {0}", context.getId());
context.sendMessage(request.getMessage().toByteArray());
}
@@ -978,13 +978,13 @@
}
break;
case NEW_CONTEXT_REQUEST:
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "submitting child context to context {0}", context.getId());
((EvaluatorContext) context).submitContext(request.getNewContextRequest());
}
break;
case NEW_TASK_REQUEST:
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
LOG.log(Level.INFO, "submitting task to context {0}", context.getId());
((EvaluatorContext) context).submitTask(request.getNewTaskRequest());
}
@@ -1005,7 +1005,7 @@
responseObserver.onError(Status.INTERNAL
.withDescription("Task does not exist with id " + request.getTaskId()).asRuntimeException());
} else {
- try (final ObserverCleanup _cleanup = ObserverCleanup.of(responseObserver)) {
+ try (ObserverCleanup cleanup = ObserverCleanup.of(responseObserver)) {
final RunningTask task = GRPCDriverService.this.runningTaskMap.get(request.getTaskId());
switch (request.getOperation()) {
case CLOSE:
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
index 3adc031..69bcd72 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/REEF.java
@@ -51,5 +51,5 @@
*
* @param driverConf The driver configuration: including everything it needs to execute. @see DriverConfiguration
*/
- void submit(final Configuration driverConf);
+ void submit(Configuration driverConf);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
index a3fe5ba..4d58f17 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/client/RunningJob.java
@@ -45,7 +45,7 @@
*
* @param message delivered along with cancel request.
*/
- void close(final byte[] message);
+ void close(byte[] message);
/**
* @return the ID of the running job.
@@ -58,5 +58,5 @@
*
* @param message to send to the running driver
*/
- void send(final byte[] message);
+ void send(byte[] message);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
index cb0581a..844d5ca 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextAndTaskSubmittable.java
@@ -42,7 +42,7 @@
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
* @param taskConfiguration the Configuration of the Task. See TaskConfiguration for details.
*/
- void submitContextAndTask(final Configuration contextConfiguration, final Configuration taskConfiguration);
+ void submitContextAndTask(Configuration contextConfiguration, Configuration taskConfiguration);
/**
* Submit a Context with Services and a Task.
@@ -57,8 +57,8 @@
* @param serviceConfiguration
* @param taskConfiguration
*/
- void submitContextAndServiceAndTask(final Configuration contextConfiguration,
- final Configuration serviceConfiguration,
- final Configuration taskConfiguration);
+ void submitContextAndServiceAndTask(Configuration contextConfiguration,
+ Configuration serviceConfiguration,
+ Configuration taskConfiguration);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
index dd730e4..4e542e6 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/ContextSubmittable.java
@@ -36,7 +36,7 @@
*
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
*/
- void submitContext(final Configuration contextConfiguration);
+ void submitContext(Configuration contextConfiguration);
/**
* Submit a Context and a Service Configuration.
@@ -44,6 +44,6 @@
* @param contextConfiguration the Configuration of the EvaluatorContext. See ContextConfiguration for details.
* @param serviceConfiguration the Configuration for the Services. See ServiceConfiguration for details.
*/
- void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
+ void submitContextAndService(Configuration contextConfiguration, Configuration serviceConfiguration);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
index 0f826df..4cdc9ef 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/TaskSubmittable.java
@@ -36,5 +36,5 @@
*
* @param taskConf the Configuration. See TaskConfiguration for details
*/
- void submitTask(final Configuration taskConf);
+ void submitTask(Configuration taskConf);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
index 57296f8..7419522 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/client/JobMessageObserver.java
@@ -39,6 +39,6 @@
*
* @param message a message to be sent to the client
*/
- void sendMessageToClient(final byte[] message);
+ void sendMessageToClient(byte[] message);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
index 7bc031e..3cb9abb 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/context/ActiveContext.java
@@ -52,13 +52,13 @@
void close();
@Override
- void submitTask(final Configuration taskConf);
+ void submitTask(Configuration taskConf);
@Override
- void submitContext(final Configuration contextConfiguration);
+ void submitContext(Configuration contextConfiguration);
@Override
- void submitContextAndService(final Configuration contextConfiguration, final Configuration serviceConfiguration);
+ void submitContextAndService(Configuration contextConfiguration, Configuration serviceConfiguration);
/**
* Send the active context the message, which will be delivered to all registered
@@ -66,6 +66,6 @@
*
* @param message The message to be sent.
*/
- void sendMessage(final byte[] message);
+ void sendMessage(byte[] message);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java
index 5d18c0d..55d7815 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/AllocatedEvaluator.java
@@ -43,14 +43,14 @@
*
* @param file the file to be copied
*/
- void addFile(final File file);
+ void addFile(File file);
/**
* Puts the given file into the working directory of the Evaluator and adds it to its classpath.
*
* @param file the file to be copied
*/
- void addLibrary(final File file);
+ void addLibrary(File file);
/**
* @return the evaluator descriptor of this evaluator.
@@ -63,7 +63,7 @@
*
* @param process
*/
- void setProcess(final EvaluatorProcess process);
+ void setProcess(EvaluatorProcess process);
/**
* Releases the allocated evaluator back to the resource manager.
@@ -79,21 +79,21 @@
* @param taskConfiguration the Configuration. See TaskConfiguration for details.
*/
@Override
- void submitTask(final Configuration taskConfiguration);
+ void submitTask(Configuration taskConfiguration);
@Override
- void submitContext(final Configuration contextConfiguration);
+ void submitContext(Configuration contextConfiguration);
@Override
- void submitContextAndService(final Configuration contextConfiguration,
- final Configuration serviceConfiguration);
+ void submitContextAndService(Configuration contextConfiguration,
+ Configuration serviceConfiguration);
@Override
- void submitContextAndTask(final Configuration contextConfiguration,
- final Configuration taskConfiguration);
+ void submitContextAndTask(Configuration contextConfiguration,
+ Configuration taskConfiguration);
@Override
- void submitContextAndServiceAndTask(final Configuration contextConfiguration,
- final Configuration serviceConfiguration,
- final Configuration taskConfiguration);
+ void submitContextAndServiceAndTask(Configuration contextConfiguration,
+ Configuration serviceConfiguration,
+ Configuration taskConfiguration);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorProcess.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorProcess.java
index ef6096a..f52602a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorProcess.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorProcess.java
@@ -43,7 +43,7 @@
* @param megaBytes
* @return this
*/
- EvaluatorProcess setMemory(final int megaBytes);
+ EvaluatorProcess setMemory(int megaBytes);
/**
* Check whether custom options have been set for the process.
@@ -61,7 +61,7 @@
* @param configurationFileName
* @return this
*/
- EvaluatorProcess setConfigurationFileName(final String configurationFileName);
+ EvaluatorProcess setConfigurationFileName(String configurationFileName);
/**
* Names a file to which stdout will be redirected.
@@ -69,7 +69,7 @@
* @param standardOut
* @return this
*/
- EvaluatorProcess setStandardOut(final String standardOut);
+ EvaluatorProcess setStandardOut(String standardOut);
/**
* Names a file to which stderr will be redirected.
@@ -77,5 +77,5 @@
* @param standardErr
* @return this
*/
- EvaluatorProcess setStandardErr(final String standardErr);
+ EvaluatorProcess setStandardErr(String standardErr);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
index 684553e..2ca030a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/evaluator/EvaluatorRequestor.java
@@ -34,7 +34,7 @@
* Submit the request for new evaluator.
* The response will surface in the AllocatedEvaluator message handler.
*/
- void submit(final EvaluatorRequest req);
+ void submit(EvaluatorRequest req);
/**
* Get a new Builder for the evaluator with fluid interface.
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/restart/DriverRuntimeRestartManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/restart/DriverRuntimeRestartManager.java
index 161b212..c062f26 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/restart/DriverRuntimeRestartManager.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/restart/DriverRuntimeRestartManager.java
@@ -49,13 +49,13 @@
* Records the evaluators when it is allocated.
* @param id The evaluator ID of the allocated evaluator.
*/
- void recordAllocatedEvaluator(final String id);
+ void recordAllocatedEvaluator(String id);
/**
* Records a removed evaluator into the evaluator log.
* @param id The evaluator ID of the removed evaluator.
*/
- void recordRemovedEvaluator(final String id);
+ void recordRemovedEvaluator(String id);
/**
* Gets the sets of alive and failed evaluators based on the runtime implementation.
@@ -67,5 +67,5 @@
* Informs the necessary components about failed evaluators. The implementation is runtime dependent.
* @param failedEvaluatorIds The set of evaluator IDs of evaluators that failed during restart.
*/
- void informAboutEvaluatorFailures(final Set<String> failedEvaluatorIds);
+ void informAboutEvaluatorFailures(Set<String> failedEvaluatorIds);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
index 1453cf7..c21cd6b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/driver/task/RunningTask.java
@@ -45,14 +45,14 @@
*
* @param message to be sent to the running task
*/
- void send(final byte[] message);
+ void send(byte[] message);
/**
* Signal the task to suspend.
*
* @param message a message that is sent to the Task.
*/
- void suspend(final byte[] message);
+ void suspend(byte[] message);
/**
* Signal the task to suspend.
@@ -64,7 +64,7 @@
*
* @param message a message that is sent to the Task.
*/
- void close(final byte[] message);
+ void close(byte[] message);
/**
* Signal the task to shut down.
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
index 8d4b460..3a2dce2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/evaluator/context/ContextMessageHandler.java
@@ -35,5 +35,5 @@
* @param message sent by the driver to this context
*/
@Override
- void onNext(final byte[] message);
+ void onNext(byte[] message);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulator.java
index 80af34d..eac614b 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/Accumulator.java
@@ -38,7 +38,7 @@
* @param datum the datum to be added
* @throws ServiceException
*/
- void add(final T datum) throws ServiceException;
+ void add(T datum) throws ServiceException;
@Override
void close() throws ServiceException;
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
index b71a9af..d68f14c 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/ExternalMap.java
@@ -36,7 +36,7 @@
* @param key
* @return true, if an entry with the given key exists
*/
- boolean containsKey(final CharSequence key);
+ boolean containsKey(CharSequence key);
/**
* Element access.
@@ -44,7 +44,7 @@
* @param key
* @return the object stored under key nor null if no such object exists
*/
- T get(final CharSequence key);
+ T get(CharSequence key);
/**
* Put a record into the map.
@@ -55,7 +55,7 @@
* mapping for key. (A null return can also indicate that the map previously
* associated null with key, if the implementation supports null values.)
*/
- T put(final CharSequence key, final T value);
+ T put(CharSequence key, T value);
/**
* Removes the mapping for a key from this map if it is present (optional
@@ -76,7 +76,7 @@
* @return the previous value associated with key, or null if there was no
* mapping for key.
*/
- T remove(final CharSequence key);
+ T remove(CharSequence key);
/**
* Copies all of the mappings from the specified map to this map (optional
@@ -87,7 +87,7 @@
*
* @param m
*/
- void putAll(final Map<? extends CharSequence, ? extends T> m);
+ void putAll(Map<? extends CharSequence, ? extends T> m);
Iterable<Map.Entry<CharSequence, T>> getAll(Set<? extends CharSequence> keys);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
index d6bc95a..2e0e808 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/TempFileCreator.java
@@ -39,7 +39,7 @@
* @return the created file.
* @throws IOException
*/
- File createTempFile(final String prefix, final String suffix) throws IOException;
+ File createTempFile(String prefix, String suffix) throws IOException;
/**
* Creates a temporary folder.
@@ -49,7 +49,7 @@
* @return the created folder.
* @throws IOException
*/
- File createTempDirectory(final String prefix, final FileAttribute<?> attrs) throws IOException;
+ File createTempDirectory(String prefix, FileAttribute<?> attrs) throws IOException;
/**
@@ -59,7 +59,7 @@
* @return the created folder
* @throws IOException
*/
- File createTempDirectory(final String prefix) throws IOException;
+ File createTempDirectory(String prefix) throws IOException;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
index 0ab4525..f882f65 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingLookup.java
@@ -37,6 +37,6 @@
* @return the Inet address
* @throws java.io.IOException
*/
- InetSocketAddress lookup(final Identifier id) throws Exception;
+ InetSocketAddress lookup(Identifier id) throws Exception;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
index 5600b21..3e81b93 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/naming/NamingRegistry.java
@@ -34,7 +34,7 @@
* @param addr
* @throws Exception
*/
- void register(final Identifier id, final InetSocketAddress addr) throws Exception;
+ void register(Identifier id, InetSocketAddress addr) throws Exception;
/**
* Unregister the given Identifier from the registry.
@@ -42,5 +42,5 @@
* @param id
* @throws Exception
*/
- void unregister(final Identifier id) throws Exception;
+ void unregister(Identifier id) throws Exception;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/SerializableCodec.java b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/SerializableCodec.java
index e0ea1c9..5f6c94c 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/SerializableCodec.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/io/serialization/SerializableCodec.java
@@ -42,8 +42,8 @@
@Override
public byte[] encode(final T obj) {
- try (final ByteArrayOutputStream bout = new ByteArrayOutputStream()) {
- try (final ObjectOutputStream out = new ObjectOutputStream(bout)) {
+ try (ByteArrayOutputStream bout = new ByteArrayOutputStream()) {
+ try (ObjectOutputStream out = new ObjectOutputStream(bout)) {
out.writeObject(obj);
}
return bout.toByteArray();
@@ -55,7 +55,7 @@
@Override
public T decode(final byte[] buf) {
try {
- try (final ObjectInputStream oin = new ObjectInputStream(new ByteArrayInputStream(buf))) {
+ try (ObjectInputStream oin = new ObjectInputStream(new ByteArrayInputStream(buf))) {
final T result = (T) oin.readObject();
return result;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
index c8a124a..348d789 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/REEFLauncher.java
@@ -177,7 +177,7 @@
Thread.setDefaultUncaughtExceptionHandler(new REEFUncaughtExceptionHandler(launcher.envConfig));
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(launcher.envConfig)) {
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(launcher.envConfig)) {
reef.run();
} catch (final Throwable ex) {
throw fatal("Unable to configure and start REEFEnvironment.", ex);
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/UserCredentials.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/UserCredentials.java
index 6bac1ef..1dc2ea2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/UserCredentials.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/UserCredentials.java
@@ -44,7 +44,7 @@
* @param other Credentials of another user.
* @throws IOException if unable to copy.
*/
- void set(final String name, final UserCredentials other) throws IOException;
+ void set(String name, UserCredentials other) throws IOException;
/**
* Check if the user credentials had been set.
@@ -60,5 +60,5 @@
* @return result of an action.
* @throws Exception whatever the action can throw.
*/
- <T> T doAs(final PrivilegedExceptionAction<T> action) throws Exception;
+ <T> T doAs(PrivilegedExceptionAction<T> action) throws Exception;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/DriverConfigurationProvider.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/DriverConfigurationProvider.java
index d764461..4fb1e1f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/DriverConfigurationProvider.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/DriverConfigurationProvider.java
@@ -35,8 +35,8 @@
* @return Generated driver configuration.
*/
Configuration getDriverConfiguration(
- final URI jobFolder,
- final String clientRemoteId,
- final String jobId,
- final Configuration applicationConfiguration);
+ URI jobFolder,
+ String clientRemoteId,
+ String jobId,
+ Configuration applicationConfiguration);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
index 9f439ba..0965fe9 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/JobSubmissionHelper.java
@@ -180,7 +180,7 @@
final File tempFolder = Files.createTempDirectory("reef-tmp-tempFolder").toFile();
final File jarFile = File.createTempFile(file.getCanonicalFile().getName(), ".jar", tempFolder);
LOG.log(Level.FINEST, "Adding contents of folder {0} to {1}", new Object[]{file, jarFile});
- try (final JARFileMaker jarMaker = new JARFileMaker(jarFile)) {
+ try (JARFileMaker jarMaker = new JARFileMaker(jarFile)) {
jarMaker.addChildren(file);
}
return jarFile;
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
index e640528..e42b68a 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/client/RunningJobs.java
@@ -43,13 +43,13 @@
*
* @param message
*/
- void onJobStatusMessage(final RemoteMessage<ReefServiceProtos.JobStatusProto> message);
+ void onJobStatusMessage(RemoteMessage<ReefServiceProtos.JobStatusProto> message);
/**
* Processes a error message from the resource manager.
*
* @param runtimeFailure
*/
- void onRuntimeErrorMessage(final RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure);
+ void onRuntimeErrorMessage(RemoteMessage<ReefServiceProtos.RuntimeErrorProto> runtimeFailure);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/EvaluatorPreserver.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/EvaluatorPreserver.java
index 5c51d3c..f590331 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/EvaluatorPreserver.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/EvaluatorPreserver.java
@@ -41,11 +41,11 @@
/**
* Called when an evaluator is to be preserved.
*/
- void recordAllocatedEvaluator(final String id);
+ void recordAllocatedEvaluator(String id);
/**
* Called when an evaluator is to be removed.
* @param id
*/
- void recordRemovedEvaluator(final String id);
+ void recordRemovedEvaluator(String id);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
index 2702fc6..d61d040 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/AllocatedEvaluatorImpl.java
@@ -221,7 +221,7 @@
private void launch(final Configuration contextConfiguration,
final Optional<Configuration> serviceConfiguration,
final Optional<Configuration> taskConfiguration) {
- try (final LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) {
+ try (LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) {
final Configuration evaluatorConfiguration =
makeEvaluatorConfiguration(contextConfiguration, serviceConfiguration, taskConfiguration);
@@ -243,7 +243,7 @@
final String contextConfiguration,
final Optional<String> serviceConfiguration,
final Optional<String> taskConfiguration) {
- try (final LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) {
+ try (LoggingScope lb = loggingScopeFactory.evaluatorLaunch(this.getId())) {
final Configuration submissionEvaluatorConfiguration =
makeEvaluatorConfiguration(
contextConfiguration,
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilder.java
index 5f76369..94476b7 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilder.java
@@ -33,33 +33,33 @@
* @param nodeDescriptor for this evaluator
* @return this
*/
- EvaluatorDescriptorBuilder setNodeDescriptor(final NodeDescriptor nodeDescriptor);
+ EvaluatorDescriptorBuilder setNodeDescriptor(NodeDescriptor nodeDescriptor);
/**
* Amount of memory dedicated to this evaluator.
* @param megaBytes of dedicated memory
* @return this
*/
- EvaluatorDescriptorBuilder setMemory(final int megaBytes);
+ EvaluatorDescriptorBuilder setMemory(int megaBytes);
/**
* Set the number of cores.
* @param numberOfCores dedicated for this evaluator
* @return this
*/
- EvaluatorDescriptorBuilder setNumberOfCores(final int numberOfCores);
+ EvaluatorDescriptorBuilder setNumberOfCores(int numberOfCores);
/**
* The process used to run this evaluator.
* @param evaluatorProcess for this evaluator
* @return this
*/
- EvaluatorDescriptorBuilder setEvaluatorProcess(final EvaluatorProcess evaluatorProcess);
+ EvaluatorDescriptorBuilder setEvaluatorProcess(EvaluatorProcess evaluatorProcess);
/**
* The runtime name for this evaluator.
* @param runtimeName for this evaluator
* @return this
*/
- EvaluatorDescriptorBuilder setRuntimeName(final String runtimeName);
+ EvaluatorDescriptorBuilder setRuntimeName(String runtimeName);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilderFactory.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilderFactory.java
index 54932c2..0a63624 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilderFactory.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorBuilderFactory.java
@@ -38,5 +38,5 @@
* @param copy to initialize builder
* @return evaluator descriptor builder initialized to copy
*/
- EvaluatorDescriptorBuilder newBuilder(final EvaluatorDescriptor copy);
+ EvaluatorDescriptorBuilder newBuilder(EvaluatorDescriptor copy);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
index 6db2bec..667aa7f 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
@@ -32,7 +32,7 @@
@Private
final class FailedEvaluatorImpl implements FailedEvaluator {
- final String id;
+ private final String id;
private final EvaluatorException ex;
private final List<FailedContext> ctx;
private final Optional<FailedTask> task;
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/PIDStoreStartHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/PIDStoreStartHandler.java
index 03091a9..cd429aa 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/PIDStoreStartHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/PIDStoreStartHandler.java
@@ -62,7 +62,7 @@
final long pid = OSUtils.getPID();
final File outfile = new File(PID_FILE_NAME);
LOG.log(Level.FINEST, "Storing pid `" + pid + "` in file " + outfile.getAbsolutePath());
- try (final PrintWriter p = new PrintWriter(PID_FILE_NAME, "UTF-8")) {
+ try (PrintWriter p = new PrintWriter(PID_FILE_NAME, "UTF-8")) {
p.write(String.valueOf(pid));
p.write("\n");
} catch (final FileNotFoundException | UnsupportedEncodingException e) {
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/JavaLaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/JavaLaunchCommandBuilder.java
index 5f81a5d..eafc775 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/JavaLaunchCommandBuilder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/JavaLaunchCommandBuilder.java
@@ -241,9 +241,9 @@
static final Pattern EQUALS = Pattern.compile("(.+)=(.+)");
static final Pattern MEMORY = Pattern.compile("(\\-Xm[nsx])(.+)");
- public final String option;
- public final String value;
- public final String separator;
+ final String option;
+ final String value;
+ final String separator;
private JVMOption(final String option, final String value,
final String separator) {
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
index 396c9c8..318d5c2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
@@ -36,7 +36,7 @@
* @param megaBytes
* @return this
*/
- LaunchCommandBuilder setMemory(final int megaBytes);
+ LaunchCommandBuilder setMemory(int megaBytes);
/**
* Set the name of the configuration file for the Launcher. This file is assumed to exist in the working directory of
@@ -45,7 +45,7 @@
* @param configurationFilePaths
* @return this
*/
- LaunchCommandBuilder setConfigurationFilePaths(final List<String> configurationFilePaths);
+ LaunchCommandBuilder setConfigurationFilePaths(List<String> configurationFilePaths);
/**
* Names a file to which stdout will be redirected.
@@ -53,7 +53,7 @@
* @param standardOut
* @return this
*/
- LaunchCommandBuilder setStandardOut(final String standardOut);
+ LaunchCommandBuilder setStandardOut(String standardOut);
/**
* Names a file to which stderr will be redirected.
@@ -61,7 +61,7 @@
* @param standardErr
* @return this
*/
- LaunchCommandBuilder setStandardErr(final String standardErr);
+ LaunchCommandBuilder setStandardErr(String standardErr);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/ProfilingStopHandler.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/ProfilingStopHandler.java
index d64f891..31ad648 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/ProfilingStopHandler.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/ProfilingStopHandler.java
@@ -50,7 +50,7 @@
@Override
public void onNext(final StopTime stopTime) {
- try (final PrintWriter out = new PrintWriter("profile-" + launchID + ".json", "UTF-8")) {
+ try (PrintWriter out = new PrintWriter("profile-" + launchID + ".json", "UTF-8")) {
out.print(profiler.objectGraphToString());
} catch (final FileNotFoundException | UnsupportedEncodingException e) {
LOG.log(Level.WARNING, "Unable to write the profile", e);
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
index 7a239f4..0971d39 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/ExceptionCodec.java
@@ -33,18 +33,18 @@
* @param bytes
* @return the Throwable or Optional.empty() if the deserialization fails.
*/
- Optional<Throwable> fromBytes(final byte[] bytes);
+ Optional<Throwable> fromBytes(byte[] bytes);
/**
* @param bytes
* @return fromBytes(bytes.get()) or Optional.empty()
*/
- Optional<Throwable> fromBytes(final Optional<byte[]> bytes);
+ Optional<Throwable> fromBytes(Optional<byte[]> bytes);
/**
* @param throwable
* @return the serialized form of the given Throwable.
*/
- byte[] toBytes(final Throwable throwable);
+ byte[] toBytes(Throwable throwable);
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
index d9ef02e..4e76fd0 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/task/Task.java
@@ -42,5 +42,5 @@
* @throws Exception whenever the Task encounters an unsolved issue.
* This Exception will be thrown at the Driver's event handler.
*/
- byte[] call(final byte[] memento) throws Exception;
+ byte[] call(byte[] memento) throws Exception;
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
index 1b8cf2b..f887ea7 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/CommandUtils.java
@@ -40,7 +40,7 @@
final String cmd = OSUtils.isWindows() ? "cmd.exe /c " + command : command;
final Process proc = Runtime.getRuntime().exec(cmd);
- try (final BufferedReader input =
+ try (BufferedReader input =
new BufferedReader(new InputStreamReader(proc.getInputStream(), StandardCharsets.UTF_8))) {
String line;
while ((line = input.readLine()) != null) {
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/JARFileMaker.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/JARFileMaker.java
index c235ec3..37b6646 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/JARFileMaker.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/JARFileMaker.java
@@ -79,7 +79,7 @@
this.add(nestedFile, fileNameInJAR);
}
} else {
- try (final BufferedInputStream in = new BufferedInputStream(new FileInputStream(inputFile))) {
+ try (BufferedInputStream in = new BufferedInputStream(new FileInputStream(inputFile))) {
IOUtils.copy(in, this.jarOutputStream);
} catch (final FileNotFoundException ex) {
LOG.log(Level.WARNING, "Skip the file: " + inputFile, ex);
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/OSUtils.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/OSUtils.java
index 2c1a1db..c1d9048 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/OSUtils.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/OSUtils.java
@@ -85,7 +85,7 @@
if (exitCode != 0) {
LOG.log(Level.SEVERE, "Unable to determine PID. Exit code = {0}", exitCode);
final StringBuilder errorMsg = new StringBuilder();
- try (final BufferedReader reader = new BufferedReader(
+ try (BufferedReader reader = new BufferedReader(
new InputStreamReader(process.getErrorStream(), StandardCharsets.UTF_8))) {
for (int i = 0; i < 10 && reader.ready(); ++i) { // Read the first 10 lines from stderr
errorMsg.append(reader.readLine()).append('\n');
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
index 46942fd..bee1b53 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/REEFVersion.java
@@ -68,7 +68,7 @@
private static String loadVersion() {
String version;
- try (final InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream(FILENAME)) {
+ try (InputStream is = Thread.currentThread().getContextClassLoader().getResourceAsStream(FILENAME)) {
if (is == null) {
throw new IOException(FILENAME + " not found");
}
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
index fc43d85..44adcdd 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/LogParser.java
@@ -68,7 +68,7 @@
final String removeBeforeToken,
final String removeAfterToken) throws IOException{
final ArrayList<String> filteredLines = new ArrayList<>();
- try (final BufferedReader in = new BufferedReader(
+ try (BufferedReader in = new BufferedReader(
new InputStreamReader(new FileInputStream(fileName), StandardCharsets.UTF_8))) {
String line = "";
while ((line = in.readLine()) != null) {
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/ThreadLogFormatter.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/ThreadLogFormatter.java
index c6f8ab0..607d073 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/ThreadLogFormatter.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/logging/ThreadLogFormatter.java
@@ -126,8 +126,8 @@
*/
private String getStackTrace(final Throwable error) {
if (error != null) {
- try (final StringWriter sw = new StringWriter();
- final PrintWriter pw = new PrintWriter(sw)) {
+ try (StringWriter sw = new StringWriter();
+ PrintWriter pw = new PrintWriter(sw)) {
pw.println();
error.printStackTrace(pw);
return sw.toString();
diff --git a/lang/java/reef-common/src/test/java/org/apache/reef/util/LoggingScopeTest.java b/lang/java/reef-common/src/test/java/org/apache/reef/util/LoggingScopeTest.java
index 628ae23..b855e59 100644
--- a/lang/java/reef-common/src/test/java/org/apache/reef/util/LoggingScopeTest.java
+++ b/lang/java/reef-common/src/test/java/org/apache/reef/util/LoggingScopeTest.java
@@ -51,7 +51,7 @@
*/
@Test
public void testGetNewLoggingScope() throws InjectionException {
- try (final LoggingScope ls = logFactory.getNewLoggingScope("test")) {
+ try (LoggingScope ls = logFactory.getNewLoggingScope("test")) {
Assert.assertTrue(true);
}
}
@@ -62,7 +62,7 @@
*/
@Test
public void testGetNewLoggingScopeWithParam() throws InjectionException {
- try (final LoggingScope ls = logFactory.getNewLoggingScope("test first string = {0}, second = {1}",
+ try (LoggingScope ls = logFactory.getNewLoggingScope("test first string = {0}, second = {1}",
new Object[] {"first", "second"})) {
Assert.assertTrue(true);
}
@@ -75,7 +75,7 @@
*/
@Test
public void testLoggingScopeFactory() {
- try (final LoggingScope ls = logFactory.activeContextReceived("test")) {
+ try (LoggingScope ls = logFactory.activeContextReceived("test")) {
Assert.assertTrue(true);
}
}
@@ -89,7 +89,7 @@
final Injector i = Tang.Factory.getTang().newInjector(Tang.Factory.getTang().newConfigurationBuilder().build());
final LoggingScopeFactory localLogFactory = i.getInstance(LoggingScopeFactory.class);
- try (final LoggingScope ls = localLogFactory.activeContextReceived("test")) {
+ try (LoggingScope ls = localLogFactory.activeContextReceived("test")) {
Assert.assertTrue(true);
}
}
diff --git a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
index fdb18d9..4a233d6 100644
--- a/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
+++ b/lang/java/reef-examples-clr/src/main/java/org/apache/reef/examples/helloCLR/HelloDriver.java
@@ -96,7 +96,7 @@
*/
private static ClassHierarchy loadClassHierarchy() {
// TODO[JIRA REEF-400] The file should be created by AvroClassHierarchySerializer
- try (final InputStream chin = new FileInputStream(HelloCLR.CLASS_HIERARCHY_FILENAME)) {
+ try (InputStream chin = new FileInputStream(HelloCLR.CLASS_HIERARCHY_FILENAME)) {
// TODO[JIRA REEF-400] Use AvroClassHierarchySerializer instead
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin); // A
final ClassHierarchy ch = new ProtocolBufferClassHierarchy(root);
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/output/OutputServiceTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/output/OutputServiceTask.java
index b9ae0ea..98dcfc0 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/output/OutputServiceTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/data/output/OutputServiceTask.java
@@ -56,7 +56,7 @@
*/
@Override
public byte[] call(final byte[] memento) throws IOException {
- try (final DataOutputStream outputStream = outputStreamProvider.create("hello")) {
+ try (DataOutputStream outputStream = outputStreamProvider.create("hello")) {
outputStream.writeBytes("Hello REEF!");
}
return null;
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/MasterTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/MasterTask.java
index 490201a..3c5cbb1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/MasterTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/MasterTask.java
@@ -100,7 +100,7 @@
double gradientNorm = Double.MAX_VALUE;
for (int iteration = 1; !converged(iteration, gradientNorm); ++iteration) {
- try (final Timer t = new Timer("Current Iteration(" + iteration + ")")) {
+ try (Timer t = new Timer("Current Iteration(" + iteration + ")")) {
final Pair<Double, Vector> lossAndGradient = computeLossAndGradient();
losses.add(lossAndGradient.getFirst());
final Vector descentDirection = getDescentDirection(lossAndGradient.getSecond());
@@ -120,7 +120,7 @@
}
private void updateModel(final Vector descentDirection) throws NetworkException, InterruptedException {
- try (final Timer t = new Timer("GetDescentDirection + FindMinEta + UpdateModel")) {
+ try (Timer t = new Timer("GetDescentDirection + FindMinEta + UpdateModel")) {
final Vector lineSearchEvals = lineSearch(descentDirection);
minEta = findMinEta(model, descentDirection, lineSearchEvals);
model.multAdd(minEta, descentDirection);
@@ -133,7 +133,7 @@
Vector lineSearchResults = null;
boolean allDead = false;
do {
- try (final Timer t = new Timer("LineSearch - Broadcast("
+ try (Timer t = new Timer("LineSearch - Broadcast("
+ (sendModel ? "ModelAndDescentDirection" : "DescentDirection") + ") + Reduce(LossEvalsInLineSearch)")) {
if (sendModel) {
LOG.log(Level.INFO, "OUT: DoLineSearchWithModel");
@@ -166,7 +166,7 @@
Pair<Double, Vector> returnValue = null;
boolean allDead = false;
do {
- try (final Timer t = new Timer("Broadcast(" + (sendModel ? "Model" : "MinEta") + ") + Reduce(LossAndGradient)")) {
+ try (Timer t = new Timer("Broadcast(" + (sendModel ? "Model" : "MinEta") + ") + Reduce(LossAndGradient)")) {
if (sendModel) {
LOG.log(Level.INFO, "OUT: ComputeGradientWithModel");
controlMessageBroadcaster.send(ControlMessages.ComputeGradientWithModel);
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
index c0f92c1..a365f7d 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/Parser.java
@@ -27,6 +27,6 @@
*/
public interface Parser<T> {
- Example parse(final T input);
+ Example parse(T input);
}
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/SVMLightParser.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/SVMLightParser.java
index 1ff0e04..398ab01 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/SVMLightParser.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/data/parser/SVMLightParser.java
@@ -76,7 +76,7 @@
for (int i = 0; i < 10; i++) {
final List<SparseExample> examples = new ArrayList<>();
float avgFtLen = 0;
- try (final BufferedReader br = new BufferedReader(new InputStreamReader(
+ try (BufferedReader br = new BufferedReader(new InputStreamReader(
new FileInputStream("C:\\Users\\shravan\\data\\splice\\hdi\\hdi_uncomp\\part-r-0000" + i),
StandardCharsets.UTF_8))) {
String line;
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/LossFunction.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/LossFunction.java
index 019693c..91c7b0c 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/LossFunction.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/bgd/loss/LossFunction.java
@@ -33,7 +33,7 @@
* @param f the prediction
* @return the loss incurred by predicting f, if y is the true label.
*/
- double computeLoss(final double y, final double f);
+ double computeLoss(double y, double f);
/**
* Computes the gradient with respect to f, if y is the true label.
@@ -42,5 +42,5 @@
* @param f the prediction
* @return the gradient with respect to f
*/
- double computeGradient(final double y, final double f);
+ double computeGradient(double y, double f);
}
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/AbstractImmutableVector.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/AbstractImmutableVector.java
index 090fa39..283d749 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/AbstractImmutableVector.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/AbstractImmutableVector.java
@@ -70,7 +70,7 @@
@Override
public String toString() {
final StringBuilder b = new StringBuilder("DenseVector(");
- try (final Formatter formatter = new Formatter(b, Locale.US)) {
+ try (Formatter formatter = new Formatter(b, Locale.US)) {
final int size = Math.min(25, this.size());
for (int i = 0; i < size; ++i) {
if (i < size - 1) {
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
index b5e86ba..25fa083 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/group/utils/math/Vector.java
@@ -31,14 +31,14 @@
* @param i the index
* @param v value
*/
- void set(final int i, final double v);
+ void set(int i, double v);
/**
* Adds the Vector that to this one in place: this += that.
*
* @param that
*/
- void add(final Vector that);
+ void add(Vector that);
/**
* this += factor * that.
@@ -46,14 +46,14 @@
* @param factor
* @param that
*/
- void multAdd(final double factor, final ImmutableVector that);
+ void multAdd(double factor, ImmutableVector that);
/**
* Scales this Vector: this *= factor.
*
* @param factor the scaling factor.
*/
- void scale(final double factor);
+ void scale(double factor);
/**
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFEnvironment.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFEnvironment.java
index ab9c424..e5eb633 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFEnvironment.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFEnvironment.java
@@ -71,7 +71,7 @@
*/
public static void main(final String[] args) throws InjectionException {
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(
LOCAL_DRIVER_MODULE, DRIVER_CONFIG, ENVIRONMENT_CONFIG)) {
reef.run();
final ReefServiceProtos.JobStatusProto status = reef.getLastStatus();
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFYarnUnmanagedAM.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFYarnUnmanagedAM.java
index cfdd81f..aad9316 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFYarnUnmanagedAM.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloREEFYarnUnmanagedAM.java
@@ -62,7 +62,7 @@
LOG.log(Level.FINE, "Launching Unmanaged AM: {0}", JAR_PATH);
- try (final DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
+ try (DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
final String appId = client.submit(DRIVER_CONFIG, 10000);
LOG.log(Level.INFO, "Job submitted: {0}", appId);
@@ -72,7 +72,7 @@
.set(UnmanagedAmYarnDriverConfiguration.JOB_SUBMISSION_DIRECTORY, DRIVER_ROOT_PATH)
.build();
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(yarnAmConfig, DRIVER_CONFIG)) {
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(yarnAmConfig, DRIVER_CONFIG)) {
reef.run();
final ReefServiceProtos.JobStatusProto status = reef.getLastStatus();
LOG.log(Level.INFO, "REEF job {0} completed: state {1}", new Object[] {appId, status.getState()});
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefAzBatch.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefAzBatch.java
index fc6c661..769792f 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefAzBatch.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hello/HelloReefAzBatch.java
@@ -78,7 +78,7 @@
injector.getInstance(AzureBatchRuntimeConfigurationProvider.class);
final Configuration driverConfiguration = getDriverConfiguration();
- try (final REEF reef = Tang.Factory.getTang().newInjector(
+ try (REEF reef = Tang.Factory.getTang().newInjector(
runtimeConfigurationProvider.getAzureBatchRuntimeConfiguration()).getInstance(REEF.class)) {
reef.submit(driverConfiguration);
}
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/reefonreef/ReefOnReefDriver.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/reefonreef/ReefOnReefDriver.java
index a509399..11fc81b 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/reefonreef/ReefOnReefDriver.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/reefonreef/ReefOnReefDriver.java
@@ -74,7 +74,7 @@
LOG.log(Level.INFO, "Driver started: app {0} :: {1}", new Object[] {this.hostApplicationId, startTime});
LOG.log(Level.FINE, "Launching Unmanaged AM: {0}", JAR_PATH);
- try (final DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
+ try (DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
final String innerApplicationId = client.submit(DRIVER_CONFIG, 10000);
LOG.log(Level.INFO, "REEF-on-REEF job submitted: host app {0} new app {1}",
@@ -85,7 +85,7 @@
.set(UnmanagedAmYarnDriverConfiguration.JOB_SUBMISSION_DIRECTORY, DRIVER_ROOT_PATH)
.build();
- try (final REEFEnvironment reef =
+ try (REEFEnvironment reef =
REEFEnvironment.fromConfiguration(client.getUser(), yarnAmConfig, DRIVER_CONFIG)) {
reef.run();
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEF.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEF.java
index 688d339..0f2e922 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEF.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEF.java
@@ -89,7 +89,7 @@
* @throws java.io.IOException
*/
public static void runTaskScheduler(final Configuration runtimeConf, final String[] args)
- throws InjectionException, IOException, ParseException {
+ throws InjectionException, IOException, ParseException {
final Tang tang = Tang.Factory.getTang();
final Configuration commandLineConf = CommandLine.parseToConfiguration(args, Retain.class);
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEFYarn.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEFYarn.java
index 1ed252a..a589cb6 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEFYarn.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/client/SchedulerREEFYarn.java
@@ -38,7 +38,7 @@
* @throws java.io.IOException
*/
public static void main(final String[] args)
- throws InjectionException, IOException, ParseException {
+ throws InjectionException, IOException, ParseException {
final Configuration runtimeConfiguration =
YarnClientConfiguration.CONF.build();
runTaskScheduler(runtimeConfiguration, args);
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/Control.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/Control.java
index aa6e20c..1407f9f 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/Control.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/Control.java
@@ -93,7 +93,7 @@
}
});
- try (final Transport transport = tpFactory.newInstance("localhost", 0, stage, stage, 1, 10000)) {
+ try (Transport transport = tpFactory.newInstance("localhost", 0, stage, stage, 1, 10000)) {
final Link link = transport.open(new InetSocketAddress("localhost", this.port), codec, null);
link.write(this.command + " " + this.taskId);
}
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
index 0c5f657..91cbcb4 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/ObjectWritableCodec.java
@@ -61,8 +61,8 @@
*/
@Override
public byte[] encode(final T writable) {
- try (final ByteArrayOutputStream bos = new ByteArrayOutputStream();
- final DataOutputStream dos = new DataOutputStream(bos)) {
+ try (ByteArrayOutputStream bos = new ByteArrayOutputStream();
+ DataOutputStream dos = new DataOutputStream(bos)) {
writable.write(dos);
return bos.toByteArray();
} catch (final IOException ex) {
@@ -80,8 +80,8 @@
*/
@Override
public T decode(final byte[] buffer) {
- try (final ByteArrayInputStream bis = new ByteArrayInputStream(buffer);
- final DataInputStream dis = new DataInputStream(bis)) {
+ try (ByteArrayInputStream bis = new ByteArrayInputStream(buffer);
+ DataInputStream dis = new DataInputStream(bis)) {
final T writable = this.writableClass.newInstance();
writable.readFields(dis);
return writable;
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
index 8c667d7..e677cc1 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/suspend/SuspendTestTask.java
@@ -144,7 +144,7 @@
* @return checkpoint ID (serialized)
*/
private synchronized byte[] save() throws IOException, InterruptedException {
- try (final CheckpointWriteChannel channel = this.checkpointService.create()) {
+ try (CheckpointWriteChannel channel = this.checkpointService.create()) {
channel.write(ByteBuffer.wrap(this.codecInt.encode(this.counter)));
return this.codecCheckpoint.encode(this.checkpointService.commit(channel));
}
@@ -157,7 +157,7 @@
*/
private synchronized void restore(final byte[] memento) throws IOException, InterruptedException {
final CheckpointID checkpointId = this.codecCheckpoint.decode(memento);
- try (final CheckpointReadChannel channel = this.checkpointService.open(checkpointId)) {
+ try (CheckpointReadChannel channel = this.checkpointService.open(checkpointId)) {
final ByteBuffer buffer = ByteBuffer.wrap(this.codecInt.encode(this.counter));
channel.read(buffer);
this.counter = this.codecInt.decode(buffer.array());
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingRequestBuilder.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingRequestBuilder.java
index bb587f3..5f2128f 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingRequestBuilder.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingRequestBuilder.java
@@ -258,7 +258,7 @@
}
jcb.bindNamedParameter(LoadDataIntoMemory.class, Boolean.toString(this.inMemory))
- .bindNamedParameter(JobConfExternalConstructor.InputFormatClass.class, inputFormatClass);
+ .bindNamedParameter(JobConfExternalConstructor.InputFormatClass.class, inputFormatClass);
final Iterator<DistributedDataSetPartition> partitions = this.distributedDataSet.iterator();
while (partitions.hasNext()) {
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingService.java
index 33186e7..66c5b6e 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DataLoadingService.java
@@ -39,12 +39,12 @@
/**
* @return the context configuration for the given Evaluator.
*/
- Configuration getContextConfiguration(final AllocatedEvaluator allocatedEvaluator);
+ Configuration getContextConfiguration(AllocatedEvaluator allocatedEvaluator);
/**
* @return the service configuration for the given Evaluator.
*/
- Configuration getServiceConfiguration(final AllocatedEvaluator allocatedEvaluator);
+ Configuration getServiceConfiguration(AllocatedEvaluator allocatedEvaluator);
/**
* @return Return the prefix to be used to enumerate
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AbstractEvaluatorToPartitionStrategy.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AbstractEvaluatorToPartitionStrategy.java
index 77f9216..7bda1f3 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AbstractEvaluatorToPartitionStrategy.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AbstractEvaluatorToPartitionStrategy.java
@@ -132,7 +132,7 @@
* @param numberedSplit
* the numberedSplit
*/
- protected abstract void updateLocations(final NumberedSplit<InputSplit> numberedSplit);
+ protected abstract void updateLocations(NumberedSplit<InputSplit> numberedSplit);
/**
* Tries to allocate a split in an evaluator based on some particular rule.
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AvroEvaluatorRequestSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AvroEvaluatorRequestSerializer.java
index ae9ff19..db0941c 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AvroEvaluatorRequestSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/AvroEvaluatorRequestSerializer.java
@@ -76,7 +76,7 @@
public static String toString(final EvaluatorRequest request) {
AvroEvaluatorRequest avroRequest = toAvro(request);
final DatumWriter<AvroEvaluatorRequest> datumWriter = new SpecificDatumWriter<>(AvroEvaluatorRequest.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(avroRequest.getSchema(), out);
datumWriter.write(avroRequest, encoder);
encoder.flush();
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
index 579cffd..a88387f 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
@@ -80,7 +80,7 @@
@Override
public byte[] encode(final E writable) {
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
- try (final DataOutputStream daos = new DataOutputStream(baos)) {
+ try (DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeUTF(writable.getClass().getName());
writable.write(daos);
return baos.toByteArray();
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/output/OutputStreamProvider.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/output/OutputStreamProvider.java
index b44660e..a7cb967 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/output/OutputStreamProvider.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/output/OutputStreamProvider.java
@@ -34,7 +34,7 @@
* @return created output stream
* @throws java.io.IOException
*/
- DataOutputStream create(final String name) throws IOException;
+ DataOutputStream create(String name) throws IOException;
/**
* release resources.
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
index 594bf77..52844df 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/NetworkConnectionService.java
@@ -66,25 +66,25 @@
* @param localEndPointId a local end point id
* @return the registered connection factory
*/
- <T> ConnectionFactory<T> registerConnectionFactory(final Identifier connectionFactoryId,
- final Codec<T> codec,
- final EventHandler<Message<T>> eventHandler,
- final LinkListener<Message<T>> linkListener,
- final Identifier localEndPointId);
+ <T> ConnectionFactory<T> registerConnectionFactory(Identifier connectionFactoryId,
+ Codec<T> codec,
+ EventHandler<Message<T>> eventHandler,
+ LinkListener<Message<T>> linkListener,
+ Identifier localEndPointId);
/**
* Unregisters a connectionFactory corresponding to the connectionFactoryId
* and removes the localEndPointID of the connection factory from NameServer.
* @param connectionFactoryId a connection factory id
*/
- void unregisterConnectionFactory(final Identifier connectionFactoryId);
+ void unregisterConnectionFactory(Identifier connectionFactoryId);
/**
* Gets an instance of ConnectionFactory which is registered by the registerConnectionFactory method.
*
* @param connectionFactoryId a connection factory id
*/
- <T> ConnectionFactory<T> getConnectionFactory(final Identifier connectionFactoryId);
+ <T> ConnectionFactory<T> getConnectionFactory(Identifier connectionFactoryId);
/**
* Closes all resources and unregisters all registered connection factories.
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
index 7c025d2..60300fc 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/api/driver/TaskNodeStatus.java
@@ -55,7 +55,7 @@
* As this is called from the TaskNodeImpl use srcId of msg
* In TaskNodeImpl while processMsg use dstId of msg
*/
- void expectAckFor(final Type msgType, final String srcId);
+ void expectAckFor(Type msgType, String srcId);
/**
* Used when the task has failed to clear all.
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/TopologySerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/TopologySerializer.java
index f019703..2e2b019 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/TopologySerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/driver/TopologySerializer.java
@@ -45,8 +45,8 @@
* @return encoded byte array
*/
public static byte[] encode(final TaskNode root) {
- try (final ByteArrayOutputStream bstream = new ByteArrayOutputStream();
- final DataOutputStream dstream = new DataOutputStream(bstream)) {
+ try (ByteArrayOutputStream bstream = new ByteArrayOutputStream();
+ DataOutputStream dstream = new DataOutputStream(bstream)) {
encodeHelper(dstream, root);
return bstream.toByteArray();
@@ -75,7 +75,7 @@
final byte[] data,
final IdentifierFactory ifac) {
- try (final DataInputStream dstream = new DataInputStream(new ByteArrayInputStream(data))) {
+ try (DataInputStream dstream = new DataInputStream(new ByteArrayInputStream(data))) {
final List<Identifier> activeSlaveTasks = new LinkedList<>();
final TopologySimpleNode retNode = decodeHelper(dstream, activeSlaveTasks, ifac);
return new Pair<>(retNode, activeSlaveTasks);
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherReceiver.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherReceiver.java
index d7033e7..9fa4c88 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherReceiver.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherReceiver.java
@@ -165,8 +165,8 @@
final byte[] gatheredDataFromChildren = topology.recvFromChildren();
LOG.fine("Using " + dataCodec.getClass().getSimpleName() + " as codec.");
- try (final ByteArrayInputStream bstream = new ByteArrayInputStream(gatheredDataFromChildren);
- final DataInputStream dstream = new DataInputStream(bstream)) {
+ try (ByteArrayInputStream bstream = new ByteArrayInputStream(gatheredDataFromChildren);
+ DataInputStream dstream = new DataInputStream(bstream)) {
while (dstream.available() > 0) {
final String identifier = dstream.readUTF();
final int dataLength = dstream.readInt();
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherSender.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherSender.java
index c8cf8ad..f1d19ce 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherSender.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/operators/GatherSender.java
@@ -131,8 +131,8 @@
final byte[] gatheredData = topology.recvFromChildren();
final byte[] encodedMyData = dataCodec.encode(myData);
- try (final ByteArrayOutputStream bstream = new ByteArrayOutputStream();
- final DataOutputStream dstream = new DataOutputStream(bstream)) {
+ try (ByteArrayOutputStream bstream = new ByteArrayOutputStream();
+ DataOutputStream dstream = new DataOutputStream(bstream)) {
dstream.writeUTF(netService.getMyId().toString());
dstream.writeInt(encodedMyData.length);
dstream.write(encodedMyData);
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
index 7be3165..588f0f2 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/NodeStructImpl.java
@@ -98,5 +98,5 @@
return 31 * id.hashCode() + version;
}
- public abstract boolean checkDead(final GroupCommunicationMessage gcm);
+ public abstract boolean checkDead(GroupCommunicationMessage gcm);
}
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterDecoder.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterDecoder.java
index 4c01608..7301817 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterDecoder.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterDecoder.java
@@ -40,7 +40,7 @@
}
public ScatterData decode(final byte[] data) {
- try (final DataInputStream dstream = new DataInputStream(new ByteArrayInputStream(data))) {
+ try (DataInputStream dstream = new DataInputStream(new ByteArrayInputStream(data))) {
final int elementCount = dstream.readInt();
// first read data that I should receive
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterEncoder.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterEncoder.java
index 967dae0..87dfd72 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterEncoder.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/utils/ScatterEncoder.java
@@ -71,8 +71,8 @@
private byte[] encodeScatterMsgForNode(final TopologySimpleNode node,
final Map<String, byte[]> taskIdToBytes) {
- try (final ByteArrayOutputStream bstream = new ByteArrayOutputStream();
- final DataOutputStream dstream = new DataOutputStream(bstream)) {
+ try (ByteArrayOutputStream bstream = new ByteArrayOutputStream();
+ DataOutputStream dstream = new DataOutputStream(bstream)) {
// first write the node's encoded data
final String taskId = node.getTaskId();
@@ -124,8 +124,8 @@
for (int taskOrderIndex = 0; taskOrderIndex < taskOrder.size(); taskOrderIndex++) {
final int elementCount = counts.get(taskOrderIndex);
- try (final ByteArrayOutputStream bstream = new ByteArrayOutputStream();
- final DataOutputStream dstream = new DataOutputStream(bstream)) {
+ try (ByteArrayOutputStream bstream = new ByteArrayOutputStream();
+ DataOutputStream dstream = new DataOutputStream(bstream)) {
dstream.writeInt(elementCount);
for (final T element : elements.subList(elementsIndex, elementsIndex + elementCount)) {
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessageCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessageCodec.java
index 22d6e6e..b7f44f3 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessageCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessageCodec.java
@@ -73,8 +73,8 @@
isStreamingCodecMap.putIfAbsent(codec, isStreamingCodec);
}
- try (final ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
- try (final DataOutputStream daos = new DataOutputStream(baos)) {
+ try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
+ try (DataOutputStream daos = new DataOutputStream(baos)) {
daos.writeUTF(obj.getConnectionFactoryId());
daos.writeUTF(obj.getSrcId().toString());
daos.writeUTF(obj.getDestId().toString());
@@ -107,8 +107,8 @@
*/
@Override
public NetworkConnectionServiceMessage decode(final byte[] data) {
- try (final ByteArrayInputStream bais = new ByteArrayInputStream(data)) {
- try (final DataInputStream dais = new DataInputStream(bais)) {
+ try (ByteArrayInputStream bais = new ByteArrayInputStream(data)) {
+ try (DataInputStream dais = new DataInputStream(bais)) {
final String connFactoryId = dais.readUTF();
final Identifier srcId = factory.getNewInstance(dais.readUTF());
final Identifier destId = factory.getNewInstance(dais.readUTF());
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
index 7b79539..1c592ff 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServer.java
@@ -45,14 +45,14 @@
* @param id an identifier
* @param addr an Internet socket address
*/
- void register(final Identifier id, final InetSocketAddress addr);
+ void register(Identifier id, InetSocketAddress addr);
/**
* Unregisters an identifier locally.
*
* @param id an identifier
*/
- void unregister(final Identifier id);
+ void unregister(Identifier id);
/**
* Finds an address for an identifier locally.
@@ -60,7 +60,7 @@
* @param id an identifier
* @return an Internet socket address
*/
- InetSocketAddress lookup(final Identifier id);
+ InetSocketAddress lookup(Identifier id);
/**
* Finds addresses for identifiers locally.
@@ -68,5 +68,5 @@
* @param identifiers an Iterable of identifiers
* @return a list of name assignments
*/
- List<NameAssignment> lookup(final Iterable<Identifier> identifiers);
+ List<NameAssignment> lookup(Iterable<Identifier> identifiers);
}
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
index 4664057..f901e72 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/serialization/AvroUtils.java
@@ -44,7 +44,7 @@
static <T> byte[] toBytes(final T avroObject, final Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
datumWriter.write(avroObject, encoder);
encoder.flush();
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/ListCodec.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/ListCodec.java
index 1290821..2827a15 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/ListCodec.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/util/ListCodec.java
@@ -49,8 +49,8 @@
@Override
public byte[] encode(final List<T> list) {
- try (final ByteArrayOutputStream baos = new ByteArrayOutputStream();
- final DataOutputStream daos = new DataOutputStream(baos)) {
+ try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ DataOutputStream daos = new DataOutputStream(baos)) {
for (final T t : list) {
final byte[] tBytes = this.codec.encode(t);
daos.writeInt(tBytes.length);
@@ -66,7 +66,7 @@
@Override
public List<T> decode(final byte[] list) {
final List<T> result = new ArrayList<>();
- try (final DataInputStream dais = new DataInputStream(new ByteArrayInputStream(list))) {
+ try (DataInputStream dais = new DataInputStream(new ByteArrayInputStream(list))) {
while (dais.available() > 0) {
final int length = dais.readInt();
final byte[] tBytes = new byte[length];
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkConnectionServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkConnectionServiceTest.java
index e65d904..250c67c 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkConnectionServiceTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkConnectionServiceTest.java
@@ -63,10 +63,10 @@
private void runMessagingNetworkConnectionService(final Codec<String> codec) throws Exception {
final int numMessages = 2000;
final Monitor monitor = new Monitor();
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
messagingTestService.registerTestConnectionFactory(groupCommClientId, numMessages, monitor, codec);
- try (final Connection<String> conn = messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
+ try (Connection<String> conn = messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
try {
conn.open();
for (int count = 0; count < numMessages; ++count) {
@@ -107,7 +107,7 @@
final int groupcommMessages = 1000;
final Monitor monitor = new Monitor();
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
messagingTestService.registerTestConnectionFactory(groupCommClientId, groupcommMessages, monitor, stringCodec);
@@ -118,7 +118,7 @@
executor.submit(new Runnable() {
@Override
public void run() {
- try (final Connection<String> conn =
+ try (Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
conn.open();
for (int count = 0; count < groupcommMessages; ++count) {
@@ -136,7 +136,7 @@
executor.submit(new Runnable() {
@Override
public void run() {
- try (final Connection<Integer> conn =
+ try (Connection<Integer> conn =
messagingTestService.getConnectionFromSenderToReceiver(shuffleClientId)) {
conn.open();
for (int count = 0; count < shuffleMessages; ++count) {
@@ -192,10 +192,10 @@
final int numMessages = 300000 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
messagingTestService.registerTestConnectionFactory(groupCommClientId, numMessages, monitor, codec);
- try (final Connection<String> conn =
+ try (Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
final long start = System.currentTimeMillis();
@@ -244,12 +244,12 @@
e.submit(new Runnable() {
public void run() {
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
messagingTestService.registerTestConnectionFactory(groupCommClientId, numMessages, monitor, codec);
- try (final Connection<String> conn =
+ try (Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
try {
conn.open();
@@ -300,12 +300,12 @@
final int totalNumMessages = numMessages * numThreads;
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
messagingTestService.registerTestConnectionFactory(groupCommClientId, totalNumMessages, monitor, codec);
final ExecutorService e = Executors.newCachedThreadPool();
- try (final Connection<String> conn =
+ try (Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
final long start = System.currentTimeMillis();
@@ -357,9 +357,9 @@
final int numMessages = 300 / (Math.max(1, size / 512));
final Monitor monitor = new Monitor();
final Codec<String> codec = new StringCodec();
- try (final NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
+ try (NetworkMessagingTestService messagingTestService = new NetworkMessagingTestService(localAddress)) {
messagingTestService.registerTestConnectionFactory(groupCommClientId, numMessages, monitor, codec);
- try (final Connection<String> conn =
+ try (Connection<String> conn =
messagingTestService.getConnectionFromSenderToReceiver(groupCommClientId)) {
final long start = System.currentTimeMillis();
try {
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
index 5f16af0..474e6e7 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/NetworkServiceTest.java
@@ -80,7 +80,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
final int numMessages = 10;
@@ -100,7 +100,7 @@
LOG.log(Level.FINEST, "=== Test network service receiver start");
LOG.log(Level.FINEST, "=== Test network service sender start");
- try (final NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
+ try (NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class, factory);
injector2.bindVolatileInstance(NameResolver.class, nameResolver);
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceCodec.class, new StringCodec());
@@ -129,7 +129,7 @@
final Identifier destId = factory.getNewInstance(name2);
- try (final Connection<String> conn = ns1.newConnection(destId)) {
+ try (Connection<String> conn = ns1.newConnection(destId)) {
conn.open();
for (int count = 0; count < numMessages; ++count) {
conn.write("hello! " + count);
@@ -160,7 +160,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
final int[] messageSizes = {1, 16, 32, 64, 512, 64 * 1024, 1024 * 1024};
@@ -183,7 +183,7 @@
LOG.log(Level.FINEST, "=== Test network service receiver start");
LOG.log(Level.FINEST, "=== Test network service sender start");
- try (final NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
+ try (NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class, factory);
injector2.bindVolatileInstance(NameResolver.class, nameResolver);
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceCodec.class, new StringCodec());
@@ -249,7 +249,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
final BlockingQueue<Object> barrier = new LinkedBlockingQueue<>();
@@ -283,7 +283,7 @@
LOG.log(Level.FINEST, "=== Test network service receiver start");
LOG.log(Level.FINEST, "=== Test network service sender start");
- try (final NameResolver nameResolver = injector.getInstance(NameResolver.class)) {
+ try (NameResolver nameResolver = injector.getInstance(NameResolver.class)) {
injector.bindVolatileParameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class, factory);
injector.bindVolatileInstance(NameResolver.class, nameResolver);
injector.bindVolatileParameter(NetworkServiceParameters.NetworkServiceCodec.class, new StringCodec());
@@ -360,7 +360,7 @@
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
final int[] messageSizes = {2000}; // {1,16,32,64,512,64*1024,1024*1024};
@@ -386,7 +386,7 @@
LOG.log(Level.FINEST, "=== Test network service receiver start");
LOG.log(Level.FINEST, "=== Test network service sender start");
- try (final NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
+ try (NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class, factory);
injector2.bindVolatileInstance(NameResolver.class, nameResolver);
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceCodec.class, new StringCodec());
@@ -415,7 +415,7 @@
final Identifier destId = factory.getNewInstance(name2);
- try (final Connection<String> conn = ns1.newConnection(destId)) {
+ try (Connection<String> conn = ns1.newConnection(destId)) {
conn.open();
final String message = StringUtils.repeat('1', size);
@@ -466,7 +466,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int nameServerPort = server.getPort();
final int batchSize = 1024 * 1024;
@@ -490,7 +490,7 @@
LOG.log(Level.FINEST, "=== Test network service receiver start");
LOG.log(Level.FINEST, "=== Test network service sender start");
- try (final NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
+ try (NameResolver nameResolver = injector2.getInstance(NameResolver.class)) {
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceIdentifierFactory.class, factory);
injector2.bindVolatileInstance(NameResolver.class, nameResolver);
injector2.bindVolatileParameter(NetworkServiceParameters.NetworkServiceCodec.class, new StringCodec());
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/LocalNameResolverTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/LocalNameResolverTest.java
index 833b354..1217d97 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/LocalNameResolverTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/LocalNameResolverTest.java
@@ -48,7 +48,7 @@
public final void testClose() throws Exception {
final String localAddress = localAddressProvider.getLocalAddress();
final IdentifierFactory factory = new StringIdentifierFactory();
- try (final NameResolver resolver = Tang.Factory.getTang().newInjector(LocalNameResolverConfiguration.CONF
+ try (NameResolver resolver = Tang.Factory.getTang().newInjector(LocalNameResolverConfiguration.CONF
.set(LocalNameResolverConfiguration.CACHE_TIMEOUT, 10000)
.build()).getInstance(NameResolver.class)) {
final Identifier id = factory.getNewInstance("Task1");
@@ -69,7 +69,7 @@
public final void testLookup() throws Exception {
final IdentifierFactory factory = new StringIdentifierFactory();
final String localAddress = localAddressProvider.getLocalAddress();
- try (final NameResolver resolver = Tang.Factory.getTang().newInjector(LocalNameResolverConfiguration.CONF
+ try (NameResolver resolver = Tang.Factory.getTang().newInjector(LocalNameResolverConfiguration.CONF
.set(LocalNameResolverConfiguration.CACHE_TIMEOUT, 150)
.build()).getInstance(NameResolver.class)) {
final Identifier id = factory.getNewInstance("Task1");
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NameClientTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NameClientTest.java
index f7e5b6d..ff94e9d 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NameClientTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NameClientTest.java
@@ -84,7 +84,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int serverPort = server.getPort();
final Configuration nameResolverConf = NameResolverConfiguration.CONF
.set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress)
@@ -94,7 +94,7 @@
.set(NameResolverConfiguration.RETRY_COUNT, RETRY_COUNT)
.build();
- try (final NameResolver client =
+ try (NameResolver client =
Tang.Factory.getTang().newInjector(nameResolverConf).getInstance(NameClient.class)) {
final Identifier id = factory.getNewInstance("Task1");
client.register(id, new InetSocketAddress(localAddress, 7001));
@@ -119,7 +119,7 @@
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
final int serverPort = server.getPort();
final Configuration nameResolverConf = NameResolverConfiguration.CONF
.set(NameResolverConfiguration.NAME_SERVER_HOSTNAME, localAddress)
@@ -129,7 +129,7 @@
.set(NameResolverConfiguration.RETRY_COUNT, RETRY_COUNT)
.build();
- try (final NameResolver client =
+ try (NameResolver client =
Tang.Factory.getTang().newInjector(nameResolverConf).getInstance(NameClient.class)) {
final Identifier id = factory.getNewInstance("Task1");
client.register(id, new InetSocketAddress(localAddress, 7001));
diff --git a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NamingTest.java b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NamingTest.java
index 4acb6fa..f216277 100644
--- a/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NamingTest.java
+++ b/lang/java/reef-io/src/test/java/org/apache/reef/io/network/naming/NamingTest.java
@@ -94,14 +94,14 @@
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, this.factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
this.port = server.getPort();
for (final Identifier id : idToAddrMap.keySet()) {
server.register(id, idToAddrMap.get(id));
}
// run a client
- try (final NameLookupClient client =
+ try (NameLookupClient client =
getNewNameLookupClient(localAddress, port, TTL, RETRY_COUNT, RETRY_TIMEOUT,
Optional.of(this.localAddressProvider), Optional.of(this.factory))) {
@@ -179,14 +179,14 @@
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, this.factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
this.port = server.getPort();
for (final Identifier id : idToAddrMap.keySet()) {
server.register(id, idToAddrMap.get(id));
}
// run a client
- try (final NameLookupClient client =
+ try (NameLookupClient client =
getNewNameLookupClient(localAddress, port, TTL, RETRY_COUNT, RETRY_TIMEOUT,
Optional.of(this.localAddressProvider), Optional.of(this.factory))) {
final Identifier id1 = this.factory.getNewInstance("task1");
@@ -264,7 +264,7 @@
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, this.factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
this.port = server.getPort();
final String localAddress = localAddressProvider.getLocalAddress();
@@ -275,7 +275,7 @@
// registration
// invoke registration from the client side
- try (final NameRegistryClient client =
+ try (NameRegistryClient client =
new NameRegistryClient(localAddress, this.port, this.factory, this.localAddressProvider)) {
for (final Identifier id : idToAddrMap.keySet()) {
client.register(id, idToAddrMap.get(id));
@@ -330,7 +330,7 @@
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileParameter(NameServerParameters.NameServerIdentifierFactory.class, this.factory);
injector.bindVolatileInstance(LocalAddressProvider.class, this.localAddressProvider);
- try (final NameServer server = injector.getInstance(NameServer.class)) {
+ try (NameServer server = injector.getInstance(NameServer.class)) {
this.port = server.getPort();
final Map<Identifier, InetSocketAddress> idToAddrMap = new HashMap<>();
@@ -347,7 +347,7 @@
.set(NameResolverConfiguration.RETRY_COUNT, RETRY_COUNT)
.build();
- try (final NameResolver client
+ try (NameResolver client
= Tang.Factory.getTang().newInjector(nameResolverConf).getInstance(NameClient.class)) {
for (final Identifier id : idToAddrMap.keySet()) {
client.register(id, idToAddrMap.get(id));
diff --git a/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/command/CommandBuilder.java b/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/command/CommandBuilder.java
index b05e010..78bdd07 100644
--- a/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/command/CommandBuilder.java
+++ b/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/command/CommandBuilder.java
@@ -51,8 +51,8 @@
* @param jvmHeapFactor a multiplicative factor to increase the container memory.
* @return the command string.
*/
- String buildEvaluatorCommand(final ResourceLaunchEvent resourceLaunchEvent,
- final int containerMemory, final double jvmHeapFactor);
+ String buildEvaluatorCommand(ResourceLaunchEvent resourceLaunchEvent,
+ int containerMemory, double jvmHeapFactor);
/**
* Returns the path to a file where the ip address is persisted.
diff --git a/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/storage/ICloudBlobClientProvider.java b/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/storage/ICloudBlobClientProvider.java
index d51dbc2..c1211f4 100644
--- a/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/storage/ICloudBlobClientProvider.java
+++ b/lang/java/reef-runtime-azbatch/src/main/java/org/apache/reef/runtime/azbatch/util/storage/ICloudBlobClientProvider.java
@@ -46,6 +46,6 @@
* @return a Shared Access Key URI for the given {@link CloudBlob}.
* @throws IOException
*/
- URI generateSharedAccessSignature(final CloudBlob cloudBlob, final SharedAccessBlobPolicy policy)
+ URI generateSharedAccessSignature(CloudBlob cloudBlob, SharedAccessBlobPolicy policy)
throws IOException;
}
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java
index 152873b..b665eba 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFetcher.java
@@ -125,7 +125,7 @@
int fileCounter = 0;
for (final ListBlobItem blobItem : logFolder.listBlobs()) {
if (blobItem instanceof CloudBlob) {
- try (final OutputStream outputStream = new FileOutputStream(new File(outputFolder, "File-" + fileCounter))) {
+ try (OutputStream outputStream = new FileOutputStream(new File(outputFolder, "File-" + fileCounter))) {
((CloudBlob) blobItem).download(outputStream);
++fileCounter;
}
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
index d826732..76ebef6 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/LogFileEntry.java
@@ -43,8 +43,8 @@
* @throws IOException
*/
public void write(final Writer outputWriter) throws IOException {
- try (final DataInputStream keyStream = entry.getKeyStream();
- final DataInputStream valueStream = entry.getValueStream();) {
+ try (DataInputStream keyStream = entry.getKeyStream();
+ DataInputStream valueStream = entry.getValueStream()) {
outputWriter.write("Container: ");
outputWriter.write(keyStream.readUTF());
outputWriter.write("\n");
@@ -59,10 +59,10 @@
* @throws IOException
*/
public void write(final File folder) throws IOException {
- try (final DataInputStream keyStream = entry.getKeyStream();
- final DataInputStream valueStream = entry.getValueStream();) {
+ try (DataInputStream keyStream = entry.getKeyStream();
+ DataInputStream valueStream = entry.getValueStream()) {
final String containerId = keyStream.readUTF();
- try (final Writer outputWriter = new OutputStreamWriter(
+ try (Writer outputWriter = new OutputStreamWriter(
new FileOutputStream(new File(folder, containerId + ".txt")), StandardCharsets.UTF_8)) {
this.writeFiles(valueStream, outputWriter);
}
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
index a31193b..ff5640c 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
@@ -50,7 +50,7 @@
* @throws IOException
*/
void parseOneFile(final Path inputPath, final Writer outputWriter) throws IOException {
- try (final TFile.Reader.Scanner scanner = this.getScanner(inputPath)) {
+ try (TFile.Reader.Scanner scanner = this.getScanner(inputPath)) {
while (!scanner.atEnd()) {
new LogFileEntry(scanner.entry()).write(outputWriter);
scanner.advance();
@@ -67,7 +67,7 @@
* @throws IOException
*/
void parseOneFile(final Path inputPath, final File outputFolder) throws IOException {
- try (final TFile.Reader.Scanner scanner = this.getScanner(inputPath)) {
+ try (TFile.Reader.Scanner scanner = this.getScanner(inputPath)) {
while (!scanner.atEnd()) {
new LogFileEntry(scanner.entry()).write(outputFolder);
scanner.advance();
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java
index ba5c233..7f460dd 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/AzureUploader.java
@@ -110,7 +110,7 @@
final CloudBlockBlob jobJarBlob = this.container.getBlockBlobReference(destination);
- try (final BufferedInputStream in = new BufferedInputStream(new FileInputStream(file))) {
+ try (BufferedInputStream in = new BufferedInputStream(new FileInputStream(file))) {
jobJarBlob.upload(in, file.length());
}
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
index da975f3..a71d777 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/client/yarnrest/HDInsightInstance.java
@@ -90,7 +90,7 @@
public ApplicationID getApplicationID() throws IOException {
final String url = "ws/v1/cluster/apps/new-application";
final HttpPost post = preparePost(url);
- try (final CloseableHttpResponse response = this.httpClient.execute(post, this.httpClientContext)) {
+ try (CloseableHttpResponse response = this.httpClient.execute(post, this.httpClientContext)) {
final String message = IOUtils.toString(response.getEntity().getContent());
final ApplicationID result = this.objectMapper.readValue(message, ApplicationID.class);
return result;
@@ -117,7 +117,7 @@
LOG.log(Level.FINE, "Sending:\n{0}", message.replace("\n", "\n\t"));
post.setEntity(new StringEntity(message, ContentType.APPLICATION_JSON));
- try (final CloseableHttpResponse response = this.httpClient.execute(post, this.httpClientContext)) {
+ try (CloseableHttpResponse response = this.httpClient.execute(post, this.httpClientContext)) {
final String responseMessage = IOUtils.toString(response.getEntity().getContent());
LOG.log(Level.FINE, "Response: {0}", responseMessage.replace("\n", "\n\t"));
}
@@ -143,7 +143,7 @@
public ApplicationState getApplication(final String applicationId) throws IOException {
final String url = this.getApplicationURL(applicationId);
final HttpGet get = prepareGet(url);
- try (final CloseableHttpResponse response = this.httpClient.execute(get, this.httpClientContext)) {
+ try (CloseableHttpResponse response = this.httpClient.execute(get, this.httpClientContext)) {
final String message = IOUtils.toString(response.getEntity().getContent());
final ApplicationResponse result = this.objectMapper.readValue(message, ApplicationResponse.class);
return result.getApplicationState();
@@ -153,7 +153,7 @@
public List<ApplicationState> listApplications() throws IOException {
final String url = "ws/v1/cluster/apps";
final HttpGet get = prepareGet(url);
- try (final CloseableHttpResponse response = this.httpClient.execute(get, this.httpClientContext)) {
+ try (CloseableHttpResponse response = this.httpClient.execute(get, this.httpClientContext)) {
final String message = IOUtils.toString(response.getEntity().getContent());
final ListApplicationResponse result = this.objectMapper.readValue(message, ListApplicationResponse.class);
return result.getApplicationStates();
@@ -233,7 +233,7 @@
final HttpGet httpget = new HttpGet("/");
// Prime the cache
- try (final CloseableHttpResponse response = this.httpClient.execute(targetHost, httpget, result)) {
+ try (CloseableHttpResponse response = this.httpClient.execute(targetHost, httpget, result)) {
// empty try block used to automatically close resources
}
return result;
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
index 7a8996e..76967ba 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
@@ -86,7 +86,7 @@
@Override
public void onNext(final JobSubmissionEvent t) {
- try (final LoggingScope lf = loggingScopeFactory.localJobSubmission()) {
+ try (LoggingScope lf = loggingScopeFactory.localJobSubmission()) {
try {
LOG.log(Level.FINEST, "Starting local job {0}", t.getIdentifier());
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
index 84c93de..41db741 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/Container.java
@@ -36,16 +36,16 @@
*
* @param commandLine the command line to execute. It will typically be joined by spaces to form the command line.
*/
- void run(final List<String> commandLine);
+ void run(List<String> commandLine);
/**
* Copies the files to the working directory of the container.
*
* @param files the files to be added to the container.
*/
- void addLocalFiles(final Iterable<File> files);
+ void addLocalFiles(Iterable<File> files);
- void addGlobalFiles(final File globalFolder);
+ void addGlobalFiles(File globalFolder);
/**
* @return true if the Container is currently executing, false otherwise.
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
index fa3e91d..789c0da 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/ResourceManager.java
@@ -161,7 +161,7 @@
final Container c = this.theContainers.get(launchRequest.getIdentifier());
- try (final LoggingScope lb = this.loggingScopeFactory
+ try (LoggingScope lb = this.loggingScopeFactory
.getNewLoggingScope("ResourceManager.onResourceLaunchRequest:evaluatorConfigurationFile")) {
// Add the global files and libraries.
c.addGlobalFiles(this.fileNames.getGlobalFolder());
@@ -177,7 +177,7 @@
}
}
- try (final LoggingScope lc = this.loggingScopeFactory
+ try (LoggingScope lc = this.loggingScopeFactory
.getNewLoggingScope("ResourceManager.onResourceLaunchRequest:runCommand")) {
final List<String> command = getLaunchCommand(launchRequest, c.getMemory());
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcess.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcess.java
index 46b7d9f..0f88a29 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcess.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcess.java
@@ -274,7 +274,7 @@
*/
private long readPID() throws IOException {
final String pidFileName = this.folder.getAbsolutePath() + "/" + PIDStoreStartHandler.PID_FILE_NAME;
- try (final BufferedReader r = new BufferedReader(
+ try (BufferedReader r = new BufferedReader(
new InputStreamReader(new FileInputStream(pidFileName), StandardCharsets.UTF_8))) {
return Long.parseLong(r.readLine());
}
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
index b8a366a..47a8d7c 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/process/RunnableProcessObserver.java
@@ -27,7 +27,7 @@
*
* @param processId the id of the process that started.
*/
- void onProcessStarted(final String processId);
+ void onProcessStarted(String processId);
/**
* This will be called right after the process exited.
@@ -35,5 +35,5 @@
* @param exitCode the return code of the process.
* @param processId the id of the process that exited.
*/
- void onProcessExit(final String processId, final int exitCode);
+ void onProcessExit(String processId, int exitCode);
}
diff --git a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/AutoCompletable.java b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/AutoCompletable.java
index 3ecb0b3..5b08e47 100644
--- a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/AutoCompletable.java
+++ b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/AutoCompletable.java
@@ -36,7 +36,7 @@
* Set auto complete.
* @param value to set
*/
- void setAutoComplete(final boolean value);
+ void setAutoComplete(boolean value);
/**
* @return auto complete process request
diff --git a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockFailure.java b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockFailure.java
index 09ad186..731492a 100644
--- a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockFailure.java
+++ b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockFailure.java
@@ -42,7 +42,7 @@
* Fail an allocated evaluator.
* @param evaluator to be failed
*/
- void fail(final AllocatedEvaluator evaluator);
+ void fail(AllocatedEvaluator evaluator);
/**
* @return current Collection of active contexts
@@ -53,7 +53,7 @@
* Fail an ActiveContext.
* @param context to be failed
*/
- void fail(final ActiveContext context);
+ void fail(ActiveContext context);
/**
* @return current Collection of running tasks
@@ -64,11 +64,11 @@
* Fail a running task.
* @param task to be failed
*/
- void fail(final RunningTask task);
+ void fail(RunningTask task);
/**
* Fail the driver.
* @return the state of the driver at the time of the failure
*/
- MockDriverRestartContext failDriver(final int attempt, final StartTime startTime);
+ MockDriverRestartContext failDriver(int attempt, StartTime startTime);
}
diff --git a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockRuntime.java b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockRuntime.java
index a110ef7..7a051a2 100644
--- a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockRuntime.java
+++ b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockRuntime.java
@@ -48,7 +48,7 @@
* @param isTimeout used to fill in {@link DriverRestartCompleted#isTimedOut()}
* @param duration recover time duration (added to start time)
*/
- void restart(final MockDriverRestartContext restartContext, final boolean isTimeout, final long duration);
+ void restart(MockDriverRestartContext restartContext, boolean isTimeout, long duration);
/**
* @return true if there is an outstanding ProcessRequest
@@ -73,7 +73,7 @@
*
* @param request to be processed successfully
*/
- void succeed(final ProcessRequest request);
+ void succeed(ProcessRequest request);
/**
* The driver will be informed that the operation corresponding
@@ -82,11 +82,11 @@
*
* @param request to be failed.
*/
- void fail(final ProcessRequest request);
+ void fail(ProcessRequest request);
/**
* Publish a context message to the application event handlers.
* @param contextMessage to be published
*/
- void publish(final ContextMessage contextMessage);
+ void publish(ContextMessage contextMessage);
}
diff --git a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockTaskReturnValueProvider.java b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockTaskReturnValueProvider.java
index 6972a18..1d682b3 100644
--- a/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockTaskReturnValueProvider.java
+++ b/lang/java/reef-runtime-mock/src/main/java/org/apache/reef/mock/driver/MockTaskReturnValueProvider.java
@@ -40,5 +40,5 @@
* @param task that is to be provided with a return value
* @return {@link org.apache.reef.task.Task#call(byte[])} return value
*/
- byte[] getReturnValue(final MockRunningTask task);
+ byte[] getReturnValue(MockRunningTask task);
}
diff --git a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGenerator.java b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGenerator.java
index 0deea08..30d15db 100644
--- a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGenerator.java
+++ b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGenerator.java
@@ -41,8 +41,8 @@
* @param jobId the job id
* @return Instance of <code>MultiRuntimeDefinition</code>
*/
- AvroMultiRuntimeDefinition getMultiRuntimeDefinition(final URI jobFolder,
- final String clientRemoteId,
- final String jobId);
+ AvroMultiRuntimeDefinition getMultiRuntimeDefinition(URI jobFolder,
+ String clientRemoteId,
+ String jobId);
}
diff --git a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGeneratorImpl.java b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGeneratorImpl.java
index 7217da7..f0a2e5a 100644
--- a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGeneratorImpl.java
+++ b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/client/MultiRuntimeDefinitionGeneratorImpl.java
@@ -150,8 +150,8 @@
}
private interface ConfigurationModuleBuilder {
- Configuration getConfiguration(final URI jobFolder,
- final String clientRemoteId,
- final String jobId);
+ Configuration getConfiguration(URI jobFolder,
+ String clientRemoteId,
+ String jobId);
}
}
diff --git a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/driver/Runtime.java b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/driver/Runtime.java
index 683f8bc..f6d0aee 100644
--- a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/driver/Runtime.java
+++ b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/driver/Runtime.java
@@ -29,9 +29,9 @@
*/
interface Runtime {
String getRuntimeName();
- void onResourceLaunch(final ResourceLaunchEvent value);
- void onRuntimeStart(final RuntimeStart value);
- void onRuntimeStop(final RuntimeStop value);
- void onResourceRelease(final ResourceReleaseEvent value);
- void onResourceRequest(final ResourceRequestEvent value);
+ void onResourceLaunch(ResourceLaunchEvent value);
+ void onRuntimeStart(RuntimeStart value);
+ void onRuntimeStop(RuntimeStop value);
+ void onResourceRelease(ResourceReleaseEvent value);
+ void onResourceRequest(ResourceRequestEvent value);
}
diff --git a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/utils/MultiRuntimeDefinitionSerializer.java b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/utils/MultiRuntimeDefinitionSerializer.java
index f9ad2dc..bf8b791 100644
--- a/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/utils/MultiRuntimeDefinitionSerializer.java
+++ b/lang/java/reef-runtime-multi/src/main/java/org/apache/reef/runtime/multi/utils/MultiRuntimeDefinitionSerializer.java
@@ -43,7 +43,7 @@
final DatumWriter<AvroMultiRuntimeDefinition> configurationWriter =
new SpecificDatumWriter<>(AvroMultiRuntimeDefinition.class);
final String serializedConfiguration;
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(runtimeDefinition.getSchema(), out);
configurationWriter.write(runtimeDefinition, encoder);
encoder.flush();
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/SecurityTokenProvider.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/SecurityTokenProvider.java
index f91cedf..bacffeb 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/SecurityTokenProvider.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/SecurityTokenProvider.java
@@ -36,5 +36,5 @@
* Add serialized tokens to the credentials.
* @param tokens ByteBuffer containing tokens.
*/
- void addTokens(final byte[] tokens);
+ void addTokens(byte[] tokens);
}
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/UserCredentialSecurityTokenProvider.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/UserCredentialSecurityTokenProvider.java
index 6735550..3237505 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/UserCredentialSecurityTokenProvider.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/UserCredentialSecurityTokenProvider.java
@@ -51,7 +51,7 @@
LOG.log(Level.FINEST, "Got {0} tokens for user {1}", new Object[] {credentials.numberOfTokens(), ugi});
if (credentials.numberOfTokens() > 0) {
- try (final DataOutputBuffer dob = new DataOutputBuffer()) {
+ try (DataOutputBuffer dob = new DataOutputBuffer()) {
credentials.writeTokenStorageToStream(dob);
return dob.getData();
}
@@ -72,7 +72,7 @@
@Override
public void addTokens(final byte[] tokens) {
- try (final DataInputBuffer buf = new DataInputBuffer()) {
+ try (DataInputBuffer buf = new DataInputBuffer()) {
buf.reset(tokens, tokens.length);
final Credentials credentials = new Credentials();
@@ -94,7 +94,7 @@
* @return ByteBuffer that contains the token. It is compatible with addTokens() method.
*/
public static byte[] serializeToken(final Token<AMRMTokenIdentifier> token) {
- try (final DataOutputBuffer dob = new DataOutputBuffer()) {
+ try (DataOutputBuffer dob = new DataOutputBuffer()) {
final Credentials credentials = new Credentials();
credentials.addToken(token.getService(), token);
credentials.writeTokenStorageToStream(dob);
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
index d9f89e6..303d025 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/client/YarnJobSubmissionHandler.java
@@ -104,7 +104,7 @@
LOG.log(Level.FINEST, "Submitting{0} job: {1}",
new Object[] {this.isUnmanaged ? " UNMANAGED AM" : "", jobSubmissionEvent});
- try (final YarnSubmissionHelper submissionHelper = new YarnSubmissionHelper(this.yarnConfiguration,
+ try (YarnSubmissionHelper submissionHelper = new YarnSubmissionHelper(this.yarnConfiguration,
this.fileNames, this.classpath, this.yarnProxyUser, this.tokenProvider, this.isUnmanaged)) {
LOG.log(Level.FINE, "Assembling submission JAR for the Driver.");
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/RackNameFormatter.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/RackNameFormatter.java
index 2825930..caf26e7 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/RackNameFormatter.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/RackNameFormatter.java
@@ -37,5 +37,5 @@
/**
* The rack name of the Container.
*/
- String getRackName(final Container container);
+ String getRackName(Container container);
}
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
index 299af5b..b09b83d 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerManager.java
@@ -345,7 +345,7 @@
final FileSystem fs = FileSystem.get(this.yarnConf);
final Path outputFileName = new Path(this.jobSubmissionDirectory, this.reefFileNames.getDriverHttpEndpoint());
- try (final FSDataOutputStream out = fs.create(outputFileName)) {
+ try (FSDataOutputStream out = fs.create(outputFileName)) {
out.writeBytes(this.trackingUrl + '\n');
}
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerRequestHandler.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerRequestHandler.java
index 359a505..f484da9 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerRequestHandler.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnContainerRequestHandler.java
@@ -31,5 +31,5 @@
*
* @param containerRequests set of container requests
*/
- void onContainerRequest(final AMRMClient.ContainerRequest... containerRequests);
+ void onContainerRequest(AMRMClient.ContainerRequest... containerRequests);
}
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogAppendReaderWriter.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogAppendReaderWriter.java
index d5023e8..9a16105 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogAppendReaderWriter.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogAppendReaderWriter.java
@@ -56,8 +56,7 @@
public synchronized void writeToEvaluatorLog(final String formattedEntry) throws IOException {
final boolean fileCreated = this.fileSystem.exists(this.changelogPath);
- try (
- final BufferedWriter bw = fileCreated ?
+ try (BufferedWriter bw = fileCreated ?
new BufferedWriter(new OutputStreamWriter(
this.fileSystem.append(this.changelogPath), StandardCharsets.UTF_8)) :
new BufferedWriter(new OutputStreamWriter(
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogOverwriteReaderWriter.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogOverwriteReaderWriter.java
index e647ef0..842519b 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogOverwriteReaderWriter.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogOverwriteReaderWriter.java
@@ -69,7 +69,7 @@
// readPath is always not the writePath.
final Path readPath = getAlternativePath(writePath);
- try (final FSDataOutputStream outputStream = this.fileSystem.create(writePath, true)) {
+ try (FSDataOutputStream outputStream = this.fileSystem.create(writePath, true)) {
InputStream inputStream = null;
try {
final InputStream newEntryInputStream = new ByteArrayInputStream(
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogReaderWriter.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogReaderWriter.java
index 2620e94..1d71410 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogReaderWriter.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorLogReaderWriter.java
@@ -35,7 +35,7 @@
* @param formattedEntry The formatted entry (entry with evaluator ID and addition/removal information)
* @throws IOException
*/
- void writeToEvaluatorLog(final String formattedEntry) throws IOException;
+ void writeToEvaluatorLog(String formattedEntry) throws IOException;
/**
* Reads a formatted entry (addition or removal) from the DFS evaluator log.
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorPreserver.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorPreserver.java
index 7be59e8..52f46cf 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorPreserver.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/restart/DFSEvaluatorPreserver.java
@@ -134,7 +134,7 @@
return expectedContainers;
}
- try (final CloseableIterable<String> evaluatorLogIterable = readerWriter.readFromEvaluatorLog()) {
+ try (CloseableIterable<String> evaluatorLogIterable = readerWriter.readFromEvaluatorLog()) {
for (final String line : evaluatorLogIterable) {
if (line.startsWith(ADD_FLAG)) {
final String containerId = line.substring(ADD_FLAG.length());
diff --git a/lang/java/reef-runtime-yarn/src/test/java/org/apache/reef/runtime/yarn/driver/unmanaged/UnmanagedAmTest.java b/lang/java/reef-runtime-yarn/src/test/java/org/apache/reef/runtime/yarn/driver/unmanaged/UnmanagedAmTest.java
index 130f148..a61e19c 100644
--- a/lang/java/reef-runtime-yarn/src/test/java/org/apache/reef/runtime/yarn/driver/unmanaged/UnmanagedAmTest.java
+++ b/lang/java/reef-runtime-yarn/src/test/java/org/apache/reef/runtime/yarn/driver/unmanaged/UnmanagedAmTest.java
@@ -145,7 +145,7 @@
final UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
final Credentials credentials = ugi.getCredentials();
- try (final DataOutputBuffer dob = new DataOutputBuffer()) {
+ try (DataOutputBuffer dob = new DataOutputBuffer()) {
credentials.writeTokenStorageToStream(dob);
return ByteBuffer.wrap(dob.getData());
}
diff --git a/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java b/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
index 428aaac..c58750d 100644
--- a/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
+++ b/lang/java/reef-tang/tang-tint/src/main/java/org/apache/reef/tang/util/Tint.java
@@ -317,7 +317,7 @@
}
if (doc != null) {
- try (final PrintStream out = new PrintStream(doc, "UTF-8")) {
+ try (PrintStream out = new PrintStream(doc, "UTF-8")) {
out.println("<html><head><title>TangDoc</title>");
out.println("<style>");
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchySerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchySerializer.java
index 6ca5d28..74e5794 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchySerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ClassHierarchySerializer.java
@@ -35,7 +35,7 @@
* @param file the file to store the ClassHierarchy
* @throws IOException if there is an error in the process
*/
- void toFile(final ClassHierarchy classHierarchy, final File file) throws IOException;
+ void toFile(ClassHierarchy classHierarchy, File file) throws IOException;
/**
* Writes a ClassHierarchy into a text file.
@@ -44,7 +44,7 @@
* @param file the text file to store the ClassHierarchy
* @throws IOException if there is an error in the process
*/
- void toTextFile(final ClassHierarchy classHierarchy, final File file) throws IOException;
+ void toTextFile(ClassHierarchy classHierarchy, File file) throws IOException;
/**
* Serializes a ClassHierarchy as a byte[].
@@ -53,7 +53,7 @@
* @return the byte array containing the serialized class hierarchy
* @throws IOException if there is an error in the process
*/
- byte[] toByteArray(final ClassHierarchy classHierarchy) throws IOException;
+ byte[] toByteArray(ClassHierarchy classHierarchy) throws IOException;
/**
* Serializes a ClassHierarchy as a String.
@@ -62,7 +62,7 @@
* @return the string containing the serialized class hierarchy
* @throws IOException if there is an error in the process
*/
- String toString(final ClassHierarchy classHierarchy) throws IOException;
+ String toString(ClassHierarchy classHierarchy) throws IOException;
/**
* Loads a ClassHierarchy from a file created with toFile().
@@ -71,7 +71,7 @@
* @return the class hierarchy
* @throws IOException if the File can't be read or parsed
*/
- ClassHierarchy fromFile(final File file) throws IOException;
+ ClassHierarchy fromFile(File file) throws IOException;
/**
* Loads a ClassHierarchy from a text file created with toTextFile().
@@ -80,7 +80,7 @@
* @return the class hierarchy
* @throws IOException if the File can't be read or parsed
*/
- ClassHierarchy fromTextFile(final File file) throws IOException;
+ ClassHierarchy fromTextFile(File file) throws IOException;
/**
* Deserializes a ClassHierarchy from a byte[] created with toByteArray().
@@ -89,7 +89,7 @@
* @return the class hierarchy
* @throws IOException if the byte[] can't be read or parsed
*/
- ClassHierarchy fromByteArray(final byte[] theBytes) throws IOException;
+ ClassHierarchy fromByteArray(byte[] theBytes) throws IOException;
/**
* Deserializes a ClassHierarchy from a String created with toString().
@@ -98,5 +98,5 @@
* @return the class hierarchy
* @throws IOException if the String can't be read or parsed
*/
- ClassHierarchy fromString(final String theString) throws IOException;
+ ClassHierarchy fromString(String theString) throws IOException;
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
index b4a0a63..8606ece 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/ConfigurationBuilder.java
@@ -72,7 +72,7 @@
*
* @param c the configuration to be added
*/
- void addConfiguration(final Configuration c) throws BindException;
+ void addConfiguration(Configuration c) throws BindException;
/**
* Each ConfigurationBuilder instance is associated with a ClassHierarchy.
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
index 1ca2ddc..a3bc19c 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Tang.java
@@ -37,8 +37,7 @@
* @return an injector
* @throws BindException If the confs conflict, a BindException will be thrown.
*/
- Injector newInjector(final Configuration... confs)
- throws BindException;
+ Injector newInjector(Configuration... confs) throws BindException;
/**
* Returns an Injector for the given Configuration.
@@ -46,7 +45,7 @@
* @param confs a configuration
* @return an injector
*/
- Injector newInjector(final Configuration confs);
+ Injector newInjector(Configuration confs);
/**
* Returns an Injector based on an empty Configuration.
@@ -124,9 +123,8 @@
* @param parameterParsers the parsers for parameters
* @return a configuration builder
*/
- JavaConfigurationBuilder newConfigurationBuilder(URL[] jars,
- Configuration[] confs,
- Class<? extends ExternalConstructor<?>>[] parameterParsers)
+ JavaConfigurationBuilder newConfigurationBuilder(
+ URL[] jars, Configuration[] confs, Class<? extends ExternalConstructor<?>>[] parameterParsers)
throws BindException;
/**
@@ -162,7 +160,7 @@
/**
* A factory that returns the default implementation of the Tang interface.
*/
- final class Factory {
+ class Factory {
/**
* Return an instance of the default implementation of Tang.
*
@@ -178,5 +176,4 @@
private Factory() {
}
}
-
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/PrintTypeHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/PrintTypeHierarchy.java
index db4366c..2e99368 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/PrintTypeHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/examples/PrintTypeHierarchy.java
@@ -77,7 +77,7 @@
final Injector injector = tang.newInjector(config);
final PrintTypeHierarchy myself = injector.getInstance(PrintTypeHierarchy.class);
- try (final Writer out = new OutputStreamWriter(
+ try (Writer out = new OutputStreamWriter(
new FileOutputStream("type-hierarchy.dot"), StandardCharsets.UTF_8)) {
out.write(GraphvizConfigVisitor.getGraphvizString(config, true, true));
}
@@ -85,7 +85,7 @@
final InjectionPlan<PrintTypeHierarchy> plan =
injector.getInjectionPlan(PrintTypeHierarchy.class);
- try (final Writer out = new OutputStreamWriter(
+ try (Writer out = new OutputStreamWriter(
new FileOutputStream("injection-plan.dot"), StandardCharsets.UTF_8)) {
out.write(GraphvizInjectionPlanVisitor.getGraphvizString(plan, true));
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
index e40ee20..a60717a 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/AvroConfigurationSerializer.java
@@ -117,7 +117,7 @@
private static AvroConfiguration avroFromFile(final File file) throws IOException {
final AvroConfiguration avroConfiguration;
- try (final DataFileReader<AvroConfiguration> dataFileReader =
+ try (DataFileReader<AvroConfiguration> dataFileReader =
new DataFileReader<>(file, new SpecificDatumReader<>(AvroConfiguration.class))) {
avroConfiguration = dataFileReader.next();
}
@@ -204,7 +204,7 @@
@Override
public void toTextFile(final Configuration conf, final File file) throws IOException {
- try (final Writer w = new OutputStreamWriter(new FileOutputStream(file), JSON_CHARSET)) {
+ try (Writer w = new OutputStreamWriter(new FileOutputStream(file), JSON_CHARSET)) {
w.write(this.toString(conf));
}
}
@@ -213,7 +213,7 @@
public byte[] toByteArray(final Configuration conf) throws IOException {
final DatumWriter<AvroConfiguration> configurationWriter = new SpecificDatumWriter<>(AvroConfiguration.class);
final byte[] theBytes;
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
configurationWriter.write(toAvro(conf), encoder);
encoder.flush();
@@ -243,7 +243,7 @@
public String toString(final Configuration configuration, final boolean prettyPrint) {
final DatumWriter<AvroConfiguration> configurationWriter = new SpecificDatumWriter<>(AvroConfiguration.class);
final String result;
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
// TODO [REEF-1536] Re-enable pretty printing when Avro 1.7.5 available on all environments:
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(AvroConfiguration.SCHEMA$, out); //, prettyPrint);
configurationWriter.write(toAvro(configuration), encoder);
@@ -308,7 +308,7 @@
private StringBuilder readFromTextFile(final File file) throws IOException {
final StringBuilder result = new StringBuilder();
- try (final BufferedReader reader =
+ try (BufferedReader reader =
new BufferedReader(new InputStreamReader(new FileInputStream(file), JSON_CHARSET))) {
String line = reader.readLine();
while (line != null) {
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
index fd4db9d..0465752 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/CommandLine.java
@@ -220,6 +220,6 @@
}
public interface CommandLineCallback {
- void process(final Option option);
+ void process(Option option);
}
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
index 9bbb039..f3d7d0c 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationSerializer.java
@@ -40,7 +40,7 @@
* @param file the file to store the Configuration in
* @throws java.io.IOException if there is an IO error in the process.
*/
- void toFile(final Configuration conf, final File file) throws IOException;
+ void toFile(Configuration conf, File file) throws IOException;
/**
* Stores the given Configuration in the given Text File.
@@ -49,7 +49,7 @@
* @param file the file to store the Configuration in
* @throws java.io.IOException if there is an IO error in the process.
*/
- void toTextFile(final Configuration conf, final File file) throws IOException;
+ void toTextFile(Configuration conf, File file) throws IOException;
/**
* Writes the Configuration to a byte[].
@@ -58,7 +58,7 @@
* @return the byte array
* @throws IOException if encoding fails to write
*/
- byte[] toByteArray(final Configuration conf) throws IOException;
+ byte[] toByteArray(Configuration conf) throws IOException;
/**
* Writes the Configuration as a String.
@@ -66,7 +66,7 @@
* @param configuration the Configuration to be converted
* @return a String representation of the Configuration
*/
- String toString(final Configuration configuration);
+ String toString(Configuration configuration);
/**
@@ -77,7 +77,7 @@
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- Configuration fromFile(final File file) throws IOException, BindException;
+ Configuration fromFile(File file) throws IOException, BindException;
/**
* Loads a Configuration from a File created with toFile().
@@ -87,7 +87,7 @@
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- Configuration fromTextFile(final File file) throws IOException, BindException;
+ Configuration fromTextFile(File file) throws IOException, BindException;
/**
* Loads a Configuration from a File created with toFile() with ClassHierarchy.
@@ -97,7 +97,7 @@
* @return the Configuration stored in the file.
* @throws IOException if the File can't be read or parsed
*/
- Configuration fromTextFile(final File file, final ClassHierarchy classHierarchy) throws IOException;
+ Configuration fromTextFile(File file, ClassHierarchy classHierarchy) throws IOException;
/**
* Loads a Configuration from a File created with toFile().
@@ -108,7 +108,7 @@
* @throws IOException if the File can't be read or parsed
* @throws BindException if the file contains an illegal Configuration
*/
- Configuration fromFile(final File file, final ClassHierarchy classHierarchy) throws IOException, BindException;
+ Configuration fromFile(File file, ClassHierarchy classHierarchy) throws IOException, BindException;
/**
* Loads a Configuration from a byte[] created with toByteArray().
@@ -118,7 +118,7 @@
* @throws IOException if the byte[] can't be deserialized
* @throws BindException if the byte[] contains an illegal Configuration.
*/
- Configuration fromByteArray(final byte[] theBytes) throws IOException, BindException;
+ Configuration fromByteArray(byte[] theBytes) throws IOException, BindException;
/**
* Loads a Configuration from a byte[] created with toByteArray().
@@ -129,7 +129,7 @@
* @throws IOException if the byte[] can't be deserialized
* @throws BindException if the byte[] contains an illegal Configuration.
*/
- Configuration fromByteArray(final byte[] theBytes, final ClassHierarchy classHierarchy)
+ Configuration fromByteArray(byte[] theBytes, ClassHierarchy classHierarchy)
throws IOException, BindException;
/**
@@ -140,7 +140,7 @@
* @throws IOException if theString can't be parsed.
* @throws BindException if theString contains an illegal Configuration.
*/
- Configuration fromString(final String theString) throws IOException, BindException;
+ Configuration fromString(String theString) throws IOException, BindException;
/**
* Decodes a String generated via toString().
@@ -151,6 +151,6 @@
* @throws IOException if theString can't be parsed.
* @throws BindException if theString contains an illegal Configuration.
*/
- Configuration fromString(final String theString, final ClassHierarchy classHierarchy)
+ Configuration fromString(String theString, ClassHierarchy classHierarchy)
throws IOException, BindException;
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
index 1902587..c301340 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/Subplan.java
@@ -23,9 +23,10 @@
import java.util.*;
public final class Subplan<T> extends InjectionPlan<T> {
- final InjectionPlan<? extends T>[] alternatives;
- final int numAlternatives;
- final int selectedIndex;
+
+ private final InjectionPlan<? extends T>[] alternatives;
+ private final int numAlternatives;
+ private final int selectedIndex;
@SafeVarargs
public Subplan(final Node node, final int selectedIndex, final InjectionPlan<T>... alternatives) {
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
index cfea960..85f8bf6 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchySerializer.java
@@ -190,7 +190,7 @@
public void toFile(final ClassHierarchy classHierarchy, final File file) throws IOException {
final AvroNode avroNode = toAvro(classHierarchy);
final DatumWriter<AvroNode> avroNodeWriter = new SpecificDatumWriter<>(AvroNode.class);
- try (final DataFileWriter<AvroNode> dataFileWriter = new DataFileWriter<>(avroNodeWriter)) {
+ try (DataFileWriter<AvroNode> dataFileWriter = new DataFileWriter<>(avroNodeWriter)) {
dataFileWriter.create(avroNode.getSchema(), file);
dataFileWriter.append(avroNode);
}
@@ -199,7 +199,7 @@
@Override
public byte[] toByteArray(final ClassHierarchy classHierarchy) throws IOException {
final DatumWriter<AvroNode> requestWriter = new SpecificDatumWriter<>(AvroNode.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
requestWriter.write(toAvro(classHierarchy), encoder);
encoder.flush();
@@ -210,7 +210,7 @@
@Override
public String toString(final ClassHierarchy classHierarchy) throws IOException {
final DatumWriter<AvroNode> classHierarchyWriter = new SpecificDatumWriter<>(AvroNode.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(AvroNode.SCHEMA$, out);
classHierarchyWriter.write(toAvro(classHierarchy), encoder);
encoder.flush();
@@ -221,7 +221,7 @@
@Override
public void toTextFile(final ClassHierarchy classHierarchy, final File file) throws IOException {
- try (final Writer w = new FileWriter(file)) {
+ try (Writer w = new FileWriter(file)) {
w.write(this.toString(classHierarchy));
}
}
@@ -229,7 +229,7 @@
@Override
public ClassHierarchy fromFile(final File file) throws IOException {
final AvroNode avroNode;
- try (final DataFileReader<AvroNode> dataFileReader =
+ try (DataFileReader<AvroNode> dataFileReader =
new DataFileReader<>(file, new SpecificDatumReader<>(AvroNode.class))) {
avroNode = dataFileReader.next();
}
@@ -253,7 +253,7 @@
@Override
public ClassHierarchy fromTextFile(final File file) throws IOException {
final StringBuilder stringBuilder = new StringBuilder();
- try (final BufferedReader reader = new BufferedReader(new FileReader(file))) {
+ try (BufferedReader reader = new BufferedReader(new FileReader(file))) {
String line = reader.readLine();
while (line != null) {
stringBuilder.append(line);
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
index 0fda45e..57768fc 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/protobuf/ProtocolBufferClassHierarchy.java
@@ -220,8 +220,8 @@
*/
public static void serialize(final File file, final ClassHierarchy classHierarchy) throws IOException {
final ClassHierarchyProto.Node node = serializeNode(classHierarchy.getNamespace());
- try (final FileOutputStream output = new FileOutputStream(file)) {
- try (final DataOutputStream dos = new DataOutputStream(output)) {
+ try (FileOutputStream output = new FileOutputStream(file)) {
+ try (DataOutputStream dos = new DataOutputStream(output)) {
node.writeTo(dos);
}
}
@@ -236,7 +236,7 @@
* @deprecated in 0.12. Use AvroClassHierarchySerializer instead
*/
public static ClassHierarchy deserialize(final File file) throws IOException {
- try (final InputStream stream = new FileInputStream(file)) {
+ try (InputStream stream = new FileInputStream(file)) {
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(stream);
return new ProtocolBufferClassHierarchy(root);
}
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
index bb74c19..792816f 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/util/ValidateConfiguration.java
@@ -85,7 +85,7 @@
// TODO[JIRA REEF-400] Use the AvroClassHierarchySerializer
final ClassHierarchyProto.Node root;
- try (final InputStream chin = new FileInputStream(this.ch)) {
+ try (InputStream chin = new FileInputStream(this.ch)) {
root = ClassHierarchyProto.Node.parseFrom(chin);
}
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
index 2a39b3d..a7d383d 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/ClassHierarchyDeserializationTest.java
@@ -47,7 +47,7 @@
@Test
public void testDeserializationForTasks() {
// TODO: The file should be written by Avro (REEF-400)
- try (final InputStream chin = Thread.currentThread().getContextClassLoader()
+ try (InputStream chin = Thread.currentThread().getContextClassLoader()
.getResourceAsStream("Task.bin")) {
// TODO: Use AvroClassHierarchySerializer instead (REEF-400)
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
@@ -85,7 +85,7 @@
final ConfigurationBuilder eventConfigurationBuilder;
// TODO: The file should be written by Avro (REEF-400)
- try (final InputStream chin = Thread.currentThread().getContextClassLoader()
+ try (InputStream chin = Thread.currentThread().getContextClassLoader()
.getResourceAsStream("Task.bin")) {
// TODO: Use AvroClassHierarchySerializer instead (REEF-400)
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
@@ -97,7 +97,7 @@
}
// TODO: The file should be written by Avro (REEF-400)
- try (final InputStream chin = Thread.currentThread().getContextClassLoader()
+ try (InputStream chin = Thread.currentThread().getContextClassLoader()
.getResourceAsStream("Event.bin")) {
// TODO: Use AvroClassHierarchySerializer instead (REEF-400)
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
@@ -117,7 +117,7 @@
@Test
public void testDeserializationForEvent() {
// TODO: The file should be written by Avro (REEF-400)
- try (final InputStream chin = Thread.currentThread().getContextClassLoader()
+ try (InputStream chin = Thread.currentThread().getContextClassLoader()
.getResourceAsStream("Event.bin")) {
// TODO: Use AvroClassHierarchySerializer instead (REEF-400)
final ClassHierarchyProto.Node root = ClassHierarchyProto.Node.parseFrom(chin);
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/Handler.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/Handler.java
index 9a750fb..3c06892 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/Handler.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/Handler.java
@@ -25,6 +25,6 @@
*/
interface Handler<T> {
- void process(final T value);
+ void process(T value);
}
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
index c66fbba..b6a8de8 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RoundTripTest.java
@@ -31,9 +31,9 @@
*/
public abstract class RoundTripTest {
- public abstract Configuration roundTrip(final Configuration configuration) throws Exception;
+ public abstract Configuration roundTrip(Configuration configuration) throws Exception;
- public abstract Configuration roundTrip(final Configuration configuration, final ClassHierarchy classHierarchy)
+ public abstract Configuration roundTrip(Configuration configuration, ClassHierarchy classHierarchy)
throws Exception;
@Test
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
index de9b631..76b654d 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
@@ -72,7 +72,7 @@
}
final class IntegerHandler implements Handler<Integer> {
- final int foo = 42;
+ private final int foo = 42;
@Override
public void process(final Integer value) {
@@ -104,7 +104,7 @@
}
final class StringHandler implements Handler<String> {
- final int bar = -42;
+ private final int bar = -42;
@Override
public void process(final String value) {
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java
index 1773881..3123d13 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/FailClient.java
@@ -99,7 +99,7 @@
.bindNamedParameter(RemoteConfiguration.MessageCodec.class, REEFMessageCodec.class)
.build();
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(runtimeConfig, driverConfig)) {
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(runtimeConfig, driverConfig)) {
reef.run();
return reef.getLastStatus();
}
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestEnvironment.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestEnvironment.java
index a7e149e..95e0738 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestEnvironment.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestEnvironment.java
@@ -54,7 +54,7 @@
*/
int getTestTimeout();
- LauncherStatus run(final Configuration driverConfiguration);
+ LauncherStatus run(Configuration driverConfiguration);
/**
* Returns the runtimeName for the environment.
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/driver/REEFEnvironmentDriverTest.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/driver/REEFEnvironmentDriverTest.java
index 915ea3a..8b836de 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/driver/REEFEnvironmentDriverTest.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/driver/REEFEnvironmentDriverTest.java
@@ -54,7 +54,7 @@
@Test
public void testREEFEnvironmentDriver() throws BindException, InjectionException {
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(LOCAL_DRIVER_MODULE, DRIVER_CONFIG)) {
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(LOCAL_DRIVER_MODULE, DRIVER_CONFIG)) {
reef.run();
final ReefServiceProtos.JobStatusProto status = reef.getLastStatus();
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/examples/TestHelloREEFYarnUnmanagedAM.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/examples/TestHelloREEFYarnUnmanagedAM.java
index c1df521..b231260 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/examples/TestHelloREEFYarnUnmanagedAM.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/examples/TestHelloREEFYarnUnmanagedAM.java
@@ -71,7 +71,7 @@
LOG.log(Level.FINE, "Launching Unmanaged AM: {0}", JAR_PATH);
- try (final DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
+ try (DriverLauncher client = DriverLauncher.getLauncher(RUNTIME_CONFIG)) {
final String appId = client.submit(DRIVER_CONFIG, 10000);
LOG.log(Level.INFO, "Job submitted: {0}", appId);
@@ -81,7 +81,7 @@
.set(UnmanagedAmYarnDriverConfiguration.JOB_SUBMISSION_DIRECTORY, DRIVER_ROOT_PATH)
.build();
- try (final REEFEnvironment reef = REEFEnvironment.fromConfiguration(yarnAmConfig, DRIVER_CONFIG)) {
+ try (REEFEnvironment reef = REEFEnvironment.fromConfiguration(yarnAmConfig, DRIVER_CONFIG)) {
reef.run();
diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/exception/InvalidIdentifierException.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/exception/InvalidIdentifierException.java
index f921c36..4d0e0cb 100644
--- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/exception/InvalidIdentifierException.java
+++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/exception/InvalidIdentifierException.java
@@ -18,12 +18,15 @@
*/
package org.apache.reef.util.exception;
+
/**
* Generated when the identifier passed to MultiAsyncToSync.release is
* invalid.
*/
public final class InvalidIdentifierException extends Exception {
- final long identifier;
+
+ private final long identifier;
+
/**:
* See java.lang.Exception.
*/
diff --git a/lang/java/reef-utils/src/test/java/org/apache/reef/util/MultiAsyncToSyncTest.java b/lang/java/reef-utils/src/test/java/org/apache/reef/util/MultiAsyncToSyncTest.java
index 1a1d4d3..bfeb061 100644
--- a/lang/java/reef-utils/src/test/java/org/apache/reef/util/MultiAsyncToSyncTest.java
+++ b/lang/java/reef-utils/src/test/java/org/apache/reef/util/MultiAsyncToSyncTest.java
@@ -170,8 +170,7 @@
final long timeoutPeriodSeconds = 4;
final int input = 1;
- try (final SynchronousApi apiObject =
- new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
+ try (SynchronousApi apiObject = new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
final int result = apiObject.apiCall(input);
Assert.assertEquals("Value incremented by one", input + 1, result);
}
@@ -189,8 +188,7 @@
final long timeoutPeriodSeconds = 2;
final int input = 1;
- try (final SynchronousApi apiObject =
- new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
+ try (SynchronousApi apiObject = new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
final int result = apiObject.apiCall(input);
Assert.assertEquals("Timeout occurred", result, 0);
}
@@ -209,8 +207,7 @@
final int incrementerSleepTimeSeconds = 2;
final long timeoutPeriodSeconds = 4;
- try (final SynchronousApi apiObject =
- new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
+ try (SynchronousApi apiObject = new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 2)) {
final String function = "apiCall";
final int input = 1;
final FutureTask<Integer> task1 =
@@ -251,8 +248,7 @@
final FutureTask[] tasks = new FutureTask[nTasks];
final ExecutorService executor = Executors.newFixedThreadPool(10);
- try (final SynchronousApi apiObject =
- new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 10)) {
+ try (SynchronousApi apiObject = new SynchronousApi(incrementerSleepTimeSeconds, timeoutPeriodSeconds, 10)) {
for (int idx = 0; idx < nTasks; ++idx) {
tasks[idx] = new FutureTask<>(new MethodCallable<Integer>(apiObject, function, idx));
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageDeserializer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageDeserializer.java
index e918d90..1800f34 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageDeserializer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageDeserializer.java
@@ -38,5 +38,5 @@
* @throws InvocationTargetException Subclass threw and exception.
*/
void deserialize(BinaryDecoder decoder, MultiObserver observer, long sequence)
- throws IOException, IllegalAccessException, InvocationTargetException;
+ throws IOException, IllegalAccessException, InvocationTargetException;
}
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageSerializer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageSerializer.java
index 9c1e071..734e8d4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageSerializer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/IMessageSerializer.java
@@ -35,7 +35,5 @@
* @throws IOException An error occurred writing the message to the outputStream.
*/
void serialize(ByteArrayOutputStream outputStream, SpecificRecord message, long sequence)
- throws IOException;
+ throws IOException;
}
-
-
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/ProtocolSerializer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/ProtocolSerializer.java
index a0c5cff..0091f9f 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/ProtocolSerializer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/ProtocolSerializer.java
@@ -111,7 +111,7 @@
public byte[] write(final SpecificRecord message, final long sequence) {
final String classId = getClassId(message.getClass());
- try (final ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) {
LOG.log(Level.FINEST, "Serializing message: {0}", classId);
@@ -135,7 +135,7 @@
*/
public void read(final byte[] messageBytes, final MultiObserver observer) {
- try (final InputStream inputStream = new ByteArrayInputStream(messageBytes)) {
+ try (InputStream inputStream = new ByteArrayInputStream(messageBytes)) {
// Binary decoder for both the header and the message.
final BinaryDecoder decoder = DecoderFactory.get().binaryDecoder(inputStream, null);
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/impl/MessageDeserializerImpl.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/impl/MessageDeserializerImpl.java
index 55d5716..c97e893 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/impl/MessageDeserializerImpl.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/avro/impl/MessageDeserializerImpl.java
@@ -53,7 +53,7 @@
* @throws InvocationTargetException Subclass threw and exception.
*/
public void deserialize(final BinaryDecoder decoder, final MultiObserver observer, final long sequence)
- throws IOException, IllegalAccessException, InvocationTargetException {
+ throws IOException, IllegalAccessException, InvocationTargetException {
final TMessage message = messageReader.read(null, decoder);
if (message != null) {
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
index 310de6d..06e0b3e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManager.java
@@ -38,7 +38,7 @@
* @param messageType a message class type
* @return an event handler
*/
- <T> EventHandler<T> getHandler(final RemoteIdentifier destinationIdentifier, final Class<? extends T> messageType);
+ <T> EventHandler<T> getHandler(RemoteIdentifier destinationIdentifier, Class<? extends T> messageType);
/**
* Registers the given EventHandler to be invoked when messages of Type T
@@ -53,9 +53,9 @@
* @param theHandler the event handler
* @return the subscription that can be used to unsubscribe later
*/
- <T, U extends T> AutoCloseable registerHandler(final RemoteIdentifier sourceIdentifier,
- final Class<U> messageType,
- final EventHandler<T> theHandler);
+ <T, U extends T> AutoCloseable registerHandler(RemoteIdentifier sourceIdentifier,
+ Class<U> messageType,
+ EventHandler<T> theHandler);
/**
* Registers the given EventHandler to be called for the given message type
@@ -69,8 +69,8 @@
* @param theHandler the event handler
* @return the subscription that can be used to unsubscribe later
*/
- <T, U extends T> AutoCloseable registerHandler(final Class<U> messageType,
- final EventHandler<RemoteMessage<T>> theHandler);
+ <T, U extends T> AutoCloseable registerHandler(Class<U> messageType,
+ EventHandler<RemoteMessage<T>> theHandler);
/**
* Access the Identifier of this.
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManagerFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManagerFactory.java
index 60bd2b8..f235fbc 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManagerFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/RemoteManagerFactory.java
@@ -35,7 +35,7 @@
* @param name the name of used by the returned RemoteManager to determine the address to bind to. to instantiate.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- RemoteManager getInstance(final String name);
+ RemoteManager getInstance(String name);
/**
* @param name the name of the returned RemoteManager to instantiate.
@@ -44,9 +44,9 @@
* @param <T> the message type sent / received by the returned RemoteManager.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- <T> RemoteManager getInstance(final String name,
- final Codec<T> codec,
- final EventHandler<Throwable> errorHandler);
+ <T> RemoteManager getInstance(String name,
+ Codec<T> codec,
+ EventHandler<Throwable> errorHandler);
/**
* @param name the name of the returned RemoteManager to instantiate.
@@ -56,10 +56,10 @@
* @param <T> the message type sent / received by the returned RemoteManager.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- <T> RemoteManager getInstance(final String name,
- final int listeningPort,
- final Codec<T> codec,
- final EventHandler<Throwable> errorHandler);
+ <T> RemoteManager getInstance(String name,
+ int listeningPort,
+ Codec<T> codec,
+ EventHandler<Throwable> errorHandler);
/**
* @param name the name of the returned RemoteManager to instantiate.
@@ -69,10 +69,10 @@
* @param <T> the message type sent / received by the returned RemoteManager.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- <T> RemoteManager getInstance(final String name,
- final String hostAddress,
- final int listeningPort,
- final Codec<T> codec);
+ <T> RemoteManager getInstance(String name,
+ String hostAddress,
+ int listeningPort,
+ Codec<T> codec);
/**
* The old constructor of DefaultRemoteManagerImplementation. Avoid if you can.
@@ -89,14 +89,14 @@
* @param <T> the message type sent / received by the returned RemoteManager.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- <T> RemoteManager getInstance(final String name,
- final String hostAddress,
- final int listeningPort,
- final Codec<T> codec,
- final EventHandler<Throwable> errorHandler,
- final boolean orderingGuarantee,
- final int numberOfTries,
- final int retryTimeout);
+ <T> RemoteManager getInstance(String name,
+ String hostAddress,
+ int listeningPort,
+ Codec<T> codec,
+ EventHandler<Throwable> errorHandler,
+ boolean orderingGuarantee,
+ int numberOfTries,
+ int retryTimeout);
/**
* The all-out constructor of DefaultRemoteManagerImplementation. Avoid if you can.
@@ -117,16 +117,16 @@
* @param <T> the message type sent / received by the returned RemoteManager.
* @return a new instance of RemoteManager with all parameters but the given one injected via Tang.
*/
- <T> RemoteManager getInstance(final String name,
- final String hostAddress,
- final int listeningPort,
- final Codec<T> codec,
- final EventHandler<Throwable> errorHandler,
- final boolean orderingGuarantee,
- final int numberOfTries,
- final int retryTimeout,
- final LocalAddressProvider localAddressProvider,
- final TcpPortProvider tcpPortProvider);
+ <T> RemoteManager getInstance(String name,
+ String hostAddress,
+ int listeningPort,
+ Codec<T> codec,
+ EventHandler<Throwable> errorHandler,
+ boolean orderingGuarantee,
+ int numberOfTries,
+ int retryTimeout,
+ LocalAddressProvider localAddressProvider,
+ TcpPortProvider tcpPortProvider);
}
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ObjectSerializableCodec.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ObjectSerializableCodec.java
index 7a8bd21..18bc228 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ObjectSerializableCodec.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/ObjectSerializableCodec.java
@@ -44,8 +44,8 @@
*/
@Override
public byte[] encode(final T obj) {
- try (final ByteArrayOutputStream bos = new ByteArrayOutputStream();
- final ObjectOutputStream out = new ObjectOutputStream(bos)) {
+ try (ByteArrayOutputStream bos = new ByteArrayOutputStream();
+ ObjectOutputStream out = new ObjectOutputStream(bos)) {
out.writeObject(obj);
return bos.toByteArray();
} catch (final IOException ex) {
@@ -63,7 +63,7 @@
@SuppressWarnings("unchecked")
@Override
public T decode(final byte[] buf) {
- try (final ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(buf))) {
+ try (ObjectInputStream in = new ObjectInputStream(new ByteArrayInputStream(buf))) {
return (T) in.readObject();
} catch (final ClassNotFoundException | IOException ex) {
throw new RemoteRuntimeException(ex);
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SubscriptionHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SubscriptionHandler.java
index 8f2eecf..8dab059 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SubscriptionHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/impl/SubscriptionHandler.java
@@ -25,7 +25,7 @@
class SubscriptionHandler<T> implements AutoCloseable {
interface Unsubscriber<T> {
- void unsubscribe(final T token);
+ void unsubscribe(T token);
}
private final T token;
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
index a58da0e..cfbfc82 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/TransportFactory.java
@@ -56,11 +56,11 @@
* @param retryTimeout retry timeout
* @return transport
*/
- Transport newInstance(final String hostAddress, int port,
- final EStage<TransportEvent> clientStage,
- final EStage<TransportEvent> serverStage,
- final int numberOfTries,
- final int retryTimeout);
+ Transport newInstance(String hostAddress, int port,
+ EStage<TransportEvent> clientStage,
+ EStage<TransportEvent> serverStage,
+ int numberOfTries,
+ int retryTimeout);
/**
* Creates a transport.
@@ -74,13 +74,13 @@
* @param tcpPortProvider tcpPortProvider
* @return transport
*/
- Transport newInstance(final String hostAddress,
+ Transport newInstance(String hostAddress,
int port,
- final EStage<TransportEvent> clientStage,
- final EStage<TransportEvent> serverStage,
- final int numberOfTries,
- final int retryTimeout,
- final TcpPortProvider tcpPortProvider);
+ EStage<TransportEvent> clientStage,
+ EStage<TransportEvent> serverStage,
+ int numberOfTries,
+ int retryTimeout,
+ TcpPortProvider tcpPortProvider);
}
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
index d286d0c..67b8970 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
@@ -85,9 +85,9 @@
this.closeChannel(ctx.channel());
}
- protected abstract TransportEvent getTransportEvent(final byte[] message, final Channel channel);
+ protected abstract TransportEvent getTransportEvent(byte[] message, Channel channel);
- protected abstract void exceptionCleanup(final ChannelHandlerContext ctx, Throwable cause);
+ protected abstract void exceptionCleanup(ChannelHandlerContext ctx, Throwable cause);
protected void closeChannel(final Channel channel) {
final LinkReference refRemoved =
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
index 10de932..dbd9318 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/rx/Observer.java
@@ -32,7 +32,7 @@
*
* @param value
*/
- void onNext(final T value);
+ void onNext(T value);
/**
* Notifies the observer that the provider has experienced an error
@@ -40,7 +40,7 @@
*
* @param error
*/
- void onError(final Exception error);
+ void onError(Exception error);
/**
* Notifies the observer that the provider has finished sending push-based
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
index 966e30f..83fea3d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/Clock.java
@@ -48,7 +48,7 @@
* @return Newly scheduled alarm.
* @throws IllegalStateException When the clock has been already closed.
*/
- Time scheduleAlarm(final int offset, final EventHandler<Alarm> handler);
+ Time scheduleAlarm(int offset, EventHandler<Alarm> handler);
/**
* This will stop the clock after all client alarms
@@ -68,7 +68,7 @@
* client alarms to finish. Stops with an exception that
* is propagated to RuntimeStopHandlers.
*/
- void stop(final Throwable exception);
+ void stop(Throwable exception);
/**
* Clock is idle if it has no future Alarms set.
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/Timer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/Timer.java
index 1935938..8b49c14 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/Timer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/time/runtime/Timer.java
@@ -44,7 +44,7 @@
* @deprecated [REEF-1532] Prefer passing Time object instead of the numeric timestamp.
* Remove after release 0.16.
*/
- long getDuration(final long time);
+ long getDuration(long time);
/**
* Get the number of milliseconds between current time as tracked by the Timer implementation
@@ -53,7 +53,7 @@
* @return Difference in milliseconds between the given timestamp and the time tracked by the timer.
* The result is a negative number if the timestamp is in the past (according to the timer's time).
*/
- long getDuration(final Time time);
+ long getDuration(Time time);
/**
* Check if the event with a given timestamp has occurred, according to the timer.
@@ -64,7 +64,7 @@
* @deprecated [REEF-1532] Prefer passing Time object instead of the numeric timestamp.
* Remove after release 0.16.
*/
- boolean isReady(final long time);
+ boolean isReady(long time);
/**
* Check if the event with a given timestamp has occurred, according to the timer.
@@ -73,5 +73,5 @@
* @param time Timestamp object that wraps time in milliseconds.
* @return False if the given timestamp is still in the timer's time future.
*/
- boolean isReady(final Time time);
+ boolean isReady(Time time);
}
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
index 126316f..b118933 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteIdentifierFactoryTest.java
@@ -70,7 +70,7 @@
final Codec<?> codec = new MultiCodec<Object>(clazzToCodecMap);
- try (final RemoteManager rm =
+ try (RemoteManager rm =
remoteManagerFactory.getInstance("TestRemoteManager", 0, codec, new LoggingEventHandler<Throwable>())) {
final RemoteIdentifier id = rm.getMyIdentifier();
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
index 08426c0..6289d3c 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
@@ -268,7 +268,7 @@
final ExceptionHandler errorHandler = new ExceptionHandler(monitor);
- try (final RemoteManager rm = remoteManagerFactory.getInstance("name", 0, codec, errorHandler)) {
+ try (RemoteManager rm = remoteManagerFactory.getInstance("name", 0, codec, errorHandler)) {
final RemoteIdentifier remoteId = rm.getMyIdentifier();
final EventHandler<StartEvent> proxyConnection = rm.getHandler(remoteId, StartEvent.class);
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/RuntimeClockTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/RuntimeClockTest.java
index d3b2b11..1f3a826 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/RuntimeClockTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/RuntimeClockTest.java
@@ -77,7 +77,7 @@
LoggingUtils.setLoggingLevel(Level.FINEST);
- try (final RuntimeClock clock = buildClock(RealTimer.class)) {
+ try (RuntimeClock clock = buildClock(RealTimer.class)) {
new Thread(clock).start();
@@ -101,7 +101,7 @@
LoggingUtils.setLoggingLevel(Level.FINEST);
- try (final RuntimeClock clock = buildClock(RealTimer.class)) {
+ try (RuntimeClock clock = buildClock(RealTimer.class)) {
new Thread(clock).start();
@@ -140,7 +140,7 @@
final int numThreads = 3;
final CountDownLatch eventCountLatch = new CountDownLatch(numThreads);
- try (final RuntimeClock clock = buildClock(RealTimer.class)) {
+ try (RuntimeClock clock = buildClock(RealTimer.class)) {
final EventHandler<Alarm> handler = new EventHandler<Alarm>() {
@Override
@@ -152,7 +152,7 @@
new Thread(clock).start();
- try (final ThreadPoolStage<Alarm> stage = new ThreadPoolStage<>(handler, numThreads)) {
+ try (ThreadPoolStage<Alarm> stage = new ThreadPoolStage<>(handler, numThreads)) {
for (int i = 0; i < numThreads; ++i) {
stage.onNext(null);
@@ -171,7 +171,7 @@
final int expectedEvent = 2;
final CountDownLatch eventCountLatch = new CountDownLatch(expectedEvent);
- try (final RuntimeClock clock = buildClock(LogicalTimer.class)) {
+ try (RuntimeClock clock = buildClock(LogicalTimer.class)) {
new Thread(clock).start();
@@ -197,7 +197,7 @@
final long[] expected = new long[numAlarms];
- try (final RuntimeClock clock = buildClock(RealTimer.class)) {
+ try (RuntimeClock clock = buildClock(RealTimer.class)) {
new Thread(clock).start();
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroDriverInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroDriverInfoSerializer.java
index ad024cd..0f7be4e 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroDriverInfoSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroDriverInfoSerializer.java
@@ -56,7 +56,7 @@
@Override
public String toString(final AvroDriverInfo avroDriverInfo) {
final DatumWriter<AvroDriverInfo> driverWriter = new SpecificDatumWriter<>(AvroDriverInfo.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(avroDriverInfo.getSchema(), out);
driverWriter.write(avroDriverInfo, encoder);
encoder.flush();
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorInfoSerializer.java
index 73e0354..06a8902 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorInfoSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorInfoSerializer.java
@@ -92,7 +92,7 @@
@Override
public String toString(final AvroEvaluatorsInfo avroEvaluatorsInfo) {
final DatumWriter<AvroEvaluatorsInfo> evaluatorWriter = new SpecificDatumWriter<>(AvroEvaluatorsInfo.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(avroEvaluatorsInfo.getSchema(), out);
evaluatorWriter.write(avroEvaluatorsInfo, encoder);
encoder.flush();
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorListSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorListSerializer.java
index 476b976..a29ef1a 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorListSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroEvaluatorListSerializer.java
@@ -73,7 +73,7 @@
@Override
public String toString(final AvroEvaluatorList avroEvaluatorList) {
final DatumWriter<AvroEvaluatorList> evaluatorWriter = new SpecificDatumWriter<>(AvroEvaluatorList.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(avroEvaluatorList.getSchema(), out);
evaluatorWriter.write(avroEvaluatorList, encoder);
encoder.flush();
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroHttpSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroHttpSerializer.java
index e39966c..e072da5 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroHttpSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/AvroHttpSerializer.java
@@ -61,7 +61,7 @@
*/
public String toString(final AvroHttpRequest request) {
final DatumWriter<AvroHttpRequest> configurationWriter = new SpecificDatumWriter<>(AvroHttpRequest.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final JsonEncoder encoder = EncoderFactory.get().jsonEncoder(AvroHttpRequest.SCHEMA$, out);
configurationWriter.write(request, encoder);
encoder.flush();
@@ -76,7 +76,7 @@
*/
public byte[] toBytes(final AvroHttpRequest request) {
final DatumWriter<AvroHttpRequest> requestWriter = new SpecificDatumWriter<>(AvroHttpRequest.class);
- try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
+ try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
requestWriter.write(request, encoder);
encoder.flush();
@@ -95,7 +95,7 @@
*/
public void toFile(final AvroHttpRequest avroHttpRequest, final File file) throws IOException, ServletException {
final DatumWriter<AvroHttpRequest> httpWriter = new SpecificDatumWriter<>(AvroHttpRequest.class);
- try (final DataFileWriter<AvroHttpRequest> dataFileWriter = new DataFileWriter<>(httpWriter)) {
+ try (DataFileWriter<AvroHttpRequest> dataFileWriter = new DataFileWriter<>(httpWriter)) {
dataFileWriter.create(avroHttpRequest.getSchema(), file);
dataFileWriter.append(avroHttpRequest);
}
@@ -109,7 +109,7 @@
*/
public AvroHttpRequest fromFile(final File file) throws IOException {
final AvroHttpRequest avrohttpRequest;
- try (final DataFileReader<AvroHttpRequest> dataFileReader =
+ try (DataFileReader<AvroHttpRequest> dataFileReader =
new DataFileReader<>(file, new SpecificDatumReader<>(AvroHttpRequest.class))) {
avrohttpRequest = dataFileReader.next();
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
index 6104c26..3b0629d 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/DriverInfoSerializer.java
@@ -34,7 +34,7 @@
* @param startTime
* @return AvroDriverInfo object
*/
- AvroDriverInfo toAvro(final String id, final String startTime, final List<AvroReefServiceInfo> services);
+ AvroDriverInfo toAvro(String id, String startTime, List<AvroReefServiceInfo> services);
/**
* Convert AvroDriverInfo object to JSon string.
@@ -42,5 +42,5 @@
* @param avroDriverInfo
* @return
*/
- String toString(final AvroDriverInfo avroDriverInfo);
+ String toString(AvroDriverInfo avroDriverInfo);
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorInfoSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorInfoSerializer.java
index 11d2b1e..642276b 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorInfoSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorInfoSerializer.java
@@ -34,10 +34,10 @@
* Build AvroEvaluatorsInfo object from raw data.
*/
AvroEvaluatorsInfo toAvro(
- final List<String> ids, final Map<String, EvaluatorDescriptor> evaluators);
+ List<String> ids, Map<String, EvaluatorDescriptor> evaluators);
/**
* Convert AvroEvaluatorsInfo object to JSON string.
*/
- String toString(final AvroEvaluatorsInfo avroEvaluatorsInfo);
+ String toString(AvroEvaluatorsInfo avroEvaluatorsInfo);
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
index 1df0261..da59496 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/EvaluatorListSerializer.java
@@ -36,9 +36,9 @@
* @param startTime
* @return
*/
- AvroEvaluatorList toAvro(final Map<String, EvaluatorDescriptor> evaluatorMap,
- final int totalEvaluators,
- final String startTime);
+ AvroEvaluatorList toAvro(Map<String, EvaluatorDescriptor> evaluatorMap,
+ int totalEvaluators,
+ String startTime);
/**
* Convert AvroEvaluatorList to JSon string.
@@ -46,5 +46,5 @@
* @param avroEvaluatorList
* @return
*/
- String toString(final AvroEvaluatorList avroEvaluatorList);
+ String toString(AvroEvaluatorList avroEvaluatorList);
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
index d6a5762..8ccb12c 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpHandler.java
@@ -36,7 +36,7 @@
/**
* Set specification of the handler. e.g Reef
*/
- void setUriSpecification(final String s);
+ void setUriSpecification(String s);
/**
* Will be called when request comes.
@@ -44,6 +44,6 @@
* @param parsedHttpRequest
* @param response
*/
- void onHttpRequest(final ParsedHttpRequest parsedHttpRequest, final HttpServletResponse response)
+ void onHttpRequest(ParsedHttpRequest parsedHttpRequest, HttpServletResponse response)
throws IOException, ServletException;
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
index 43c3e8f..d7c629e 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServer.java
@@ -52,5 +52,5 @@
*
* @param httpHandler
*/
- void addHttpHandler(final HttpHandler httpHandler);
+ void addHttpHandler(HttpHandler httpHandler);
}
diff --git a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerImpl.java b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerImpl.java
index a10a4eb..60f0da1 100644
--- a/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerImpl.java
+++ b/lang/java/reef-webserver/src/main/java/org/apache/reef/webserver/HttpServerImpl.java
@@ -88,7 +88,7 @@
this.jettyHandler = jettyHandler;
this.hostAddress = UNKNOWN_HOST_NAME.equals(hostAddress) ? addressProvider.getLocalAddress() : hostAddress;
- try (final LoggingScope ls = this.loggingScopeFactory.httpServer()) {
+ try (LoggingScope ls = this.loggingScopeFactory.httpServer()) {
Server srv = null;
int availablePort = -1;
